From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id BMK9H6FfcmFvawAAWB0awg (envelope-from ) for ; Fri, 22 Oct 2021 02:52:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 714331F0BD; Fri, 22 Oct 2021 02:52:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 71B021ECEB for ; Fri, 22 Oct 2021 02:52:16 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1ED8F3857830 for ; Fri, 22 Oct 2021 06:52:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1ED8F3857830 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1634885536; bh=NQFjK0jF5kq5eERuPf6Q1NB67mh83r3E1gExUjTBf7A=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=kjbiq0MMYWZq/hUsuAwfoxiPHO7glNv8bWQZxxdh8Jr88MOvt8nc4rJfxo6T+ib14 dkJk3anpmBTv/kFFrihCWo1tBPFtYamiv7OP0yn5WLfGQvNbg0vVXRSRzeuKnGoMBI wpiLWT5hrynn//v+GZaz+k0bd8ZrNdJdvma10B04= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 7761A3858416 for ; Fri, 22 Oct 2021 06:51:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7761A3858416 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 83C491FD59; Fri, 22 Oct 2021 06:51:56 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 685EF13AAD; Fri, 22 Oct 2021 06:51:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ZLoPGIxfcmFSFAAAMHmgww (envelope-from ); Fri, 22 Oct 2021 06:51:56 +0000 Subject: [PING][PATCH][gdb/testsuite] Fix FAILs in gdb.mi/mi-breakpoint-changed.exp To: gdb-patches@sourceware.org References: <20211005144645.GA29297@delia> Message-ID: Date: Fri, 22 Oct 2021 08:51:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20211005144645.GA29297@delia> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 10/5/21 4:46 PM, Tom de Vries wrote: > Hi, > > Since commit e36788d1354 "[gdb/testsuite] Fix handling of nr_args < 3 in > mi_gdb_test" we run into: > ... > PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: mi runto main > Expecting: ^(-break-insert -f pendfunc1[^M > ]+)?((&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,\ > bkpt=\{number="2",type="breakpoint".*\}.*\n\^done[^M > ]+[(]gdb[)] ^M > [ ]*) > -break-insert -f pendfunc1^M > ^done,bkpt={number="2",type="breakpoint",disp="keep",enabled="y",\ > addr="0x00007ffff7bd559e",func="pendfunc1",\ > file="gdb/testsuite/gdb.mi/pendshr1.c",\ > fullname="gdb/testsuite/gdb.mi/pendshr1.c",line="21",thread-groups=["i1"],\ > times="0",original-location="pendfunc1"}^M > (gdb) ^M > FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-insert -f pendfunc1 (unexpected output) > ... > > The regexp expects a breakpoint-created event, but that's actually suppressed > by the command: > ... > DEF_MI_CMD_MI_1 ("break-insert", mi_cmd_break_insert, > &mi_suppress_notification.breakpoint), > ... > > Fix this by updating the regexp. > > Likewise for the following: > ... > PASS: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-insert -f pendfunc1 > Expecting: ^(-break-enable count 1 2[^M > ]+)?(=breakpoint-modified,\ > bkpt=\{number="2",type="breakpoint",disp="dis",enabled="y".*\}.*\n\^done[^M > ]+[(]gdb[)] ^M > [ ]*) > -break-enable count 1 2^M > ^done^M > (gdb) ^M > FAIL: gdb.mi/mi-breakpoint-changed.exp: test_auto_disable: \ > -break-enable count 1 2 (unexpected out\ > put) > ... > > Tested on x86_64-linux. > > Any comments? > Ping. Thanks, - Tom > [gdb/testsuite] Fix FAILs in gdb.mi/mi-breakpoint-changed.exp > > --- > gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp > index d068a25b9f4..4376bb883e6 100644 > --- a/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp > +++ b/gdb/testsuite/gdb.mi/mi-breakpoint-changed.exp > @@ -273,11 +273,11 @@ proc test_auto_disable { } { > > # Set the breakpoint. > mi_gdb_test "-break-insert -f pendfunc1" \ > - {(&.*)*.*~"Breakpoint 2 at.*\\n".*=breakpoint-created,bkpt=\{number="2",type="breakpoint".*\}.*\n\^done} > + {\^done,bkpt=\{number="2",type="breakpoint".*\}.*} > > # Enable for one shot only. > mi_gdb_test "-break-enable count 1 2" \ > - {=breakpoint-modified,bkpt=\{number="2",type="breakpoint",disp="dis",enabled="y".*\}.*\n\^done} > + {\^done} > > mi_send_resuming_command "exec-continue" "continuing execution to breakpoint" > >