From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15823 invoked by alias); 17 Jan 2017 19:58:57 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 14904 invoked by uid 89); 17 Jan 2017 19:58:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.5 required=5.0 tests=AWL,BAYES_20,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy=HX-PHP-Originating-Script:rcube.php, H*u:1.2.3, H*UA:1.2.3, H*i:sk:5533317 X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 17 Jan 2017 19:58:56 +0000 Received: by simark.ca (Postfix, from userid 33) id 5555E1E167; Tue, 17 Jan 2017 14:58:54 -0500 (EST) To: Pedro Alves Subject: Re: [PATCH 5/5] Eliminate make_cleanup_ui_file_delete / make ui_file a class hierarchy X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 17 Jan 2017 19:58:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <5533317a1fdb2e5f36e64731aef84993@polymtl.ca> References: <1484617147-2506-1-git-send-email-palves@redhat.com> <1484617147-2506-6-git-send-email-palves@redhat.com> <5533317a1fdb2e5f36e64731aef84993@polymtl.ca> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.3 X-IsSubscribed: yes X-SW-Source: 2017-01/txt/msg00336.txt.bz2 On 2017-01-17 14:57, Simon Marchi wrote: > I've only looked at ui-file.h/c so far, but overall it looks really > nice. Oh, and patches 1-4 all LGTM.