From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8822 invoked by alias); 7 Jun 2018 03:36:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 8768 invoked by uid 89); 7 Jun 2018 03:36:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:767 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Jun 2018 03:36:12 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w573a51J029073 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 6 Jun 2018 23:36:10 -0400 Received: by simark.ca (Postfix, from userid 112) id 4CCA31E75F; Wed, 6 Jun 2018 23:36:05 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id E87901E4F7; Wed, 6 Jun 2018 23:36:02 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Thu, 07 Jun 2018 03:36:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Keith Seitz , gdb-patches@sourceware.org Subject: Re: [RFA] Change build_address_symbolic to return std::string In-Reply-To: <87tvqf35j0.fsf@tromey.com> References: <20180505162454.5619-1-tom@tromey.com> <87tvqf35j0.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 7 Jun 2018 03:36:05 +0000 X-IsSubscribed: yes X-SW-Source: 2018-06/txt/msg00164.txt.bz2 On 2018-06-06 18:37, Tom Tromey wrote: >>>>>> "Keith" == Keith Seitz writes: > > Keith> Did someone looks this over already? > > Nope. > >>> +extern int build_address_symbolic (struct gdbarch *, >>> + CORE_ADDR addr, >>> + int do_demangle, >>> + std::string *name, >>> + int *offset, >>> + std::string *filename, >>> + int *line, >>> + int *unmapped); > > Keith> Since you're moving the declaration here, could you please copy > Keith> the comment from the definition here, too, while you're at it, > Keith> replacing it with the usual "See XYZ.h"? [Warning: IANAM] > > Good idea, I've made this change locally. > > Tom The patch LGTM too, including Keith's comment. Thanks, Simon