From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 122987 invoked by alias); 10 Jul 2018 01:56:52 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 122960 invoked by uid 89); 10 Jul 2018 01:56:51 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 10 Jul 2018 01:56:50 +0000 Received: from [10.0.0.11] (unknown [192.222.164.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B30C21E08D; Mon, 9 Jul 2018 21:56:48 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=simark.ca; s=mail; t=1531187808; bh=vksdaBfrhoeTr64xvriMVqbrVQ7xWmoyyJabr4SKFbs=; h=Subject:To:References:From:Date:In-Reply-To:From; b=kBs066X9Ixf3fiKxshmIXg6r1q2h5p9fj9i0XpCQDXpNRrTeFH4x8STdzvWZmr5YR l6Nk6974LU7Hcj2BYkXRoBuQzNU9k4BCPx01BRV+3eyRUHVGofgBGvKyG/0emY3MMQ KOy5uProS5Pl8rljgw+s0WtVtQWv0GBjXD0JiLY0= Subject: Re: [RFA 23/42] Move pending addrmap globals to buildsym_compunit To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-24-tom@tromey.com> From: Simon Marchi Message-ID: Date: Tue, 10 Jul 2018 01:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-24-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-07/txt/msg00238.txt.bz2 On 2018-05-23 12:58 AM, Tom Tromey wrote: > @@ -660,15 +656,14 @@ record_block_range (struct block *block, > need to record this block in the addrmap. */ > if (start != BLOCK_START (block) > || end_inclusive + 1 != BLOCK_END (block)) > - pending_addrmap_interesting = 1; > + buildsym_compunit->m_pending_addrmap_interesting = true; > > - if (! pending_addrmap) > - { > - obstack_init (&pending_addrmap_obstack); > - pending_addrmap = addrmap_create_mutable (&pending_addrmap_obstack); > - } > + if (! buildsym_compunit->m_pending_addrmap) Can you please change this to == nullptr? > + buildsym_compunit->m_pending_addrmap > + = addrmap_create_mutable (&buildsym_compunit->m_pending_addrmap_obstack); > > - addrmap_set_empty (pending_addrmap, start, end_inclusive, block); > + addrmap_set_empty (buildsym_compunit->m_pending_addrmap, > + start, end_inclusive, block); > } > > static struct blockvector * > @@ -706,9 +701,11 @@ make_blockvector (void) > > /* If we needed an address map for this symtab, record it in the > blockvector. */ > - if (pending_addrmap && pending_addrmap_interesting) > + if (buildsym_compunit->m_pending_addrmap > + && buildsym_compunit->m_pending_addrmap_interesting) And here != nullptr. Otherwise, LGTM. Simon