From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16166 invoked by alias); 16 Jan 2009 07:39:26 -0000 Received: (qmail 16155 invoked by uid 22791); 16 Jan 2009 07:39:24 -0000 X-SWARE-Spam-Status: No, hits=-0.4 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33,J_CHICKENPOX_37,J_CHICKENPOX_65,J_CHICKENPOX_74,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from yw-out-1718.google.com (HELO yw-out-1718.google.com) (74.125.46.155) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 16 Jan 2009 07:38:44 +0000 Received: by yw-out-1718.google.com with SMTP id 9so695551ywk.48 for ; Thu, 15 Jan 2009 23:38:42 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.105.15 with SMTP id d15mr866676anc.31.1232091521937; Thu, 15 Jan 2009 23:38:41 -0800 (PST) In-Reply-To: References: Date: Fri, 16 Jan 2009 07:39:00 -0000 Message-ID: Subject: Re: Use external editor in 'commands' command From: Alfredo Ortega To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e645b7687ef1c0046094a948 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00372.txt.bz2 --0016e645b7687ef1c0046094a948 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1837 2009/1/15 Eli Zaretskii : >> Date: Wed, 14 Jan 2009 22:32:03 -0200 >> From: Alfredo Ortega >> >> I see. This updated patch contains my proposed documentation changes >> to gdb.texinfo and refcard.tex. I hope that the patch format is >> adequate. > > Thanks you. > > First, please also submit ChangeLog entries for your changes, both in > code and in documentation. > >> +@item commands @r{[}@var{bnum}@r{]} edit >> +This spawns an external editor for adding or editing commands. the final @code{end} is not necessary in this case. @xref{Choosing your Editor}. > ^^^ > Capital "T" here. > > Also, please leave 2 blanks after a period that ends a sentence. > >> +@node Choosing your Editor >> @subsection Choosing your Editor > > Adding a @node requires that you also modify the @menu in its parent > node, otherwise makeinfo will barf. > >> +\qquad {\it command-list}&execute GDB {\it command-list} every time breakpoint {\it n} is reached. \opt{{\tt silent} suppresses default display} \opt{{\tt edit} use external editor for commands} > ^^^ > A period missing here. > Thanks for the corrections. Here are are both changelogs and the updated diff, I hope there are less errors now... I promise that my next patches will be better! 2009-01-16 Alfredo Ortega * breakpoint.c (commands_command,_initialize_breakpoint): Add the 'edit' keyword to the 'commands' command to allow the use of an external editor to add or modify commands. 2009-01-16 Alfredo Ortega * gdb.texinfo, refcard.tex (breakpoint commands): Added documentation of the edit option, for editing commands with an external editor. --0016e645b7687ef1c0046094a948 Content-Type: text/x-patch; charset=US-ASCII; name="commands.diff" Content-Disposition: attachment; filename="commands.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fq0j9hza0 Content-length: 7922 ZGlmZiAtdXByIE9MRC9nZGIvYnJlYWtwb2ludC5jIE5FVy9nZGIvYnJlYWtw b2ludC5jCi0tLSBPTEQvZ2RiL2JyZWFrcG9pbnQuYwkyMDA5LTAxLTE0IDE3 OjQ2OjI2LjAwMDAwMDAwMCAtMDIwMAorKysgTkVXL2dkYi9icmVha3BvaW50 LmMJMjAwOS0wMS0xNCAxOTozMjo0MC4wMDAwMDAwMDAgLTAyMDAKQEAgLTU4 NSwxNCArNTg1LDIwIEBAIGNvbmRpdGlvbl9jb21tYW5kIChjaGFyICphcmcs IGludCBmcm9tX3QKICAgZXJyb3IgKF8oIk5vIGJyZWFrcG9pbnQgbnVtYmVy ICVkLiIpLCBibnVtKTsKIH0KIAorI2RlZmluZSBDT01NQU5EU19FRENPTU1B TkQgImVkaXQiCisKIHN0YXRpYyB2b2lkCiBjb21tYW5kc19jb21tYW5kIChj aGFyICphcmcsIGludCBmcm9tX3R0eSkKIHsKICAgc3RydWN0IGJyZWFrcG9p bnQgKmI7CiAgIGNoYXIgKnA7Ci0gIGludCBibnVtOworICBpbnQgYm51bSxm c2l6ZTsKICAgc3RydWN0IGNvbW1hbmRfbGluZSAqbDsKLQorICBjaGFyIHZp dG1wWzUwXTsKKyAgY2hhciBjbWRsaW5lWzEwMF07CisgIEZJTEUgKnRtcHN0 cmVhbT1OVUxMOworICBjaGFyICplZGl0b3I7CisgIAogICAvKiBJZiB3ZSBh bGxvd2VkIHRoaXMsIHdlIHdvdWxkIGhhdmUgcHJvYmxlbXMgd2l0aCB3aGVu IHRvCiAgICAgIGZyZWUgdGhlIHN0b3JhZ2UsIGlmIHdlIGNoYW5nZSB0aGUg Y29tbWFuZHMgY3VycmVudGx5CiAgICAgIGJlaW5nIHJlYWQgZnJvbS4gICov CkBAIC02MDIsNiArNjA4LDQxIEBAIGNvbW1hbmRzX2NvbW1hbmQgKGNoYXIg KmFyZywgaW50IGZyb21fdHQKIAogICBwID0gYXJnOwogICBibnVtID0gZ2V0 X251bWJlciAoJnApOworICB2aXRtcFswXT0wOworICAvKiBFZGl0IGNvbW1h bmRzIHdpdGggZXh0ZXJuYWwgZWRpdG9yICovCisgIGlmICghc3RyY21wKENP TU1BTkRTX0VEQ09NTUFORCxwKSkJeworCS8qIEdlbmVyYXRlcyB0aGUgdGVt cG9yYWwgZmlsZSBuYW1lKi8KKwkvKiB2aXRtcCA9IHRlbXBuYW0oTlVMTCwi LmdkYiIpOyB0aGlzIGlzIG1vcmUgc2VjdXJlIGFjY29yZGluZyB0byBtYW4g bWtzdGVtcCwgYnV0IGdjYyBjb21wbGFpbnMuLi4gKi8KKwlwPU5VTEw7CisJ c3RyY3B5KHZpdG1wLCIvdG1wLy5nZGJYWFhYWFgiKTsKKwlpZiAobWtzdGVt cCh2aXRtcCk8MCkgcmV0dXJuOworCUFMTF9CUkVBS1BPSU5UUyAoYikKKwkJ aWYgKGItPm51bWJlciA9PSBibnVtKQorCQkJeworCQkJaWYgKCZiLT5jb21t YW5kcykJeworCQkJCS8qIGNvbW1hbmRzIGV4aXN0cywgbXVzdCBkdW1wIHRo ZW0gdG8gdGhlIHRlbXBvcmFsIGZpbGUgKi8KKwkJCQl0bXBzdHJlYW09Zm9w ZW4odml0bXAsInciKTsKKwkJCQlsID0gYi0+Y29tbWFuZHM7CisJCQkJd2hp bGUobCkJeworCQkJCQlmc2l6ZT0wOworCQkJCQlmc2l6ZSs9ZndyaXRlKGwt PmxpbmUsMSxzdHJsZW4obC0+bGluZSksdG1wc3RyZWFtKTsKKwkJCQkJZnNp emUrPWZ3cml0ZSgiXG4iLDEsc3RybGVuKCJcbiIpLHRtcHN0cmVhbSk7CisJ CQkJCWlmIChmc2l6ZTxzdHJsZW4obC0+bGluZSkrMSkgeworCQkJCQkJZmNs b3NlKHRtcHN0cmVhbSk7CisJCQkJCQl1bmxpbmsodml0bXApOworCQkJCQkJ cmV0dXJuOworCQkJCQkJfTsKKwkJCQkJbCA9IGwtPm5leHQ7CisJCQkJCX0K KwkJCQlmY2xvc2UodG1wc3RyZWFtKTsKKwkJCQl9CisJCQkvKiBFZGl0IHRo ZSBmaWxlICovCisJCQlpZiAoKGVkaXRvciA9IChjaGFyICopIGdldGVudiAo IkVESVRPUiIpKSA9PSBOVUxMKQorCQkJCWVkaXRvciA9ICIvYmluL2V4IjsK KwkJCXNucHJpbnRmKGNtZGxpbmUsc2l6ZW9mKGNtZGxpbmUpLCIlcyBcIiVz XCIiLGVkaXRvcix2aXRtcCk7CisJCQlpZiAoc3lzdGVtKGNtZGxpbmUpPDAp IHJldHVybjsKKyAgICAJCQl9CisJfQogCiAgIGlmIChwICYmICpwKQogICAg IGVycm9yIChfKCJVbmV4cGVjdGVkIGV4dHJhIGFyZ3VtZW50cyBmb2xsb3dp bmcgYnJlYWtwb2ludCBudW1iZXIuIikpOwpAQCAtNjA5LDE3ICs2NTAsMzEg QEAgY29tbWFuZHNfY29tbWFuZCAoY2hhciAqYXJnLCBpbnQgZnJvbV90dAog ICBBTExfQlJFQUtQT0lOVFMgKGIpCiAgICAgaWYgKGItPm51bWJlciA9PSBi bnVtKQogICAgICAgewotCWNoYXIgKnRtcGJ1ZiA9IHhzdHJwcmludGYgKCJU eXBlIGNvbW1hbmRzIGZvciB3aGVuIGJyZWFrcG9pbnQgJWQgaXMgaGl0LCBv bmUgcGVyIGxpbmUuIiwgCisJaWYodml0bXBbMF0pCXsKKwkJLyogcmVkaXJl Y3QgaW5zdHJlYW0gKi8KKwkJdG1wc3RyZWFtPWluc3RyZWFtOworCQlpbnN0 cmVhbT1mb3Blbih2aXRtcCwiciIpOworCQlsID0gcmVhZF9jb21tYW5kX2xp bmVzIChOVUxMLCBmcm9tX3R0eSwgMSk7CisJCX0KKwllbHNlCXsKKwkJY2hh ciAqdG1wYnVmID0geHN0cnByaW50ZiAoIlR5cGUgY29tbWFuZHMgZm9yIHdo ZW4gYnJlYWtwb2ludCAlZCBpcyBoaXQsIG9uZSBwZXIgbGluZS4iLCAKIAkJ CQkgYm51bSk7Ci0Jc3RydWN0IGNsZWFudXAgKmNsZWFudXBzID0gbWFrZV9j bGVhbnVwICh4ZnJlZSwgdG1wYnVmKTsKLQlsID0gcmVhZF9jb21tYW5kX2xp bmVzICh0bXBidWYsIGZyb21fdHR5LCAxKTsKLQlkb19jbGVhbnVwcyAoY2xl YW51cHMpOworCQlzdHJ1Y3QgY2xlYW51cCAqY2xlYW51cHMgPSBtYWtlX2Ns ZWFudXAgKHhmcmVlLCB0bXBidWYpOworCQlsID0gcmVhZF9jb21tYW5kX2xp bmVzICh0bXBidWYsIGZyb21fdHR5LCAxKTsKKwkJZG9fY2xlYW51cHMgKGNs ZWFudXBzKTsKKwkJfQogCWZyZWVfY29tbWFuZF9saW5lcyAoJmItPmNvbW1h bmRzKTsKIAliLT5jb21tYW5kcyA9IGw7CiAJYnJlYWtwb2ludHNfY2hhbmdl ZCAoKTsKIAlvYnNlcnZlcl9ub3RpZnlfYnJlYWtwb2ludF9tb2RpZmllZCAo Yi0+bnVtYmVyKTsKKwlpZih2aXRtcFswXSkJeworCQkvKiByZXN0b3JlIGlu c3RyZWFtICovCisJCWluc3RyZWFtPXRtcHN0cmVhbTsKKwkJLyogZXJhc2Ug dGVtcG9yYWwgZmlsZSAqLworCQl1bmxpbmsodml0bXApOworCQl9CiAJcmV0 dXJuOwotICAgIH0KKyAgICAgICB9CiAgIGVycm9yIChfKCJObyBicmVha3Bv aW50IG51bWJlciAlZC4iKSwgYm51bSk7CiB9CiAKQEAgLTgxMDMsNiArODE1 OCw5IEBAIFVzYWdlIGlzIGBpZ25vcmUgTiBDT1VOVCcuIikpOwogICBhZGRf Y29tICgiY29tbWFuZHMiLCBjbGFzc19icmVha3BvaW50LCBjb21tYW5kc19j b21tYW5kLCBfKCJcCiBTZXQgY29tbWFuZHMgdG8gYmUgZXhlY3V0ZWQgd2hl biBhIGJyZWFrcG9pbnQgaXMgaGl0LlxuXAogR2l2ZSBicmVha3BvaW50IG51 bWJlciBhcyBhcmd1bWVudCBhZnRlciBcImNvbW1hbmRzXCIuXG5cCitBZnRl ciB0aGUgY29tbWFuZCBudW1iZXIgeW91IGNhbiBlbnRlciB0aGUgYGVkaXQn IGtleXdvcmQsIGFuZCB0aGVuIHlvdSBjYW4gXG5cCit1c2UgdGhlIGV4dGVy bmFsIGVkaXRvciB0byBhZGQgb3IgbW9kaWZ5IGNvbW1hbmRzLlxuXAorVXNl cyBFRElUT1IgZW52aXJvbm1lbnQgdmFyaWFibGUgY29udGVudHMgYXMgZWRp dG9yIChvciBleCBhcyBkZWZhdWx0KS5cblwKIFdpdGggbm8gYXJndW1lbnQs IHRoZSB0YXJnZXRlZCBicmVha3BvaW50IGlzIHRoZSBsYXN0IG9uZSBzZXQu XG5cCiBUaGUgY29tbWFuZHMgdGhlbXNlbHZlcyBmb2xsb3cgc3RhcnRpbmcg b24gdGhlIG5leHQgbGluZS5cblwKIFR5cGUgYSBsaW5lIGNvbnRhaW5pbmcg XCJlbmRcIiB0byBpbmRpY2F0ZSB0aGUgZW5kIG9mIHRoZW0uXG5cCmRpZmYg LXVwciBPTEQvZ2RiL2RvYy9nZGIudGV4aW5mbyBORVcvZ2RiL2RvYy9nZGIu dGV4aW5mbwotLS0gT0xEL2dkYi9kb2MvZ2RiLnRleGluZm8JMjAwOS0wMS0x NCAxNzo0NjoxOC4wMDAwMDAwMDAgLTAyMDAKKysrIE5FVy9nZGIvZG9jL2dk Yi50ZXhpbmZvCTIwMDktMDEtMTYgMDM6NTQ6MzcuMDAwMDAwMDAwIC0wMjAw CkBAIC0zOTc2LDYgKzM5NzYsOCBAQCBmb2xsb3cgaXQgaW1tZWRpYXRlbHkg d2l0aCBAY29kZXtlbmR9OyB0CiBXaXRoIG5vIEB2YXJ7Ym51bX0gYXJndW1l bnQsIEBjb2Rle2NvbW1hbmRzfSByZWZlcnMgdG8gdGhlIGxhc3QKIGJyZWFr cG9pbnQsIHdhdGNocG9pbnQsIG9yIGNhdGNocG9pbnQgc2V0IChub3QgdG8g dGhlIGJyZWFrcG9pbnQgbW9zdAogcmVjZW50bHkgZW5jb3VudGVyZWQpLgor QGl0ZW0gY29tbWFuZHMgQHJ7W31AdmFye2JudW19QHJ7XX0gZWRpdAorVGhp cyBzcGF3bnMgYW4gZXh0ZXJuYWwgZWRpdG9yIGZvciBhZGRpbmcgb3IgZWRp dGluZyBjb21tYW5kcy4gIFRoZSBmaW5hbCAgQGNvZGV7ZW5kfSBpcyBub3Qg bmVjZXNzYXJ5IGluIHRoaXMgY2FzZS4gIEB4cmVme0Nob29zaW5nIHlvdXIg RWRpdG9yfS4KIEBlbmQgdGFibGUKIAogUHJlc3NpbmcgQGtleXtSRVR9IGFz IGEgbWVhbnMgb2YgcmVwZWF0aW5nIHRoZSBsYXN0IEB2YWx1ZXtHREJOfSBj b21tYW5kIGlzCkBAIC01Mzg0LDYgKzUzODYsNyBAQCBwcmVmZXIgdG8gdXNl IEVtYWNzIGZhY2lsaXRpZXMgdG8gdmlldyBzCiAqIExpc3Q6OiAgICAgICAg ICAgICAgICAgICAgICAgIFByaW50aW5nIHNvdXJjZSBsaW5lcwogKiBTcGVj aWZ5IExvY2F0aW9uOjogICAgICAgICAgICBIb3cgdG8gc3BlY2lmeSBjb2Rl IGxvY2F0aW9ucwogKiBFZGl0OjogICAgICAgICAgICAgICAgICAgICAgICBF ZGl0aW5nIHNvdXJjZSBmaWxlcworKiBDaG9vc2luZyB5b3VyIEVkaXRvcjo6 ICAgICAgICBTcGVjaWZ5aW5nIHlvdXIgdGV4dCBlZGl0b3IKICogU2VhcmNo OjogICAgICAgICAgICAgICAgICAgICAgU2VhcmNoaW5nIHNvdXJjZSBmaWxl cwogKiBTb3VyY2UgUGF0aDo6ICAgICAgICAgICAgICAgICBTcGVjaWZ5aW5n IHNvdXJjZSBkaXJlY3RvcmllcwogKiBNYWNoaW5lIENvZGU6OiAgICAgICAg ICAgICAgICBTb3VyY2UgYW5kIG1hY2hpbmUgY29kZQpAQCAtNTU4Nyw2ICs1 NTkwLDcgQEAgRWRpdCB0aGUgZmlsZSBjb250YWluaW5nIEB2YXJ7ZnVuY3Rp b259IAogCiBAZW5kIHRhYmxlCiAKK0Bub2RlIENob29zaW5nIHlvdXIgRWRp dG9yCiBAc3Vic2VjdGlvbiBDaG9vc2luZyB5b3VyIEVkaXRvcgogWW91IGNh biBjdXN0b21pemUgQHZhbHVle0dEQk59IHRvIHVzZSBhbnkgZWRpdG9yIHlv dSB3YW50CiBAZm9vdG5vdGV7CmRpZmYgLXVwciBPTEQvZ2RiL2RvYy9yZWZj YXJkLnRleCBORVcvZ2RiL2RvYy9yZWZjYXJkLnRleAotLS0gT0xEL2dkYi9k b2MvcmVmY2FyZC50ZXgJMjAwOS0wMS0xNCAxNzo0NjoxOC4wMDAwMDAwMDAg LTAyMDAKKysrIE5FVy9nZGIvZG9jL3JlZmNhcmQudGV4CTIwMDktMDEtMTYg MDM6NTQ6NDQuMDAwMDAwMDAwIC0wMjAwCkBAIC0zNTUsMTAgKzM1NSw5IEBA IGRlbGV0ZSB3aGVuIHJlYWNoZWQKIGlnbm9yZSB7XGl0IG59IHtcaXQgY291 bnR9Jmlnbm9yZSBicmVha3BvaW50IHtcaXQgbn0sIHtcaXQgY291bnR9CiB0 aW1lc1xjcgogXGNyCi1jb21tYW5kcyB7XGl0IG59XHBhcgorY29tbWFuZHMg e1xpdCBufSBcb3B0e3tcaXQgZWRpdH19IFxwYXIKIFxxcXVhZCBcb3B0e1x0 dCBzaWxlbnR9XHBhcgotXHFxdWFkIHtcaXQgY29tbWFuZC1saXN0fSZleGVj dXRlIEdEQiB7XGl0IGNvbW1hbmQtbGlzdH0gZXZlcnkgdGltZSBicmVha3Bv aW50IHtcaXQgbn0gaXMgcmVhY2hlZC4gXG9wdHt7XHR0IHNpbGVudH0gc3Vw cHJlc3NlcyBkZWZhdWx0Ci1kaXNwbGF5fVxjcgorXHFxdWFkIHtcaXQgY29t bWFuZC1saXN0fSZleGVjdXRlIEdEQiB7XGl0IGNvbW1hbmQtbGlzdH0gZXZl cnkgdGltZSBicmVha3BvaW50IHtcaXQgbn0gaXMgcmVhY2hlZCAgXG9wdHt7 XHR0IGVkaXR9IHVzaW5nIGV4dGVybmFsIGVkaXRvcn0uIFxvcHR7e1x0dCBz aWxlbnR9IHN1cHByZXNzZXMgZGVmYXVsdCBkaXNwbGF5fSBcY3IKIGVuZCZl bmQgb2Yge1xpdCBjb21tYW5kLWxpc3R9XGNyCiBcZW5kc2VjCiAK --0016e645b7687ef1c0046094a948--