From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24298 invoked by alias); 15 Jan 2009 01:55:04 -0000 Received: (qmail 24142 invoked by uid 22791); 15 Jan 2009 01:55:03 -0000 X-SWARE-Spam-Status: No, hits=-0.8 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33,J_CHICKENPOX_37,J_CHICKENPOX_65,J_CHICKENPOX_74,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.241) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 15 Jan 2009 01:54:27 +0000 Received: by an-out-0708.google.com with SMTP id b38so391545ana.3 for ; Wed, 14 Jan 2009 17:54:24 -0800 (PST) MIME-Version: 1.0 Received: by 10.100.140.20 with SMTP id n20mr752674and.135.1231984464826; Wed, 14 Jan 2009 17:54:24 -0800 (PST) In-Reply-To: References: Date: Thu, 15 Jan 2009 01:55:00 -0000 Message-ID: Subject: Re: Use external editor in 'commands' command From: Alfredo Ortega To: Eli Zaretskii Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016e640985a6512aa04607bbc85 X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00340.txt.bz2 --0016e640985a6512aa04607bbc85 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 756 2009/1/14 Eli Zaretskii > > > Date: Wed, 14 Jan 2009 19:47:50 -0200 > > From: Alfredo Ortega > > > > I have made a small patch to the 'commands' command to allow the use > > of an external editor to add or modify commands. This is convenient if > > you are dealing with many commands per breakpoint. > > The editor follows the behavior of the 'edit' command (/bin/ex by > > default, or the 'EDITOR' environment variable) > > > > Tested on i686-pc-linux-gnu, please tell me what do you think about it. > > If this is accepted, we will need a suitable patch for the manual. I see. This updated patch contains my proposed documentation changes to gdb.texinfo and refcard.tex. I hope that the patch format is adequate --0016e640985a6512aa04607bbc85 Content-Type: text/x-diff; charset=US-ASCII; name="commands.diff" Content-Disposition: attachment; filename="commands.diff" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fpyrqd4t0 Content-length: 7300 ZGlmZiAtdXByIE9MRC9nZGIvYnJlYWtwb2ludC5jIE5FVy9nZGIvYnJlYWtw b2ludC5jCi0tLSBPTEQvZ2RiL2JyZWFrcG9pbnQuYwkyMDA5LTAxLTE0IDE3 OjQ2OjI2LjAwMDAwMDAwMCAtMDIwMAorKysgTkVXL2dkYi9icmVha3BvaW50 LmMJMjAwOS0wMS0xNCAxOTozMjo0MC4wMDAwMDAwMDAgLTAyMDAKQEAgLTU4 NSwxNCArNTg1LDIwIEBAIGNvbmRpdGlvbl9jb21tYW5kIChjaGFyICphcmcs IGludCBmcm9tX3QKICAgZXJyb3IgKF8oIk5vIGJyZWFrcG9pbnQgbnVtYmVy ICVkLiIpLCBibnVtKTsKIH0KIAorI2RlZmluZSBDT01NQU5EU19FRENPTU1B TkQgImVkaXQiCisKIHN0YXRpYyB2b2lkCiBjb21tYW5kc19jb21tYW5kIChj aGFyICphcmcsIGludCBmcm9tX3R0eSkKIHsKICAgc3RydWN0IGJyZWFrcG9p bnQgKmI7CiAgIGNoYXIgKnA7Ci0gIGludCBibnVtOworICBpbnQgYm51bSxm c2l6ZTsKICAgc3RydWN0IGNvbW1hbmRfbGluZSAqbDsKLQorICBjaGFyIHZp dG1wWzUwXTsKKyAgY2hhciBjbWRsaW5lWzEwMF07CisgIEZJTEUgKnRtcHN0 cmVhbT1OVUxMOworICBjaGFyICplZGl0b3I7CisgIAogICAvKiBJZiB3ZSBh bGxvd2VkIHRoaXMsIHdlIHdvdWxkIGhhdmUgcHJvYmxlbXMgd2l0aCB3aGVu IHRvCiAgICAgIGZyZWUgdGhlIHN0b3JhZ2UsIGlmIHdlIGNoYW5nZSB0aGUg Y29tbWFuZHMgY3VycmVudGx5CiAgICAgIGJlaW5nIHJlYWQgZnJvbS4gICov CkBAIC02MDIsNiArNjA4LDQxIEBAIGNvbW1hbmRzX2NvbW1hbmQgKGNoYXIg KmFyZywgaW50IGZyb21fdHQKIAogICBwID0gYXJnOwogICBibnVtID0gZ2V0 X251bWJlciAoJnApOworICB2aXRtcFswXT0wOworICAvKiBFZGl0IGNvbW1h bmRzIHdpdGggZXh0ZXJuYWwgZWRpdG9yICovCisgIGlmICghc3RyY21wKENP TU1BTkRTX0VEQ09NTUFORCxwKSkJeworCS8qIEdlbmVyYXRlcyB0aGUgdGVt cG9yYWwgZmlsZSBuYW1lKi8KKwkvKiB2aXRtcCA9IHRlbXBuYW0oTlVMTCwi LmdkYiIpOyB0aGlzIGlzIG1vcmUgc2VjdXJlIGFjY29yZGluZyB0byBtYW4g bWtzdGVtcCwgYnV0IGdjYyBjb21wbGFpbnMuLi4gKi8KKwlwPU5VTEw7CisJ c3RyY3B5KHZpdG1wLCIvdG1wLy5nZGJYWFhYWFgiKTsKKwlpZiAobWtzdGVt cCh2aXRtcCk8MCkgcmV0dXJuOworCUFMTF9CUkVBS1BPSU5UUyAoYikKKwkJ aWYgKGItPm51bWJlciA9PSBibnVtKQorCQkJeworCQkJaWYgKCZiLT5jb21t YW5kcykJeworCQkJCS8qIGNvbW1hbmRzIGV4aXN0cywgbXVzdCBkdW1wIHRo ZW0gdG8gdGhlIHRlbXBvcmFsIGZpbGUgKi8KKwkJCQl0bXBzdHJlYW09Zm9w ZW4odml0bXAsInciKTsKKwkJCQlsID0gYi0+Y29tbWFuZHM7CisJCQkJd2hp bGUobCkJeworCQkJCQlmc2l6ZT0wOworCQkJCQlmc2l6ZSs9ZndyaXRlKGwt PmxpbmUsMSxzdHJsZW4obC0+bGluZSksdG1wc3RyZWFtKTsKKwkJCQkJZnNp emUrPWZ3cml0ZSgiXG4iLDEsc3RybGVuKCJcbiIpLHRtcHN0cmVhbSk7CisJ CQkJCWlmIChmc2l6ZTxzdHJsZW4obC0+bGluZSkrMSkgeworCQkJCQkJZmNs b3NlKHRtcHN0cmVhbSk7CisJCQkJCQl1bmxpbmsodml0bXApOworCQkJCQkJ cmV0dXJuOworCQkJCQkJfTsKKwkJCQkJbCA9IGwtPm5leHQ7CisJCQkJCX0K KwkJCQlmY2xvc2UodG1wc3RyZWFtKTsKKwkJCQl9CisJCQkvKiBFZGl0IHRo ZSBmaWxlICovCisJCQlpZiAoKGVkaXRvciA9IChjaGFyICopIGdldGVudiAo IkVESVRPUiIpKSA9PSBOVUxMKQorCQkJCWVkaXRvciA9ICIvYmluL2V4IjsK KwkJCXNucHJpbnRmKGNtZGxpbmUsc2l6ZW9mKGNtZGxpbmUpLCIlcyBcIiVz XCIiLGVkaXRvcix2aXRtcCk7CisJCQlpZiAoc3lzdGVtKGNtZGxpbmUpPDAp IHJldHVybjsKKyAgICAJCQl9CisJfQogCiAgIGlmIChwICYmICpwKQogICAg IGVycm9yIChfKCJVbmV4cGVjdGVkIGV4dHJhIGFyZ3VtZW50cyBmb2xsb3dp bmcgYnJlYWtwb2ludCBudW1iZXIuIikpOwpAQCAtNjA5LDE3ICs2NTAsMzEg QEAgY29tbWFuZHNfY29tbWFuZCAoY2hhciAqYXJnLCBpbnQgZnJvbV90dAog ICBBTExfQlJFQUtQT0lOVFMgKGIpCiAgICAgaWYgKGItPm51bWJlciA9PSBi bnVtKQogICAgICAgewotCWNoYXIgKnRtcGJ1ZiA9IHhzdHJwcmludGYgKCJU eXBlIGNvbW1hbmRzIGZvciB3aGVuIGJyZWFrcG9pbnQgJWQgaXMgaGl0LCBv bmUgcGVyIGxpbmUuIiwgCisJaWYodml0bXBbMF0pCXsKKwkJLyogcmVkaXJl Y3QgaW5zdHJlYW0gKi8KKwkJdG1wc3RyZWFtPWluc3RyZWFtOworCQlpbnN0 cmVhbT1mb3Blbih2aXRtcCwiciIpOworCQlsID0gcmVhZF9jb21tYW5kX2xp bmVzIChOVUxMLCBmcm9tX3R0eSwgMSk7CisJCX0KKwllbHNlCXsKKwkJY2hh ciAqdG1wYnVmID0geHN0cnByaW50ZiAoIlR5cGUgY29tbWFuZHMgZm9yIHdo ZW4gYnJlYWtwb2ludCAlZCBpcyBoaXQsIG9uZSBwZXIgbGluZS4iLCAKIAkJ CQkgYm51bSk7Ci0Jc3RydWN0IGNsZWFudXAgKmNsZWFudXBzID0gbWFrZV9j bGVhbnVwICh4ZnJlZSwgdG1wYnVmKTsKLQlsID0gcmVhZF9jb21tYW5kX2xp bmVzICh0bXBidWYsIGZyb21fdHR5LCAxKTsKLQlkb19jbGVhbnVwcyAoY2xl YW51cHMpOworCQlzdHJ1Y3QgY2xlYW51cCAqY2xlYW51cHMgPSBtYWtlX2Ns ZWFudXAgKHhmcmVlLCB0bXBidWYpOworCQlsID0gcmVhZF9jb21tYW5kX2xp bmVzICh0bXBidWYsIGZyb21fdHR5LCAxKTsKKwkJZG9fY2xlYW51cHMgKGNs ZWFudXBzKTsKKwkJfQogCWZyZWVfY29tbWFuZF9saW5lcyAoJmItPmNvbW1h bmRzKTsKIAliLT5jb21tYW5kcyA9IGw7CiAJYnJlYWtwb2ludHNfY2hhbmdl ZCAoKTsKIAlvYnNlcnZlcl9ub3RpZnlfYnJlYWtwb2ludF9tb2RpZmllZCAo Yi0+bnVtYmVyKTsKKwlpZih2aXRtcFswXSkJeworCQkvKiByZXN0b3JlIGlu c3RyZWFtICovCisJCWluc3RyZWFtPXRtcHN0cmVhbTsKKwkJLyogZXJhc2Ug dGVtcG9yYWwgZmlsZSAqLworCQl1bmxpbmsodml0bXApOworCQl9CiAJcmV0 dXJuOwotICAgIH0KKyAgICAgICB9CiAgIGVycm9yIChfKCJObyBicmVha3Bv aW50IG51bWJlciAlZC4iKSwgYm51bSk7CiB9CiAKQEAgLTgxMDMsNiArODE1 OCw5IEBAIFVzYWdlIGlzIGBpZ25vcmUgTiBDT1VOVCcuIikpOwogICBhZGRf Y29tICgiY29tbWFuZHMiLCBjbGFzc19icmVha3BvaW50LCBjb21tYW5kc19j b21tYW5kLCBfKCJcCiBTZXQgY29tbWFuZHMgdG8gYmUgZXhlY3V0ZWQgd2hl biBhIGJyZWFrcG9pbnQgaXMgaGl0LlxuXAogR2l2ZSBicmVha3BvaW50IG51 bWJlciBhcyBhcmd1bWVudCBhZnRlciBcImNvbW1hbmRzXCIuXG5cCitBZnRl ciB0aGUgY29tbWFuZCBudW1iZXIgeW91IGNhbiBlbnRlciB0aGUgYGVkaXQn IGtleXdvcmQsIGFuZCB0aGVuIHlvdSBjYW4gXG5cCit1c2UgdGhlIGV4dGVy bmFsIGVkaXRvciB0byBhZGQgb3IgbW9kaWZ5IGNvbW1hbmRzLlxuXAorVXNl cyBFRElUT1IgZW52aXJvbm1lbnQgdmFyaWFibGUgY29udGVudHMgYXMgZWRp dG9yIChvciBleCBhcyBkZWZhdWx0KS5cblwKIFdpdGggbm8gYXJndW1lbnQs IHRoZSB0YXJnZXRlZCBicmVha3BvaW50IGlzIHRoZSBsYXN0IG9uZSBzZXQu XG5cCiBUaGUgY29tbWFuZHMgdGhlbXNlbHZlcyBmb2xsb3cgc3RhcnRpbmcg b24gdGhlIG5leHQgbGluZS5cblwKIFR5cGUgYSBsaW5lIGNvbnRhaW5pbmcg XCJlbmRcIiB0byBpbmRpY2F0ZSB0aGUgZW5kIG9mIHRoZW0uXG5cCmRpZmYg LXVwciBPTEQvZ2RiL2RvYy9nZGIudGV4aW5mbyBORVcvZ2RiL2RvYy9nZGIu dGV4aW5mbwotLS0gT0xEL2dkYi9kb2MvZ2RiLnRleGluZm8JMjAwOS0wMS0x NCAxNzo0NjoxOC4wMDAwMDAwMDAgLTAyMDAKKysrIE5FVy9nZGIvZG9jL2dk Yi50ZXhpbmZvCTIwMDktMDEtMTQgMjI6MjE6MjkuMDAwMDAwMDAwIC0wMjAw CkBAIC0zOTc2LDYgKzM5NzYsOCBAQCBmb2xsb3cgaXQgaW1tZWRpYXRlbHkg d2l0aCBAY29kZXtlbmR9OyB0CiBXaXRoIG5vIEB2YXJ7Ym51bX0gYXJndW1l bnQsIEBjb2Rle2NvbW1hbmRzfSByZWZlcnMgdG8gdGhlIGxhc3QKIGJyZWFr cG9pbnQsIHdhdGNocG9pbnQsIG9yIGNhdGNocG9pbnQgc2V0IChub3QgdG8g dGhlIGJyZWFrcG9pbnQgbW9zdAogcmVjZW50bHkgZW5jb3VudGVyZWQpLgor QGl0ZW0gY29tbWFuZHMgQHJ7W31AdmFye2JudW19QHJ7XX0gZWRpdAorVGhp cyBzcGF3bnMgYW4gZXh0ZXJuYWwgZWRpdG9yIGZvciBhZGRpbmcgb3IgZWRp dGluZyBjb21tYW5kcy4gdGhlIGZpbmFsICBAY29kZXtlbmR9IGlzIG5vdCBu ZWNlc3NhcnkgaW4gdGhpcyBjYXNlLiBAeHJlZntDaG9vc2luZyB5b3VyIEVk aXRvcn0uCiBAZW5kIHRhYmxlCiAKIFByZXNzaW5nIEBrZXl7UkVUfSBhcyBh IG1lYW5zIG9mIHJlcGVhdGluZyB0aGUgbGFzdCBAdmFsdWV7R0RCTn0gY29t bWFuZCBpcwpAQCAtNTU4Nyw2ICs1NTg5LDcgQEAgRWRpdCB0aGUgZmlsZSBj b250YWluaW5nIEB2YXJ7ZnVuY3Rpb259IAogCiBAZW5kIHRhYmxlCiAKK0Bu b2RlIENob29zaW5nIHlvdXIgRWRpdG9yCiBAc3Vic2VjdGlvbiBDaG9vc2lu ZyB5b3VyIEVkaXRvcgogWW91IGNhbiBjdXN0b21pemUgQHZhbHVle0dEQk59 IHRvIHVzZSBhbnkgZWRpdG9yIHlvdSB3YW50CiBAZm9vdG5vdGV7CmRpZmYg LXVwciBPTEQvZ2RiL2RvYy9yZWZjYXJkLnRleCBORVcvZ2RiL2RvYy9yZWZj YXJkLnRleAotLS0gT0xEL2dkYi9kb2MvcmVmY2FyZC50ZXgJMjAwOS0wMS0x NCAxNzo0NjoxOC4wMDAwMDAwMDAgLTAyMDAKKysrIE5FVy9nZGIvZG9jL3Jl ZmNhcmQudGV4CTIwMDktMDEtMTQgMjI6MjE6MzUuMDAwMDAwMDAwIC0wMjAw CkBAIC0zNTUsMTAgKzM1NSwxMCBAQCBkZWxldGUgd2hlbiByZWFjaGVkCiBp Z25vcmUge1xpdCBufSB7XGl0IGNvdW50fSZpZ25vcmUgYnJlYWtwb2ludCB7 XGl0IG59LCB7XGl0IGNvdW50fQogdGltZXNcY3IKIFxjcgotY29tbWFuZHMg e1xpdCBufVxwYXIKK2NvbW1hbmRzIHtcaXQgbn0gXG9wdHt7XGl0IGVkaXR9 fSBccGFyCiBccXF1YWQgXG9wdHtcdHQgc2lsZW50fVxwYXIKLVxxcXVhZCB7 XGl0IGNvbW1hbmQtbGlzdH0mZXhlY3V0ZSBHREIge1xpdCBjb21tYW5kLWxp c3R9IGV2ZXJ5IHRpbWUgYnJlYWtwb2ludCB7XGl0IG59IGlzIHJlYWNoZWQu IFxvcHR7e1x0dCBzaWxlbnR9IHN1cHByZXNzZXMgZGVmYXVsdAotZGlzcGxh eX1cY3IKK1xxcXVhZCB7XGl0IGNvbW1hbmQtbGlzdH0mZXhlY3V0ZSBHREIg e1xpdCBjb21tYW5kLWxpc3R9IGV2ZXJ5IHRpbWUgYnJlYWtwb2ludCB7XGl0 IG59IGlzIHJlYWNoZWQuIFxvcHR7e1x0dCBzaWxlbnR9IHN1cHByZXNzZXMg ZGVmYXVsdCBkaXNwbGF5fSAgXG9wdHt7XHR0IGVkaXR9IHVzZSBleHRlcm5h bCBlZGl0b3IgZm9yIGNvbW1hbmRzfQorXGNyCiBlbmQmZW5kIG9mIHtcaXQg Y29tbWFuZC1saXN0fVxjcgogXGVuZHNlYwogCg== --0016e640985a6512aa04607bbc85--