From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27035 invoked by alias); 6 Mar 2019 19:39:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27007 invoked by uid 89); 6 Mar 2019 19:39:52 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.2 required=5.0 tests=BAYES_00,DNS_FROM_AHBL_RHSBL,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,TIME_LIMIT_EXCEEDED,T_RP_MATCHES_RCVD autolearn=unavailable version=3.3.1 spammy=H*M:4e4f, our, H*UA:Macintosh X-HELO: mx2.freebsd.org Received: from mx2.freebsd.org (HELO mx2.freebsd.org) (8.8.178.116) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 06 Mar 2019 19:39:42 +0000 Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 76BBB888E8; Wed, 6 Mar 2019 19:39:40 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 731DA6D40E; Wed, 6 Mar 2019 19:39:39 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-3.local (ralph.baldwin.cx [66.234.199.215]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id F1DCE5D42; Wed, 6 Mar 2019 19:39:38 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Subject: Re: [PATCH v2 07/22] Remove last cleanups from solib-svr4.c To: Pedro Alves , Tom Tromey , gdb-patches@sourceware.org References: <20190227201849.32210-1-tom@tromey.com> <20190227201849.32210-8-tom@tromey.com> From: John Baldwin Openpgp: preference=signencrypt Message-ID: Date: Wed, 06 Mar 2019 19:39:00 -0000 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 731DA6D40E X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-2.96 / 15.00]; local_wl_from(0.00)[FreeBSD.org]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.96)[-0.957,0]; ASN(0.00)[asn:11403, ipnet:2610:1c1:1::/48, country:US] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00122.txt.bz2 On 3/6/19 11:32 AM, Pedro Alves wrote: > On 02/27/2019 08:18 PM, Tom Tromey wrote: >> This removes the last cleanups from solib-svr4.c, replacing them with >> uses of make_scope_exit. >> >> gdb/ChangeLog >> 2019-02-27 Tom Tromey >> >> * solib-svr4.c (svr4_parse_libraries, svr4_current_sos_direct): >> Use make_scope_exit. >> --- >> gdb/ChangeLog | 5 +++++ >> gdb/solib-svr4.c | 17 ++++++++++------- >> 2 files changed, 15 insertions(+), 7 deletions(-) >> >> diff --git a/gdb/solib-svr4.c b/gdb/solib-svr4.c >> index 2b370ef96d0..2301cf94c2f 100644 >> --- a/gdb/solib-svr4.c >> +++ b/gdb/solib-svr4.c >> @@ -1198,8 +1198,10 @@ static const struct gdb_xml_element svr4_library_list_elements[] = >> static int >> svr4_parse_libraries (const char *document, struct svr4_library_list *list) >> { >> - struct cleanup *back_to = make_cleanup (svr4_free_library_list, >> - &list->head); >> + auto cleanup = make_scope_exit ([&] () >> + { >> + svr4_free_library_list (&list->head); >> + }); >> > > When passing lambdas as last argument to a function, I think indenting > like this reads clearer: > > auto cleanup = make_scope_exit ([&] () > { > svr4_free_library_list (&list->head); > }); > > Makes it read more like an if/for scope block, and of course, > avoids aligning things too much to the right side. Examples of > this can be found throughout gdbserver, for example: > > for_each_thread ([] (thread_info *thread) > { > thread->status_pending_p = 0; > }); > > and, also, that's how you'd indent if you used SCOPE_EXIT instead: > > SCOPE_EXIT > { > svr4_free_library_list (&list->head); > } > > LLVM has a written rule for this: > > https://llvm.org/docs/CodingStandards.html#format-lambdas-like-blocks-of-code > > If others agree, I'd vote for having a similar rule of our own. I'd +1 that rule FWIW. -- John Baldwin