Re: [PATCH] dwarf2: Fix dwarf stack fetch array view size mismatch

[Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>]

On 2022-08-19 17:33, Denis Lukianov wrote:
> On Thu, 2022-08-18 at 12:27 -0400, Simon Marchi wrote:
>> On 8/8/22 07:24, Denis Lukianov wrote:
>>
>>
>> Your patch reminded me of a pending patch I had in the same area,
>> which
>> I just merged:
>>
>>  
>> https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=bde195b84a862f31ac111c0881ad13b89ee89492
>>
>> Maybe you were seeing the same problem as described there?
>>
>> Simon
> 
> Hi Simon,
> 
> Your check_typedef fixes my use case on little endian architectures.
> 
> However, note that DWARF_VALUE_STACK case also re-slices the source
> val. It looks like after that it remains mismatched to the destination
> which also must be re-sliced to match (as per my patch, or implicitly
> back when this was a simple memcpy with a single length). I have no big
> endian resource configured to test this.

I don't understand what you are saying.  All I can see is that the
source array_view size will be of the length of subobj_type: we call
slice with length == len, where len is `TYPE_LENGTH (subobj_type)`.  And
the destination array_view size is also of the length of subobj_type:
retval was allocated as `allocate_value (subobj_type)`, so its contents
are of the length of subobj_type.

Simon