Re: [PUSHED] gdb/testsuite: add missing skip_python_tests call in py-doc-reformat.exp

[Carl Love via Gdb-patches <gdb-patches@sourceware.org>]

Andrew:

Thanks for the fix!  

                  Carl 

On Mon, 2022-06-06 at 12:40 +0100, Andrew Burgess via Gdb-patches
wrote:
> Carl,
> 
> Thanks for bringing this to my attention.  Sorry for the slow reply,
> I've been away for a couple of days.
> 
> The problem was that I had missed a call to skip_python_tests in the
> new test script.  Recently, GDB was changed so that it will no longer
> build against Python 2, this means on machines without Python 3 there
> will be no Python support, the 'source' command used in the test will
> then fail.
> 
> The correct fix is to check that GDB has Python support at the top of
> the test script, which this commit does.
> 
> Thanks,
> Andrew
> 
> ---
> 
> In commit:
> 
>   commit 51e8dbe1fbe7d8955589703140ca5eba7b4f1bd7
>   Date:   Mon May 16 19:26:54 2022 +0100
> 
>       gdb/python: improve formatting of help text for user defined
> commands
> 
> the test that was added (gdb.python/py-doc-reformat.exp) was missing
> a
> call to skip_python_tests.  As a result, this test would fail for any
> GDB built within Python support.
> 
> This commit adds a call to skip_python_tests.
> ---
>  gdb/testsuite/gdb.python/py-doc-reformat.exp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/gdb/testsuite/gdb.python/py-doc-reformat.exp
> b/gdb/testsuite/gdb.python/py-doc-reformat.exp
> index aae3939bd07..f0cfa278557 100644
> --- a/gdb/testsuite/gdb.python/py-doc-reformat.exp
> +++ b/gdb/testsuite/gdb.python/py-doc-reformat.exp
> @@ -19,6 +19,10 @@
> 
>  load_lib gdb-python.exp
> 
> +# Check that Python is supported.
> +clean_restart
> +if { [skip_python_tests] } { continue }
> +
>  # A global counter used to number the tests.
>  set idx 0
>