From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 23noNahcz2oOFQgAWB0awg (envelope-from ) for ; Wed, 14 Oct 2026 06:42:48 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=IoVEYMve; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B5FA61E047; Wed, 14 Oct 2026 06:42:48 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 679B81E047 for ; Wed, 14 Oct 2026 06:42:47 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 793C14BA2E25 for ; Wed, 14 Oct 2026 10:42:45 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 793C14BA2E25 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=IoVEYMve Received: from PH0PR06CU001.outbound.protection.outlook.com (mail-westus3azlp170110003.outbound.protection.outlook.com [IPv6:2a01:111:f403:c107::3]) by sourceware.org (Postfix) with ESMTPS id 9A3824BA2E25 for ; Wed, 14 Oct 2026 10:42:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9A3824BA2E25 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=amd.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9A3824BA2E25 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c107::3 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1791974536; cv=pass; b=AjFJCTG1TQyv8tmlX1L3zRt4jTR39JMpuNyo+Cf4XakZcJhjHkJd+l38Hypky/6XOCkHiyHbCopanCTGbQ6EOpmA7BBu+Do0on/2TTJZaGsIzZvwn7nXhSJYhMJbkPp2kCrulamKJsv39jnjSVBy0BiC8++Xdg0HaDNigTlolvU= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1791974536; c=relaxed/simple; bh=cA/hjXJOr4mAX/Ap1UJnKtlzLHUrkoE/xhfFMLsolrc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=Fsw5cn+cVb1W5PzgqXQFZfwD5sqaEOQSbkdv7+aM3KOwinatJ4j6IV/17pyU4Xv5v/OsaAMg+qZ14mW4BZ3kmrc+oLpud1XXRF4etzfdRhLtt0naTqoq4D2QhijDgZKq6+G7G0iA0VouqY+zHRgjzR4g3SZ6xMRnEDpUrtxcRKs= ARC-Authentication-Results: i=2; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=amd.com header.i=@amd.com header.a=rsa-sha256 header.s=selector1 header.b=IoVEYMve DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9A3824BA2E25 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=yhQTAuzNBmI7xs81GCj7/lgaJ0G69082pSgP5D1dU3WMr5a8R50ZXD5E9d4EItggisfV/ok4VnSkGNzluFF8tHMjoSXCtSUo8QXcViiWQBYFHXyKNnzqif1qf7y0KqlTR3vYPb+WB8SYOqWmLtQIEpYOiAkXQw2BbmTzHbpeUoxk2Lu8N6o5XifAWU7/eGWyo2Zqxb3i3GrSbTc/fmlui2dak8cguvSLSiYj6TXgTVxN/IS9IPaVA+mf6OVYSUSUIO2dglo2sX01RBgrnRuz2hoOkSi/8vf2TM59UhLA7jA9KsxyVW986/wOEhS0CmtgCs6A7444hgDGewTItWmejA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/SxsMJ5AZCj7Lcp4mBlolBO8v6QsinpqetmCmYcDTok=; b=jleeRcZ84+Hc5oHrcIQlFEIEfCqxrea2eMpgiZkNqNp2LsDAn+TGcEhQbaLucHmSge/FvgG1La+WqBZrwC4MmVtEk+0dNMekFO2viSSDcHM+w0snyp4e5Gl7yb5FkwRM1MtZ4WU8eACBC1uQr+WnR9HF269B+/Hj3ALeSek1PwiBSkQUzW4rYnNI3hTbhkx0xkaKVZASkzWH+ANVUBSdg9ESFz+uJtou+QNgB26XZpJZyARxAASILjvGDo8r/jhecfP0JE8iFgaJ8kF8h54859WgRuuCwN5uIKSodRuHyxi+zcc1GQ5MALzbcW/qbscU9p0aqN+jR658Cq3cyX+ozw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/SxsMJ5AZCj7Lcp4mBlolBO8v6QsinpqetmCmYcDTok=; b=IoVEYMve3hOeKsf5K86sQ1bIBTDU9dm9fD0KLZdcnYHeadtQhsB9RxWCJzot6+TyaxzGZyrZYbQ5JF7wQIHpMBC2fxC6Q9+fP5Ycsh7Xg1ChAwgZQ1e7X55WjxdL5/ZQXmIxpCwCzptR52qxsKLdATdQzvOdtRwNNTcFEIXEIaE= Authentication-Results: mx.microsoft.com 1; dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from PH0PR12MB5607.namprd12.prod.outlook.com (2603:10b6:510:142::22) by SA3PR12MB179908.namprd12.prod.outlook.com (2603:10b6:806:514::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.522.12; Wed, 14 Oct 2026 10:42:12 +0000 Received: from PH0PR12MB5607.namprd12.prod.outlook.com ([fe80::26e0:df91:f91:c41]) by PH0PR12MB5607.namprd12.prod.outlook.com ([fe80::26e0:df91:f91:c41%4]) with mapi id 15.21.0522.012; Wed, 14 Oct 2026 10:42:12 +0000 Message-ID: Date: Wed, 14 Oct 2026 11:42:08 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb, amdgpu: handle UNAVAILABLE error when accessing memory To: Tankut Baris Aktemur , gdb-patches@sourceware.org References: <20261014090838.1211026-1-tankutbaris.aktemur@amd.com> Content-Language: en-US From: Lancelot SIX In-Reply-To: <20261014090838.1211026-1-tankutbaris.aktemur@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR4P281CA0236.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:e9::10) To PH0PR12MB5607.namprd12.prod.outlook.com (2603:10b6:510:142::22) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR12MB5607:EE_|SA3PR12MB179908:EE_ X-MS-Office365-Filtering-Correlation-Id: 249d9bf8-041a-49fa-a645-08df29dfcdd4 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|23010399003|376014|11063799006|56012099006|261009223027099003|18002099003|10067099003|22082099003; X-Microsoft-Antispam-Message-Info: btwCfsCCsawxFy6X0UpXin8VO/Q2HuhKmtl2dR+v+aMQzoc1/q7il8/w1RyqwFxlGdZB7unBVaXMOgzs27eeexOhJeWjsI6ufuiTCsE2QJO1D5k6SeioROi56ugXlOXQbYSaslZgX9QR7h7J8DXuU4HFpHt6PHt972Li7Ea3bkuoOH1Ubc8igThUujekVOZ8Tig2xnAM2G4TG3yhJTDyJnF3vAdf0+VPq0JHf6L/f0U0ngDkpSNP8+upj0MnQlq2mDhfTu5PWTlBDpczm1eUSFvE/hsTYxPsXK6vb2TSi+zlfpGSkcnhWOUnrGodlxlXAHycPVwg94RYlYT/ry51yBoVDlk3EJnp9FpXhhVav66YdkBIAYNXBEzblaY9AytQF+r5zebMSpYVmQ54k5mLqnbh98jRmySvc/6wa0faiodMyDwBIpcK4DNXJzE4Ui0ekiVPbB6tbrzrCI+HX6Kn7ReEM8LDyJcT6aFYIyj8c3REPqFjVj7LgPkoK7c8Zf7V1iUzc2GDgDbo5I9dIMoAZczmeA9D955p445m7OlpynNZrCuF0+8vJ0F8hlJRcf5GdNEz82KENJ4f2TyqoxaeCPPxF2odCDcHbenypt5711K3PG0cVzy5zKPinWSz5Jsow5PS+fQt96Vo+UGn2tfZlnZrt7BKTI4dy/4QavFHkus= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR12MB5607.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(23010399003)(376014)(11063799006)(56012099006)(261009223027099003)(18002099003)(10067099003)(22082099003); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QlNqVVNNbnpvVmwreVdSZFh1bnU5TjRkN1ZhdXpEL2VHTjljc1k4dklEam5H?= =?utf-8?B?d2haTHYxVDFJQzNuMXhqN0hjeHBZMHdGdWd2cTZ5TzdnR2RRb0U1ZU03Lzd4?= =?utf-8?B?WjRDaUhVSWFSZnE4TEwwYWNxbER3TVkxclNVL1VnTE05akNrZVJQVGU4YUVL?= =?utf-8?B?dGYrZGM2RjdPUjJCNG9Ba3FDY2NNcUw0bVY3YlJLa3B6dkFOYVFveXFITXRB?= =?utf-8?B?MTU0QWpwUjkvQXhkbldLbXpHNGMxdHhOVEppQzJnUGxsOGpMUTJGUTZHZExI?= =?utf-8?B?S0RDU0taV1FKeEtIYkhZV0RmUDFYc1FVOVRjVGJsOTVOM3JBVCtMeHVaRkFk?= =?utf-8?B?QUFSS3hRMnl4ems4dVU0RnI1R1djaW9PSHBVUGRMSUM1Y2pab3Y0czIybDNC?= =?utf-8?B?VTFhWEx3d2F4RjFWbnhkanQ2NGRZTEdQSXVwZDhIekhLRDEyV1RLcGFLTXJP?= =?utf-8?B?NTZZWHVoTjc2OXRLdk4xbWtYdndndkJEdjlhM0VlM0QrcjZpaEFtcy9sMXlj?= =?utf-8?B?VlViZG9PUCs5UE5mNGE2WUp4M0phRTBBQ0RubFRSV0M1OEdjd2dVQzUramVO?= =?utf-8?B?UGdIeUx2RXpob2VnTmZoejAzQ1VycVpnNG1pK2xKT2cvYklacHBtZzFtOU5C?= =?utf-8?B?QjQ0ZHVWUnVKUFBTSmtqSjBXUENMVFhSZUJEdHBycm5oU2t2QklUNFBBM0Vo?= =?utf-8?B?Z045eEJDR211TUgvU1JWRGVKY2lPV0RDSUpYY0hBUS9BelBubUhuUnIzbFpy?= =?utf-8?B?NklyaDRhTW0ydFlQTGdkWlkxYlByZWliYzhFRDRLNnJxOWUvbjc1U0VLUjhu?= =?utf-8?B?ei94U3ZqTFgvQ2xFR0QrVVc2TEs4b01Sbm8yMG5hN0M1Kyt0M2VzTTZldlJO?= =?utf-8?B?NnMwQ3NnUDY5c01OWUwzVDZSSStZY3QzbEgvVUZPU25NZUc3WlRHN0FSdi9r?= =?utf-8?B?NjVIOUdXay95alRZU1liRERxeVF2VmxmbTduQkQxY0JMSFl0UGU3MmprQllk?= =?utf-8?B?OXNRQ3dPbE9QSzFRSUpkSUVZekQxZXhBNWZkU29ka0tzQlNsUGpSdTNxT1c4?= =?utf-8?B?QTM4TUY0dnNsenhqTzNPZlppV0d5dGh2aUlZaDR4bEx3cDMzazFvVys4L0Vm?= =?utf-8?B?WFJZL1gwVU9xL1I4Zkg1c2VNeitzemF3VXNYTmNpbmFSK0dyVnpwU2VTejMr?= =?utf-8?B?aHVNTkRCeEVGdjBQK2xxWG4zZHhMSkhjdE1NbC94d1dhWW1qOTBGUjRKckxm?= =?utf-8?B?TU50Qm9NenR3cEtSTkorb1JaUFlvb0wrOHhYR2c4UGRFRStLeEtaZTZsdmpN?= =?utf-8?B?UTVuSDlOYUJnbUdsOVpMeEhETHJWc3Rnd0J1bnVBMzJ4dURFdWUzT3RldTZu?= =?utf-8?B?WnYwVVBXK05lakg2dFpWQXpEMSswL0plZHZxSC94WitSOHFHTnRTNmZ6QW96?= =?utf-8?B?Y0srd2JKUjJqZ3pwZXB6bmRHS2doZXRHZnNCVGhtNFpnL2QwaExzUWVKQmRx?= =?utf-8?B?Q2VyeFY0OWJFU0tjRHozd3lNdjE3ZXl2RUs2TDhmYzF3R0NRdXBWZ2IyaTZR?= =?utf-8?B?cHI5UmlsbmRKaG5nditTeE5ra2N4alIxOW9EdXZhenB2SVJrOUVGRmNEVmN1?= =?utf-8?B?OEdVRDRIV2J0OE5VKzdiN2tmWmVFOUFNMXJuMlVZenJPM2dwQUNTSnZwT2U5?= =?utf-8?B?ajJsSDRwVXVWeW1rYXpZcGl5aTk2WWh4alYrN3FwME5xc3RqcDMxa0hkU0Uv?= =?utf-8?B?cm5MWmtIZ3d2MlRQcjUxN2s0QXdWdTFsSVZ4dHh6S3hpUVphZXAvMnlNZUdk?= =?utf-8?B?Uzg3aktTVWI4QW9vTy9Vb3pkcURHeUhPdC9BZlJXcjRZQUtaaWMwUVdQNHJS?= =?utf-8?B?ckFlYnhCLy9FQXBEN3luSWFmcUVHOHdiOVF3RkxSN3VVYUIyYWNIQXdSRUxt?= =?utf-8?B?R2w3Mk5xeGplcm56YVFyMnZFcHIvYzVhS3lPLy9EdXRVNlUzNzRrTjhOMTAy?= =?utf-8?B?QzhqYzBJTC9mOElJRXZlazZpeHQ2ZjRKWDNaL3ExQ0FEOW1YbXl0K0RjTEIr?= =?utf-8?B?MUpnbXlzREY1YkNTWGFQZ2JSUFBYems2T1Z2NnR0bjBjelpVV3Z4Nm96RXla?= =?utf-8?B?T1lnc3E4ZnNSZ0doTmM2T1BXemt6aWdHVncwbXpCMTFjNUVJY2RzMEdCSzQ1?= =?utf-8?B?cCs2RlpnaE43T3lEN255Q3dDR0FjZkNVbFFDR0dTWENCeTdtWEtNOXMrSnp3?= =?utf-8?B?cW5VMkZ0SjlKdThjZ2VCZ0xYRXZoekZReHV4a2tBRUJNU0RjSE5kc2FYa25S?= =?utf-8?Q?g8wk0XaCmebYOzwfBn?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 249d9bf8-041a-49fa-a645-08df29dfcdd4 X-MS-Exchange-CrossTenant-AuthSource: PH0PR12MB5607.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2026 10:42:11.9312 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: L7MpqusWhlUKNxJqIrjxgzQMmt2i3dsHFaQo2D7Cbnlz/e3FG1IrHDxmjUhBzH9uOUPibGsP7IAHPqi+rR7BrA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR12MB179908 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 14/10/2026 10:08, Tankut Baris Aktemur wrote: > In amd_dbgapi_target, accessing memory through dbgapi may fail with > AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE. Convert this error to > GDB's TARGET_XFER_UNAVAILABLE. Similarly, in the global memory access > callback function, if the access result is TARGET_XFER_UNAVAILABLE, pass > the result back to dbgapi as AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE. > > These conversions in both ways are useful to display to the user an > "" result instead of "Cannot access memory...". This may > happen in lightweight corefiles, where some chunk of memory may not > have been captured. > > Note that if xfer_partial target op replies with TARGET_XFER_UNAVAILABLE, > GDB expects xfered_len to be greater than zero. > > Regression-tested in gfx1201. Hi, This looks good to me, thanks. Approved-by: Lancelot Six (amdgpu) Best, Lancelot. > --- > gdb/amd-dbgapi-target.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/gdb/amd-dbgapi-target.c b/gdb/amd-dbgapi-target.c > index 93207a8fdd2..2fd175de6f7 100644 > --- a/gdb/amd-dbgapi-target.c > +++ b/gdb/amd-dbgapi-target.c > @@ -786,6 +786,12 @@ amd_dbgapi_target::xfer_partial (enum target_object object, const char *annex, > AMD_DBGAPI_ADDRESS_SPACE_GLOBAL, > offset, &len, writebuf); > > + if (status == AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE) > + { > + *xfered_len = requested_len; > + return TARGET_XFER_UNAVAILABLE; > + } > + > if (status != AMD_DBGAPI_STATUS_SUCCESS) > return TARGET_XFER_E_IO; > > @@ -2570,6 +2576,8 @@ amd_dbgapi_xfer_global_memory_callback > > if (status == TARGET_XFER_EOF) > return AMD_DBGAPI_STATUS_ERROR_PROCESS_EXITED; > + else if (status == TARGET_XFER_UNAVAILABLE) > + return AMD_DBGAPI_STATUS_ERROR_MEMORY_UNAVAILABLE; > else if (status != TARGET_XFER_OK) > return AMD_DBGAPI_STATUS_ERROR_MEMORY_ACCESS; >