From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83894 invoked by alias); 20 Feb 2017 19:52:24 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 83883 invoked by uid 89); 20 Feb 2017 19:52:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=H*M:60c7 X-HELO: relay1.mentorg.com Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Feb 2017 19:52:20 +0000 Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203]) by relay1.mentorg.com with esmtp id 1cfu0R-0002OL-3U from Luis_Gustavo@mentor.com ; Mon, 20 Feb 2017 11:52:19 -0800 Received: from [172.30.11.42] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Mon, 20 Feb 2017 11:52:15 -0800 Reply-To: Luis Machado Subject: Re: [PATCH v3] [ppc64] Add POWER8/ISA 2.07 atomic sequences single-stepping support References: <1486350182-13993-1-git-send-email-emachado@linux.vnet.ibm.com> <38fe05a1-770c-e9f1-ecc0-042dfe0a470e@codesourcery.com> <7fe00f19-6922-fd6c-fa97-a779ffebac25@linux.vnet.ibm.com> <98042cab-d856-6426-e9a6-f7256ed789d0@linux.vnet.ibm.com> <9a226055-7485-eceb-482d-f1b9e7391ecb@linux.vnet.ibm.com> To: Edjunior Barbosa Machado , CC: From: Luis Machado Message-ID: Date: Mon, 20 Feb 2017 19:52:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <9a226055-7485-eceb-482d-f1b9e7391ecb@linux.vnet.ibm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg00546.txt.bz2 On 02/16/2017 05:42 PM, Edjunior Barbosa Machado wrote: > What about gdb.arch/ppc64-isa207-atomic-inst.*? > Could be. I don't have a better suggestion. Maybe Ulrich has. > Thus, I'm keeping the runtime check using HWCAP2 bits for now. > > Please let me know if there are any additional fixes to do. Just a nit. > diff --git a/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp > new file mode 100644 > index 0000000..2b4c8ad > --- /dev/null > +++ b/gdb/testsuite/gdb.arch/ppc64-isa207-atomic-inst.exp ... > +if {![istarget "powerpc*"] || ![is_lp64_target]} { > + verbose "Skipping testing of powerpc64 single stepping over atomic sequences." untested "skipping powerpc isa 207 atomic sequences test"? Otherwise i have no further comments. Thanks, Luis