From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19789 invoked by alias); 25 Aug 2017 10:18:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 19773 invoked by uid 89); 25 Aug 2017 10:18:05 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 25 Aug 2017 10:18:05 +0000 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D01B3356D9; Fri, 25 Aug 2017 10:18:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com D01B3356D9 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 28D197EA51; Fri, 25 Aug 2017 10:18:02 +0000 (UTC) Subject: Re: [PATCH v2] break gdb build on 32-bit host with ADI support To: Weimin Pan , gdb-patches@sourceware.org References: <1503624784-124602-1-git-send-email-weimin.pan@oracle.com> From: Pedro Alves Message-ID: Date: Fri, 25 Aug 2017 10:18:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1503624784-124602-1-git-send-email-weimin.pan@oracle.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00485.txt.bz2 $subject should be "unbreak", I hope. :-) On 08/25/2017 02:33 AM, Weimin Pan wrote: > @@ -240,7 +242,7 @@ adi_normalize_address (CORE_ADDR addr) > adi_stat_t ast = get_adi_info (ptid_get_pid (inferior_ptid)); > > if (ast.nbits) > - return ((CORE_ADDR)(((long)addr << ast.nbits) >> ast.nbits)); > + return (addr & ((1 << ast.nbits) - 1)) ^ (addr & (-1 >> ast.nbits)); How did you test this? Doesn't look right to me. Also, "-1 >>" is still an implementation-defined signed right shift. I _think_ this is what you want: /* Clear upper bits. */ addr &= ((uint64_t) -1) >> ast.nbits; /* Sign extend. */ CORE_ADDR signbit = (uint64_t) 1 << (64 - ast.nbits - 1); return (addr ^ signbit) - signbit; I.e., with ast.nbits == 4: before: ffffffffffffffff after: ffffffffffffffff before: f7ffffffffffffff after: 07ffffffffffffff Thanks, Pedro Alves