From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AHuFKeIq/GR/dRMAWB0awg (envelope-from ) for ; Sat, 09 Sep 2023 04:20:50 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=qDqJRFEq; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 9BB6C1E0C3; Sat, 9 Sep 2023 04:20:50 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8E25A1E028 for ; Sat, 9 Sep 2023 04:20:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B177D3858418 for ; Sat, 9 Sep 2023 08:20:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B177D3858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1694247647; bh=NAA3n0GM0xIJG+XY4Mdos9QFFhaTUaI03eTXGqglERM=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=qDqJRFEqWpql6JZSaqeyS18dqtNWILAtzbuy7uKbbrNYx5vYGaeLIqmZ2ITMqy1zt ZQIjFz8qwLJ9QhKpSmfkQVbrRuZTcpoUZFw07TDzLiONPa+xAuZugi8HnF04bEnP1j aWHvEvu+9PAUn7vH51T7AVOUyMwSaZPxDeWB1xNg= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 191CB3858D1E for ; Sat, 9 Sep 2023 08:20:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 191CB3858D1E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E2EBA229A8; Sat, 9 Sep 2023 08:20:18 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CCFEC1358F; Sat, 9 Sep 2023 08:20:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id 54HTMMIq/GTdOwAAMHmgww (envelope-from ); Sat, 09 Sep 2023 08:20:18 +0000 Content-Type: multipart/mixed; boundary="------------6QR2yrKXr0FU13n28eQ0bAj7" Message-ID: Date: Sat, 9 Sep 2023 10:20:19 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Throw error when creating an overly large gdb-index file Content-Language: en-US To: Kevin Buettner , gdb-patches@sourceware.org References: <20230909025521.3128935-2-kevinb@redhat.com> In-Reply-To: <20230909025521.3128935-2-kevinb@redhat.com> X-Spam-Status: No, score=-12.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This is a multi-part message in MIME format. --------------6QR2yrKXr0FU13n28eQ0bAj7 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/9/23 04:55, Kevin Buettner via Gdb-patches wrote: > I wish I could provide a test case, but due to the sizes of both the > input and output files, I think that testing resources would be strained > or exceeded in many environments. How about this unit test approach? This fails on master, and could be updated to catch the error thrown by the patch. Thanks, - Tom --------------6QR2yrKXr0FU13n28eQ0bAj7 Content-Type: text/x-patch; charset=UTF-8; name="0001-selftest.patch" Content-Disposition: attachment; filename="0001-selftest.patch" Content-Transfer-Encoding: base64 RnJvbSBmNzQ1NTc0NTYzZGYwNjhiMWNkZTUyNzI2OTM1YmY4MmExYTNjMjJkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gZGUgVnJpZXMgPHRkZXZyaWVzQHN1c2UuZGU+ CkRhdGU6IFNhdCwgOSBTZXAgMjAyMyAxMDoxNTowMSArMDIwMApTdWJqZWN0OiBbUEFUQ0hd IHNlbGZ0ZXN0CgotLS0KIGdkYi9kd2FyZjIvaW5kZXgtd3JpdGUuYyB8IDUzICsrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrLS0KIDEgZmlsZSBjaGFuZ2VkLCA1MSBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2dkYi9kd2FyZjIv aW5kZXgtd3JpdGUuYyBiL2dkYi9kd2FyZjIvaW5kZXgtd3JpdGUuYwppbmRleCAxMWYyNTRl MjYzYS4uYWUxNzA3ZDgyN2YgMTAwNjQ0Ci0tLSBhL2dkYi9kd2FyZjIvaW5kZXgtd3JpdGUu YworKysgYi9nZGIvZHdhcmYyL2luZGV4LXdyaXRlLmMKQEAgLTM4LDYgKzM4LDcgQEAKICNp bmNsdWRlICJvYmpmaWxlcy5oIgogI2luY2x1ZGUgImFkYS1sYW5nLmgiCiAjaW5jbHVkZSAi ZHdhcmYyL3RhZy5oIgorI2luY2x1ZGUgImdkYnN1cHBvcnQvc2VsZnRlc3QuaCIKIAogI2lu Y2x1ZGUgPGFsZ29yaXRobT4KICNpbmNsdWRlIDxjbWF0aD4KQEAgLTEwNzEsOSArMTA3Miwx MCBAQCBhc3NlcnRfZmlsZV9zaXplIChGSUxFICpmaWxlLCBzaXplX3QgZXhwZWN0ZWRfc2l6 ZSkKIH0KIAogLyogV3JpdGUgYSBnZGIgaW5kZXggZmlsZSB0byBPVVRfRklMRSBmcm9tIGFs bCB0aGUgc2VjdGlvbnMgcGFzc2VkIGFzCi0gICBhcmd1bWVudHMuICAqLworICAgYXJndW1l bnRzLCBhbmQgcmV0dXJuIHRoZSBhbW91bnQgb2YgYnl0ZXMgd3JpdHRlbi4gIElmIE9VVF9G SUxFIGlzIG51bGxwdHIsCisgICByZXR1cm4gdGhlIGFtb3VudCBvZiBieXRlcyB0aGF0IGlz IHN1cHBvc2VkIHRvIGJlIHdyaXR0ZW4uICAqLwogCi1zdGF0aWMgdm9pZAorc3RhdGljIHNp emVfdAogd3JpdGVfZ2RiaW5kZXhfMSAoRklMRSAqb3V0X2ZpbGUsCiAJCSAgY29uc3QgZGF0 YV9idWYgJmN1X2xpc3QsCiAJCSAgY29uc3QgZGF0YV9idWYgJnR5cGVzX2N1X2xpc3QsCkBA IC0xMTEwLDYgKzExMTIsOSBAQCB3cml0ZV9nZGJpbmRleF8xIChGSUxFICpvdXRfZmlsZSwK IAogICBnZGJfYXNzZXJ0IChjb250ZW50cy5zaXplICgpID09IHNpemVfb2ZfaGVhZGVyKTsK IAorICBpZiAob3V0X2ZpbGUgPT0gbnVsbHB0cikKKyAgICByZXR1cm4gdG90YWxfbGVuOwor CiAgIGNvbnRlbnRzLmZpbGVfd3JpdGUgKG91dF9maWxlKTsKICAgY3VfbGlzdC5maWxlX3dy aXRlIChvdXRfZmlsZSk7CiAgIHR5cGVzX2N1X2xpc3QuZmlsZV93cml0ZSAob3V0X2ZpbGUp OwpAQCAtMTExOCw2ICsxMTIzLDggQEAgd3JpdGVfZ2RiaW5kZXhfMSAoRklMRSAqb3V0X2Zp bGUsCiAgIGNvbnN0YW50X3Bvb2wuZmlsZV93cml0ZSAob3V0X2ZpbGUpOwogCiAgIGFzc2Vy dF9maWxlX3NpemUgKG91dF9maWxlLCB0b3RhbF9sZW4pOworCisgIHJldHVybiB0b3RhbF9s ZW47CiB9CiAKIC8qIFdyaXRlIHRoZSBjb250ZW50cyBvZiB0aGUgaW50ZXJuYWwgImNvb2tl ZCIgaW5kZXguICAqLwpAQCAtMTUzMCwxMCArMTUzNyw1MiBAQCBzYXZlX2dkYl9pbmRleF9j b21tYW5kIChjb25zdCBjaGFyICphcmcsIGludCBmcm9tX3R0eSkKICAgICB9CiB9CiAKKyNp ZiBHREJfU0VMRl9URVNUCisKK25hbWVzcGFjZSB7CisKK2NsYXNzIHByZXRlbmRfZGF0YV9i dWYgOiBwdWJsaWMgZGF0YV9idWYgeworcHVibGljOgorICB2b2lkIHNldF9wcmV0ZW5kX3Np emUgKHNpemVfdCBzKSB7CisgICAgbV9wcmV0ZW5kX3NpemUgPSBzOworICB9CisgIHNpemVf dCBzaXplICgpIHsKKyAgICByZXR1cm4gbV9wcmV0ZW5kX3NpemU7CisgIH0KK3ByaXZhdGU6 CisgIHNpemVfdCBtX3ByZXRlbmRfc2l6ZTsKK307CisKK3ZvaWQKK3Rlc3RfaW5kZXhfd3Jp dGUgKCkKK3sKKyAgcHJldGVuZF9kYXRhX2J1ZiBjdV9saXN0OworICBwcmV0ZW5kX2RhdGFf YnVmIHR5cGVzX2N1X2xpc3Q7CisgIHByZXRlbmRfZGF0YV9idWYgYWRkcl92ZWM7CisgIHBy ZXRlbmRfZGF0YV9idWYgc3ltdGFiX3ZlYzsKKyAgcHJldGVuZF9kYXRhX2J1ZiBjb25zdGFu dF9wb29sOworCisgIHN5bXRhYl92ZWMuc2V0X3ByZXRlbmRfc2l6ZSAofihvZmZzZXRfdHlw ZSkwKTsKKyAgY29uc3RhbnRfcG9vbC5zZXRfcHJldGVuZF9zaXplICgxKTsKKworICBzaXpl X3QgcmVzCisgICAgPSB3cml0ZV9nZGJpbmRleF8xIChudWxscHRyLCBjdV9saXN0LCB0eXBl c19jdV9saXN0LCBhZGRyX3ZlYywgc3ltdGFiX3ZlYywgY29uc3RhbnRfcG9vbCk7CisKKyAg LyogQ2hlY2sgdGhhdCBzaWxlbnQgd3JhcGFyb3VuZCBkb2VzIG5vdCBvY2N1ci4gICovCisg IFNFTEZfQ0hFQ0sgKHJlcyAhPSAyNCk7Cit9CisKK30gLyogYW5vbnltb3VzIG5hbWVzcGFj ZSAqLworI2VuZGlmCisKIHZvaWQgX2luaXRpYWxpemVfZHdhcmZfaW5kZXhfd3JpdGUgKCk7 CiB2b2lkCiBfaW5pdGlhbGl6ZV9kd2FyZl9pbmRleF93cml0ZSAoKQogeworI2lmIEdEQl9T RUxGX1RFU1QKKyAgc2VsZnRlc3RzOjpyZWdpc3Rlcl90ZXN0ICgidGVzdF9pbmRleF93cml0 ZSIsIHRlc3RfaW5kZXhfd3JpdGUpOworI2VuZGlmCisKICAgY21kX2xpc3RfZWxlbWVudCAq YyA9IGFkZF9jbWQgKCJnZGItaW5kZXgiLCBjbGFzc19maWxlcywKIAkJCQkgc2F2ZV9nZGJf aW5kZXhfY29tbWFuZCwgXygiXAogU2F2ZSBhIGdkYi1pbmRleCBmaWxlLlxuXAoKYmFzZS1j b21taXQ6IDM4YTk4NGZhNDQwYzc2ODZjNzQxYjc4MDRlYWUwNmE1Mjg4NDlhYTcKLS0gCjIu MzUuMwoK --------------6QR2yrKXr0FU13n28eQ0bAj7--