From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id x/qZG5RBqWjdMwoAWB0awg (envelope-from ) for ; Sat, 23 Aug 2025 00:20:36 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XD6qiCOg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q4ft8U1F; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XD6qiCOg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q4ft8U1F; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5EA361E043; Sat, 23 Aug 2025 00:20:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 224261E043 for ; Sat, 23 Aug 2025 00:20:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8500A3858C2C for ; Sat, 23 Aug 2025 04:20:34 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8500A3858C2C Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XD6qiCOg; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q4ft8U1F; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=XD6qiCOg; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=q4ft8U1F Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id E7CBB3858D1E for ; Sat, 23 Aug 2025 04:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E7CBB3858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E7CBB3858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755922800; cv=none; b=aBSrR6OmTPQ8vyO3APdXSLbt5cBGFJPX8WEOjprgv+7X3HaiFcNhawvOo/8p1jZbr1X0LunMaftnJ2pCLJA8k4+/kiLEdkj3tcI7YilVYq2qON6TvngBQ88/MktJUSXuqWSRXN3tHjym4gKdiJO9WCrcNwRVYlM3geum1gg2a78= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755922800; c=relaxed/simple; bh=umFNROre/ncaU+mDybVLGMSKrpDs/aeyOGVLf5XOvMc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=DVmE5mvfTwxf5IIWudxiTNaWMc1EiaNn4rDfU/Pye49L2YAbiY90HjFYE0wOPtarnqg3KXEv05tIP7HDRPis//WRfn4ugaeHWdlEC6IriktMpvXli7RgbS2YvySXkvZxNvh80biap1Fn+QaZgGToNO5lIr8W49d5wbWyrTVkgOM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E7CBB3858D1E Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 632511F385; Sat, 23 Aug 2025 04:19:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755922798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2sfEFUh5voiPieYdjamNjzFVdOXJtrXrMaKl39dCzY=; b=XD6qiCOg7a0DKtdSiJMSkWT/d5n8ioZbicUxISb5NKCuA9/9s/S2k+ZKiQ6ZcKfgCyQC/U 3qx3O/vz0z2pW9kEO9a+uQSADMdnKGv1Rcy2iwYSiY5yvU7wI3U0KUBhRf4XBdSivptZdh zqsMsUL5ZrXIMc8nVZI0ggwBOs8BVVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755922798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2sfEFUh5voiPieYdjamNjzFVdOXJtrXrMaKl39dCzY=; b=q4ft8U1FOBuunUTIaOJLIIL2h5QleKZuoWls/kJ+709bfJDR9pGjpS3MLmNR3LEsQdgUty Zpq5aR3IoeLjBQDQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=XD6qiCOg; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=q4ft8U1F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1755922798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2sfEFUh5voiPieYdjamNjzFVdOXJtrXrMaKl39dCzY=; b=XD6qiCOg7a0DKtdSiJMSkWT/d5n8ioZbicUxISb5NKCuA9/9s/S2k+ZKiQ6ZcKfgCyQC/U 3qx3O/vz0z2pW9kEO9a+uQSADMdnKGv1Rcy2iwYSiY5yvU7wI3U0KUBhRf4XBdSivptZdh zqsMsUL5ZrXIMc8nVZI0ggwBOs8BVVs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1755922798; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H2sfEFUh5voiPieYdjamNjzFVdOXJtrXrMaKl39dCzY=; b=q4ft8U1FOBuunUTIaOJLIIL2h5QleKZuoWls/kJ+709bfJDR9pGjpS3MLmNR3LEsQdgUty Zpq5aR3IoeLjBQDQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 45D96136B2; Sat, 23 Aug 2025 04:19:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id d6JZD25BqWikYAAAD6G6ig (envelope-from ); Sat, 23 Aug 2025 04:19:58 +0000 Message-ID: Date: Sat, 23 Aug 2025 06:20:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] [gdb] Make addrmap_mutable::insert_empty return bool To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-3-tdevries@suse.de> <87a53rkx5v.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87a53rkx5v.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 632511F385 X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid,suse.de:email]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 8/22/25 20:51, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> @@ -234,8 +235,14 @@ addrmap_mutable::set_empty (CORE_ADDR start, CORE_ADDR end_inclusive, > Tom> n && addrmap_node_key (n) <= end_inclusive; > Tom> n = splay_tree_successor (addrmap_node_key (n))) > Tom> { > Tom> - if (! addrmap_node_value (n)) > Tom> - addrmap_node_set_value (n, obj); > Tom> + if (addrmap_node_value (n)) > Tom> + { > Tom> + /* Already mapped. */ > Tom> + full_range = false; > Tom> + continue; > Tom> + } > Tom> + > Tom> + addrmap_node_set_value (n, obj); > > I think using 'else' here would be better than 'continue', since loop > short-circuits are harder to understand. Hi Tom, thanks for the review. I've pushed this using an if/else. FWIW, I still think that they way I wrote is is much better. My opinion is based on this coding standard rule ( https://llvm.org/docs/CodingStandards.html#use-early-exits-and-continue-to-simplify-code ). Thanks, - Tom