From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 85823 invoked by alias); 21 Oct 2019 20:07:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 85807 invoked by uid 89); 21 Oct 2019 20:07:26 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,GIT_PATCH_2,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.1 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 21 Oct 2019 20:07:24 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id x9LK7GFK015275 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 21 Oct 2019 16:07:21 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca x9LK7GFK015275 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=default; t=1571688442; bh=Vf1RcbVNgeviLbfgjCwFUzM74EwZ2pKDfFtj4R4/iPE=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=Kp9rffEBIkmgOw7WGxK/+lKX4ImijfKTVijzkLBt00l1coSkgLU9ayOhZ/HlLtRAQ QpDvxzyIvQankld4Lg3jkRuwJWPuSsKQo8mjLXGTLd+UARt0x58TOFN1q77ZNV5XAW xmzCbF5ew9cMgfJCEW/hu9iydW+6iw94Vvr+kqpU= Received: from [172.16.0.148] (192-222-181-218.qc.cable.ebox.net [192.222.181.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 603B51E0A1; Mon, 21 Oct 2019 16:07:16 -0400 (EDT) Subject: Re: [PATCH] DWARF 5 support: Handle line table and file indexes To: Ali Tamur Cc: gdb-patches@sourceware.org References: <0570f296-a2ca-c250-7e95-060014d76a97@polymtl.ca> <20191021194749.159923-1-tamur@google.com> From: Simon Marchi Message-ID: Date: Mon, 21 Oct 2019 20:07:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20191021194749.159923-1-tamur@google.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-10/txt/msg00748.txt.bz2 On 2019-10-21 3:47 p.m., Ali Tamur wrote: >> Update the comment for psymtab_include_file_name > Done. > >> is_valid_file_index should be a method of line_header > Done. > --- > > * Fix handling of file and directory indexes in line tables; in DWARF 5 the > indexes are zero-based. Make file_names field private to abstract this detail > from the clients. Introduce file_names, is_valid_file_index and > file_names_size methods. Reflect these changes in clients. > * Handle DW_FORM_data16 in read_formatted_entries; it is used to record MD5 > of the file entries in DWARF 5. > * Fix a bug in line header parsing that calculates the length of the header > incorrectly. (Seemingly this manifests itself only in DWARF 5). > > Tested with CC=/usr/bin/gcc (version 8.3.0) against master branch (also with > -gsplit-dwarf and -gdwarf-4 flags) and there was no increase in the set of > tests that fails. (gdb still cannot debug a 'hello world' program with DWARF 5, > so for the time being, this is all we care about). > > This is part of an effort to support DWARF 5 in gdb. Thanks, this version LGTM, please push. Simon