From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id psHwMumEqGgrqAkAWB0awg (envelope-from ) for ; Fri, 22 Aug 2025 10:55:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755874537; bh=FFvEg0UQJOTeQhnUmN0M9J0VmMhFpZXfsnDyP51opTE=; h=Date:Subject:To:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=TBgDs09aDBDj2H+ND6O057r7S1LK7FTHqiIyUMpOumGF8xaW3p0UCLcdb4dwqPZAO dTMKBVtIupmPcBcCk2gmzcMy/ZLYEdC13EalHNMvGZaYaSKng3gLQMEeQa7G+UzFZW ecOStKPyDJYPc2dqkXEl7fh9OCRKBoHpTTck3+pM= Received: by simark.ca (Postfix, from userid 112) id C0E3C1E048; Fri, 22 Aug 2025 10:55:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_LOW,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hq4EwBJ8; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1135F1E023 for ; Fri, 22 Aug 2025 10:55:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A89013860006 for ; Fri, 22 Aug 2025 14:55:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A89013860006 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hq4EwBJ8 Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 807BC3858D32 for ; Fri, 22 Aug 2025 14:54:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 807BC3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 807BC3858D32 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874492; cv=none; b=lO6gGfdje0svJaJKN5IEm5fi8ydOLu789y7ORIozxxZmg3klvEWjijx8ydsS/KCEQIZOPAVvH0zzH1Ph+5lQXqoMesBJrVMt5oiMMkd7/B8dF3WivzLVu2OLWY/3/9/0eMNpE+qefnjHfoCXgjBZi1OY5M5mtn4zwVr+NOo6MXo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1755874492; c=relaxed/simple; bh=FFvEg0UQJOTeQhnUmN0M9J0VmMhFpZXfsnDyP51opTE=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=IrRQe457tCQT80CH1pWHnH5WmC9c4Kx//1mNhzb2RdAExkN4s4r5+NZ5Iyrp1wjIpRRFymr8lGhTyFsY4e0wqGHym1BANai3QHHJYwK+hCWqcLa/YueORrBei82wLj++sYiGUA7cJN3aTtlOyMA5L/t50rF0chJio3nRIWJzTRw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 807BC3858D32 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1755874492; bh=FFvEg0UQJOTeQhnUmN0M9J0VmMhFpZXfsnDyP51opTE=; h=Date:Subject:To:References:From:In-Reply-To:From; b=hq4EwBJ8E8096WZoNzJkhOUViZyrpEvZJXCggGCSW6tRanr3NewUZoPsFmIMKFHqm GPpLhRqdoUDFFHZALhBs25kzq6HyDKroTxccEtfxklMBm1JN2OrhybdeP2ND3zi5Km SVUkXAdQLbCro9hFpjQXO+iwyD7Q3+aKu2hx24ag= Received: by simark.ca (Postfix) id CED041E023; Fri, 22 Aug 2025 10:54:51 -0400 (EDT) Message-ID: Date: Fri, 22 Aug 2025 10:54:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] [gdb] Make addrmap_mutable::insert_empty return bool To: Tom de Vries , gdb-patches@sourceware.org References: <20250821133114.24091-1-tdevries@suse.de> <20250821133114.24091-3-tdevries@suse.de> Content-Language: fr From: Simon Marchi In-Reply-To: <20250821133114.24091-3-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org insert_empty -> set_empty in the subject. Otherwise, LGTM. Approved-By: Simon Marchi Simon