From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SBwXAuwWCWDQeQAAWB0awg (envelope-from ) for ; Thu, 21 Jan 2021 00:53:48 -0500 Received: by simark.ca (Postfix, from userid 112) id 067C91EF80; Thu, 21 Jan 2021 00:53:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56A931E590 for ; Thu, 21 Jan 2021 00:53:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ED18D385141E; Thu, 21 Jan 2021 05:53:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED18D385141E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1611208427; bh=OH+cYQZy5SNviG2Km9yobrQpHRt3DmNTL8DkMa2Hbvg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=SDS9OrXSW//uaLablcEkhLuyBLD7CmQ0e1lDlpTyfoXnZoAxQpImPubTIrIt+isOu 1bRnu6rWAkgdz3jZKaCwLnrlkCoIixWfBdu1rOHBBXxJSgREyo56DDJRnNNGDCcPV8 keBtZRaflj7vnS59xRBkbYKMsoXqs6u+M9ChmAPE= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 33DC9385141E for ; Thu, 21 Jan 2021 05:53:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 33DC9385141E Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 10L5rcZC029625 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 Jan 2021 00:53:42 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 10L5rcZC029625 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id BBF1F1E590; Thu, 21 Jan 2021 00:53:37 -0500 (EST) Subject: Re: [PATCH] Fixed issues with processing of DW_FORM_loclistx / DW_FORM_rnglistx To: "Sharma, Alok Kumar" , "gdb-patches@sourceware.org" References: Message-ID: Date: Thu, 21 Jan 2021 00:53:37 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 Jan 2021 05:53:38 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: "George, Jini Susan" , "Achra, Nitika" Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-01-21 12:49 a.m., Sharma, Alok Kumar via Gdb-patches wrote: > Hi all, > > I request you all to please review the patch. Below are the details. > > Problem Description: > GDB produces internal error while processing DW_FORM_loclistx / DW_FORM_rnglistx, > $ make check RUNTESTFLAGS="CXX_FOR_TARGET=/path/to/clang++ " TEST=gdb.dwarf2/dw5-rnglist-test.exp > Below is the snippet from gdb.log file. > --------- > (gdb) file /dir/gdb/testsuite/outputs/gdb.dwarf2/dw5-rnglist-test/dw5-rnglist-test > Reading symbols from /dir/gdb/testsuite/outputs/gdb.dwarf2/dw5-rnglist-test/dw5-rnglist-test... > gdb/dwarf2/attribute.h:232: internal-error: void attribute::set_unsigned_reprocess(ULONGEST): Assertion `form_requires_reprocessing ()' failed. > A problem internal to GDB has been detected, > further debugging may prove unreliable. > Quit this debugging session? (y or n) ERROR: Couldn't load dw5-rnglist-test into GDB (GDB internal error). > Resyncing due to internal error. > --------- > This is due to incomplete handling of DW_FORM_loclistx / DW_FORM_rnglistx, > which is available with -gdwarf-5 option for clang compiler. > Resolution: > Forms DW_FORM_loclistx / DW_FORM_rnglistx need two phases of processing. > The required modifications in various routines are added to fix the issue. > > gdb/ChangeLog: > > 2021-01-21 Alok Kumar Sharma > > * dwarf2/attribute.c (form_is_unsigned): Handle DW_FORM_loclistx. > (form_requires_reprocessing): Handle DW_FORM_loclistx and > DW_FORM_rnglistx. > * dwarf2/attribute.h (set_address): Handle DW_FORM_loclistx and > DW_FORM_rnglistx. > * dwarf2/read.c (read_attribute_reprocess): Replaced as_unsigned with > as_unsigned_reprocess for DW_FORM_loclistx and DW_FORM_rnglistx. > > Regards, > Alok > Hi Alok, Could you please take a look at this series I posted yesterday? https://sourceware.org/pipermail/gdb-patches/2021-January/175221.html I think it contains pretty much the same changes (and more). Simon