From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99218 invoked by alias); 11 Jul 2019 16:05:47 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 99208 invoked by uid 89); 11 Jul 2019 16:05:47 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy= X-HELO: mail-wr1-f65.google.com Received: from mail-wr1-f65.google.com (HELO mail-wr1-f65.google.com) (209.85.221.65) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 11 Jul 2019 16:05:37 +0000 Received: by mail-wr1-f65.google.com with SMTP id x4so6899767wrt.6 for ; Thu, 11 Jul 2019 09:05:37 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id q18sm2528703wrw.36.2019.07.11.09.05.18 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jul 2019 09:05:35 -0700 (PDT) Subject: Re: [PATCH 0/2] Make use of gdb::options for info variabels|functions|args|locals To: Andrew Burgess References: <306a840c-719a-0398-26cd-34142ba05167@redhat.com> <20190711155305.GO23204@embecosm.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 11 Jul 2019 16:05:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190711155305.GO23204@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00323.txt.bz2 On 7/11/19 4:53 PM, Andrew Burgess wrote: > * Pedro Alves [2019-07-11 14:36:23 +0100]: > >> On 7/11/19 2:20 PM, Andrew Burgess wrote: >>> Additional use of the gdb::options framework. >>> >>> -- >>> >>> Andrew Burgess (2): >>> gdb: Allow quoting around string options in the gdb::option framework >> >> Ahaha, that didn't take long. Thanks for doing this. LGTM. >> >>> gdb: Make use of gdb::option framework for some info commands >> >> This LGTM to me too, but, I was surprised to find this doesn't add >> completers at the same time? > > Something like this, maybe? _Exactly_ like that. Perfect. So far, I've listed this sort of improvement under "Completion improvements" in NEWS. I think you lists these commands there too, and it'd be an obvious change. > + > + const char *word = advance_to_expression_complete_word_point (tracker, text); > + symbol_completer (ignore, tracker, text, word); > + return; Redundant "return". Thanks, Pedro Alves