From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id TiwjDaEufWOBexsAWB0awg (envelope-from ) for ; Tue, 22 Nov 2022 15:18:41 -0500 Received: by simark.ca (Postfix, from userid 112) id 264B71E124; Tue, 22 Nov 2022 15:18:41 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=DGnHZUe8; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BAE581E0CB for ; Tue, 22 Nov 2022 15:18:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3DE213858412 for ; Tue, 22 Nov 2022 20:18:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3DE213858412 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1669148320; bh=KTfH4RPeNVIaNFgLPSwc+PrDJgzOqk3dFgwJ5w7em1I=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=DGnHZUe8i+DsvXZIvTqSKxI9FMyqtp+QKvdJiB+EZJLqll48XcNzAWi7HuWMj+8kb W8exGh17iEDz7IVh42WAISSmxC2LYbDlJU3LhVIKhyhk2QTvMPISKhrrpHKY3CMX84 8FXkHvlB8EZv90TNApmmLN8PMJ2IhZqJ/ymzMRl8= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id CD56E3858C1F for ; Tue, 22 Nov 2022 20:18:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org CD56E3858C1F Received: from [172.16.0.64] (192-222-180-24.qc.cable.ebox.net [192.222.180.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 6A5501E0CB; Tue, 22 Nov 2022 15:18:21 -0500 (EST) Message-ID: Date: Tue, 22 Nov 2022 15:18:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH 1/5] regcache: Add collect/supply_regset variants that accept a register base. Content-Language: fr To: John Baldwin , gdb-patches@sourceware.org References: <20220708005816.9408-1-jhb@FreeBSD.org> <20220708005816.9408-2-jhb@FreeBSD.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> diff --git a/gdb/regcache.h b/gdb/regcache.h >> index 1dbba5ce9af..f01127b20fb 100644 >> --- a/gdb/regcache.h >> +++ b/gdb/regcache.h >> @@ -150,6 +150,14 @@ extern void regcache_collect_regset (const struct regset *regset, >> int regnum, void *buf, size_t size); >> >> >> +extern void regcache_supply_regset (const struct regset *regset, int regbase, >> + struct regcache *regcache, >> + int regnum, const void *buf, >> + size_t size); >> +extern void regcache_collect_regset (const struct regset *regset, int regbase, >> + const struct regcache *regcache, >> + int regnum, void *buf, size_t size); > > These don't have a definition, I guess they are not needed. > > (Could we make a patch that removes regcache_supply_regset and > regcache_collect_regset, since they just forward to the regcache > methods?) Answering my own question, no we can't. They are used as callbacks in regset structures. Simon