Re: [PATCH] Fix thinko on last commit

Sergio Durigan Junior
2017-02-20T13:08:13Z

On Monday, February 20 2017, I wrote:

> On fork-child.c:trace_start_error, va_end should refer to 'ap', not
> 'args. This fixes it.

I've pushed this as obvious.

> Sorry about the breakage.
>
> gdb/ChangeLog:
> 2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
>
> PR gdb/16188
> * fork-child.c (trace_start_error): Fix thinko. va_end should
> refer to 'ap', not 'args'.
> ---
> gdb/ChangeLog | 6 ++++++
> gdb/fork-child.c | 2 +-
> 2 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/gdb/ChangeLog b/gdb/ChangeLog
> index cf68c7e..610755c 100644
> --- a/gdb/ChangeLog
> +++ b/gdb/ChangeLog
> @@ -1,4 +1,10 @@
> 2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
> +
> + PR gdb/16188
> + * fork-child.c (trace_start_error): Fix thinko. va_end should
> + refer to 'ap', not 'args'.
> +
> +2017-02-20 Sergio Durigan Junior <sergiodj@redhat.com>
> Pedro Alves <palves@redhat.com>
>
> PR gdb/16188
> diff --git a/gdb/fork-child.c b/gdb/fork-child.c
> index f6256fb..dc2a314 100644
> --- a/gdb/fork-child.c
> +++ b/gdb/fork-child.c
> @@ -120,7 +120,7 @@ trace_start_error (const char *fmt, ...)
> fprintf_unfiltered (gdb_stderr, "Could not trace the inferior "
> "process.\nError: ");
> vfprintf_unfiltered (gdb_stderr, fmt, ap);
> - va_end (args);
> + va_end (ap);
>
> gdb_flush (gdb_stderr);
> _exit (0177);
> --
> 2.9.3

--
Sergio
GPG key ID: 237A 54B1 0287 28BF 00EF 31F4 D0EB 7628 65FC 5E36
Please send encrypted e-mail if possible