From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91859 invoked by alias); 14 Aug 2017 14:19:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91817 invoked by uid 89); 14 Aug 2017 14:19:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=oct, Oct, xxx X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 14 Aug 2017 14:19:16 +0000 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 41F43ACB0; Mon, 14 Aug 2017 14:19:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 41F43ACB0 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7750E68736; Mon, 14 Aug 2017 14:19:14 +0000 (UTC) Subject: Re: [RFA] Make "bt N" print correct number of frames when using a frame filter To: Tom Tromey References: <20170423160446.17062-1-tom@tromey.com> <5aa8225f-70d1-2e69-9280-ca527b2ea981@redhat.com> <87wp7au9th.fsf@pokyo> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Mon, 14 Aug 2017 14:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <87wp7au9th.fsf@pokyo> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-08/txt/msg00296.txt.bz2 On 07/14/2017 07:56 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> Can you expand on the need for the PRINT_MORE_FRAMES flag and > Pedro> having it based on from_tty? I assume that your first made > Pedro> the printing unconditional, but then for some reason decided > Pedro> against it? > > I think my reason was just to have it parallel the no-frame-filter code > in stack.c: > > /* If we've stopped before the end, mention that. */ > if (fi && from_tty) > printf_filtered (_("(More stack frames follow...)\n")); > > I don't know why this code is conditional on from_tty, but that seemed > like a separate decision. OK. I found that was added here: +Tue Oct 2 11:20:02 1990 John Gilmore (gnu at cygint) + + * stack.c (backtrace_command): Skip "more stack frames follow" + unless interactive. Funny enough, around the same time the preloading of symbols was added. See: $ git diff 831c851165e1^..bd5635a1 -- stack.c @@ -493,6 +515,28 @@ backtrace_command (count_exp) else count = -1; + if (info_verbose) + { + struct partial_symtab *ps; + + /* Read in symbols for all of the frames. Need to do this in + a separate pass so that "Reading in symbols for xxx" messages + don't screw up the appearance of the backtrace. Also + if people have strong opinions against reading symbols for + backtrace this may have to be an option. */ + i = count; + for (frame = trailing; + frame != NULL && i--; + frame = get_prev_frame (frame)) + { + QUIT; + fi = get_frame_info (frame); + ps = find_pc_psymtab (fi->pc); + if (ps) + (void) PSYMTAB_TO_SYMTAB (ps); /* Force syms to come in */ + } + } + for (i = 0, frame = trailing; frame && count--; i++, frame = get_prev_frame (frame)) @@ -503,7 +547,7 @@ backtrace_command (count_exp) } /* If we've stopped before the end, mention that. */ - if (frame) + if (frame && from_tty) printf_filtered ("(More stack frames follow...)\n"); } ^L Thanks, Pedro Alves