From: Pedro Alves <pedro@palves.net>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Do not adjust mtime timezone on Windows
Date: Tue, 8 Sep 2020 17:28:13 +0100 [thread overview]
Message-ID: <e42b84c1-2dbf-e44d-eb6e-d794b47de1ec@palves.net> (raw)
In-Reply-To: <20200903170244.2508330-1-tromey@adacore.com>
On 9/3/20 6:02 PM, Tom Tromey wrote:
> PR win32/25302 notes that gdb will crash when trying to "run" even a
> simple program on Windows. The essential bug here is that the BFD
> cache can easily be corrupted -- I have sent a separate patch for
> that.
>
> The particular reason that the cache is corrupted on Windows is that
> gnulib overrides "stat" to make it do timezone adjustment -- but BFD
> does not use this version of stat. The difference here triggers the
> latent cache bug, but can also cause other bugs as well; in particular
> it can cause spurious warnings about source files being newer.
>
> This patch simply removes the stat override on mingw, making gnulib
> and BFD agree.
>
> I tested this by backing out the local AdaCore changes to work around
> this bug and then verifying that I could reproduce it. Then, I
> applied this patch and verified that "run" works again.
>
> gnulib/ChangeLog
> 2020-09-03 Tom Tromey <tromey@adacore.com>
>
> PR win32/25302:
> * update-gnulib.sh: Apply stat patch.
> * patches/0001-use-windows-stat: New file.
> * import/m4/stat.m4: Update.
> * configure: Rebuild.
I agree this is the best we can do right now.
LGTM.
Thanks,
Pedro Alves
prev parent reply other threads:[~2020-09-08 16:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 17:02 Tom Tromey
2020-09-05 20:49 ` Joel Brobecker
2020-09-06 0:16 ` Simon Marchi
2020-09-08 16:20 ` Tom Tromey
2020-09-08 16:28 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e42b84c1-2dbf-e44d-eb6e-d794b47de1ec@palves.net \
--to=pedro@palves.net \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox