From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gu22Fv2CFGhkvhAAWB0awg (envelope-from ) for ; Fri, 02 May 2025 04:31:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kGXEJqTQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HaWpANic; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kGXEJqTQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HaWpANic; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 4C3831E10E; Fri, 2 May 2025 04:31:57 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-9.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 639F11E0C2 for ; Fri, 2 May 2025 04:31:56 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CA4823858C42 for ; Fri, 2 May 2025 08:31:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CA4823858C42 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kGXEJqTQ; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HaWpANic; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=kGXEJqTQ; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=HaWpANic Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 791353858D20 for ; Fri, 2 May 2025 08:31:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 791353858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 791353858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746174683; cv=none; b=VhB9SMls+RePp0+mMcv6ND8o/pQG0qk8RQZAiyTnzO9dc8NWNxYkXUHbm+spAqfrR/Tmbeuj1THH+1qCas0qyVj7wwFmcEGXjjNRL49rfGZRIMJ4h/XKlwE25Q/BK/DlkF2pAmsKrcGoCzSX/3XTc1vyB6OD/DjsS4NOj8IIMjk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746174683; c=relaxed/simple; bh=WtGVd6m/YlCxLjG4/gvTslhQjr4KPoKZihetWYH4DAw=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=CykFy6E73aIOKxrOuPRADj6PuKFxnvrqmmihoCsAtjcr9al2Sf9ue1uOOhKqWuzOGcC06iKrGju6r7EemjxR+glIPXR541BwE4s5RKAN4yB4o8NtkrmhNJLPiMYiudvltmMSFahNIUSvJQjQxV9NisROldNRT2qnflea13deCv0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 791353858D20 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 66449211E5; Fri, 2 May 2025 08:31:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746174682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRd6+syW/bKR5TjZCbB10Q2frAUxyrCisg01zBPHGAo=; b=kGXEJqTQUXSj8KiUBDocDwPVROIevE/S/KD2h/xM8XR2h5y0Z27K7Sz9WAXPvB2oQHbroY 5faMBH41xSS0sL+d2qJSkI7sxLyQkEleCxAJZBwpSy97XATcK26d+q8lCCVWb+MlGgGHfp XM+ETCv6hqkK8TcMRtJmjskGxrK1zr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746174682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRd6+syW/bKR5TjZCbB10Q2frAUxyrCisg01zBPHGAo=; b=HaWpANic0hUS0H3nDTkjiG4nSR6XHth/LnHjwpze1IfS4hdRTeyEUsgHm2br/z0EwboNNJ ENvqpgVMqsHqTLDA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=kGXEJqTQ; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=HaWpANic DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1746174682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRd6+syW/bKR5TjZCbB10Q2frAUxyrCisg01zBPHGAo=; b=kGXEJqTQUXSj8KiUBDocDwPVROIevE/S/KD2h/xM8XR2h5y0Z27K7Sz9WAXPvB2oQHbroY 5faMBH41xSS0sL+d2qJSkI7sxLyQkEleCxAJZBwpSy97XATcK26d+q8lCCVWb+MlGgGHfp XM+ETCv6hqkK8TcMRtJmjskGxrK1zr8= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1746174682; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=iRd6+syW/bKR5TjZCbB10Q2frAUxyrCisg01zBPHGAo=; b=HaWpANic0hUS0H3nDTkjiG4nSR6XHth/LnHjwpze1IfS4hdRTeyEUsgHm2br/z0EwboNNJ ENvqpgVMqsHqTLDA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 15B6D13687; Fri, 2 May 2025 08:31:22 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 5WW2A9qCFGgESgAAD6G6ig (envelope-from ); Fri, 02 May 2025 08:31:22 +0000 Message-ID: Date: Fri, 2 May 2025 10:31:35 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] [gdb/testsuite] Make gdb.threads/inf-thr-count.exp more readable From: Tom de Vries To: Andreas Schwab Cc: gdb-patches@sourceware.org References: <20250418092356.4579-1-tdevries@suse.de> <20250418092356.4579-3-tdevries@suse.de> <87r01pg655.fsf@linux-m68k.org> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 66449211E5 X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FUZZY_BLOCKED(0.00)[rspamd.com]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_TRACE(0.00)[0:+]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_TLS_ALL(0.00)[]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; TO_DN_SOME(0.00)[]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:106:10:150:64:167:received,2a07:de40:b281:104:10:150:64:97:from]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ASN(0.00)[asn:25478, ipnet:::/0, country:RU]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:dkim,suse.de:mid] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Action: no action X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/18/25 12:47, Tom de Vries wrote: > On 4/18/25 11:39, Andreas Schwab wrote: >> On Apr 18 2025, Tom de Vries wrote: >> >>> +    set re_int [string_to_regexp "-"]?$::decimal >> >> Why do you need to use string_to_regexp for such a simple string? >> > > Hi Andreas, > > thanks for the review. > > Indeed, [string_to_regexp "-"] == "-", I didn't realize that. > Anyway, committed using "-" instead of [string_to_regexp "-"]. Thanks, - Tom > I guess that using {[-]} comes from problems when using the minus at the > start of a regexp: > ... > % puts [regexp {-} {-}] > bad option "-": must be -all, -about, -indices, -inline, -expanded, - > line, -linestop, -lineanchor, -nocase, -start, or -- > % puts [regexp {[-]} {-}] > 1 > % > ... > while this also works: > ... > % puts [regexp {\-} {-}] > 1 > ... > > So perhaps string_to_regexp should also escape "-" to fix this failure: > ... > set re [string_to_regexp "-"] > gdb_assert { [eval regexp $re "-"] } > ... > > Thanks, > - Tom