From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26802 invoked by alias); 21 Jun 2019 16:51:02 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 26783 invoked by uid 89); 21 Jun 2019 16:51:02 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-14.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1379 X-HELO: mx1.suse.de Received: from mx2.suse.de (HELO mx1.suse.de) (195.135.220.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 21 Jun 2019 16:51:00 +0000 Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A9444AF8F; Fri, 21 Jun 2019 16:50:58 +0000 (UTC) Subject: Re: [PATCH][gdb/testsuite] Compile index-cache.c with -Wl,--build-id To: Pedro Alves , gdb-patches@sourceware.org Cc: Simon Marchi References: <20190621152742.GA20230@delia> <62bf83ef-0c18-12a8-bfb0-8f3f28fa84ba@suse.de> <31086b56-cffc-140a-bb5c-fc22151ba379@redhat.com> From: Tom de Vries Message-ID: Date: Fri, 21 Jun 2019 16:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <31086b56-cffc-140a-bb5c-fc22151ba379@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2019-06/txt/msg00435.txt.bz2 On 21-06-19 18:32, Pedro Alves wrote: > On 6/21/19 4:54 PM, Tom de Vries wrote: >> On 21-06-19 17:47, Pedro Alves wrote: >>> On 6/21/19 4:27 PM, Tom de Vries wrote: >>>> Hi, >>>> >>>> When building gdb using a combined gcc/binutils-gdb build and running >>>> gdb.base/index-cache.exp we get: >>>> ... >>>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: at least one file was created >>>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_miss: couldn't get executable build id >>>> FAIL: gdb.base/index-cache.exp: test_cache_enabled_hit: check index-cache stats >>>> ... >>>> >>>> With "set debug index-cache on" we get: >>>> ... >>>> (gdb) file index-cache >>>> Reading symbols from index-cache... >>>> index cache: objfile index-cache has no build id >>>> ... >>>> >>>> The problem is that the vanilla toolchain does not add a build-id, which is >>>> required for the index-cache functionality. >>> >>> What is "vanilla" here? A non-combined gcc/build-gdb build? >>> Or is "combined gcc/build-gdb build" irrelevant here, and >>> "vanilla" means "no-distro-patches build"? >> >> The latter. > > OK. Please tweak the commit log in that direction then. > > The fix LGTM too. Thanks for the review, I've updated the rationale. I'll commit in a bit unless there are further comments. Thanks, - Tom