From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8BF0D6C/VGqTVgUAWB0awg (envelope-from ) for ; Mon, 13 Jul 2026 06:36:16 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fhzr4L1T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ykk33+56; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MMeaHPEP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LqvNm95V; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 314511E04F; Mon, 13 Jul 2026 06:36:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 60D011E04F for ; Mon, 13 Jul 2026 06:36:15 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 42DA64BA5434 for ; Mon, 13 Jul 2026 10:36:14 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 42DA64BA5434 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fhzr4L1T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ykk33+56; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MMeaHPEP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LqvNm95V Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id D13284BA5434 for ; Mon, 13 Jul 2026 10:35:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D13284BA5434 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org D13284BA5434 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783938950; cv=none; b=sWbgAH+x0zUzLiMpIyvgOGGazJAhOJ3uO8xTGgZN9HKNka+rHeVeAiUjZVittgB3oHpAmgk2TiXNhaJWz/RhMwz7wNlS+K4WkVelGRMT9CG5jmNoUeC5OFcsiDgX6RUnU4bWFgLhAvSxRFv+n2IOW4LQdSzqSEQ1eolhBrlf/7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1783938950; c=relaxed/simple; bh=WtIwtsxT3WUsLfnNsp+GleJhSj4Gs48F3Gl9o3xmx6E=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=Qyey8ysFz7SSa+tHzkhmdYC5Ab+gZEdQ4p+TNXCAUbN9pjI+GvtNt7wnqPXtwGEykpuXXCSH6uALElhpVLYt2PE2HSmHSagYxi4yThUF2p+biuvNg1FKYXFq65RXUUFyqEhyt+yMgHhPGFs2Tfht0aybvwENIKSBHQstgsC+MXU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=fhzr4L1T; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=Ykk33+56; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=MMeaHPEP; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=LqvNm95V DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D13284BA5434 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id F01797780B; Mon, 13 Jul 2026 10:35:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783938948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkXiutztclAgUB+4JjPwS9josooqfbpz6fRxlEI/ZmQ=; b=fhzr4L1TZcEUcRiJFDxoknKpSPnGEqlsrIj3q7+BsJMKeEkPJPp28fMO5xRqjf3WGCvx3h kEDPQEyZ6YWK/+v4j4Gjz7uMOF1H47qbrBSA8G0eJpjlPk0jr3ZLfR4p4qylXqE5XEUbsG nEH9TggQUJhTy157+YqAEburb/6s4Ps= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783938948; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkXiutztclAgUB+4JjPwS9josooqfbpz6fRxlEI/ZmQ=; b=Ykk33+56DmM2G1JnDT05gc8Z1g/vH2ZulPxGyXkanIzRHzeRbzC6aa3iAYOSwkpvOiy74L pTKycn6X8oC7d9DQ== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=MMeaHPEP; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=LqvNm95V DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1783938947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkXiutztclAgUB+4JjPwS9josooqfbpz6fRxlEI/ZmQ=; b=MMeaHPEPxinVDarcuF0WuO+ICE3I4WNOWTkOw8BHh6pwwpFcCAViqrAqzFwlen2I6Zzz2f rh7N9GoJT+JXm4MiJlGgetV8i8uCnbKwXe5rAfJ6WR3Hpin7aPgxuTkkJv6jpFJQFvQqqL Cd6LR5tSNd6LAchv4djcRBbfw5P3i8w= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1783938947; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rkXiutztclAgUB+4JjPwS9josooqfbpz6fRxlEI/ZmQ=; b=LqvNm95VsHLZiAFaicF9tjcYbmvC7Ql+8jrvEPCMewZbc3crP0OpJU2DQkhc28yswcs7+O cv+H/ZD48NwT2BAQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id D9371779AE; Mon, 13 Jul 2026 10:35:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ggmgM4O/VGoqPQAAD6G6ig (envelope-from ); Mon, 13 Jul 2026 10:35:47 +0000 Message-ID: Date: Mon, 13 Jul 2026 12:35:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] : add 'tomli' dependency for codespell pre-commit hook From: Tom de Vries To: Stephan Rohr , gdb-patches@sourceware.org References: <20260630082043.84858-1-stephan.rohr@intel.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Action: no action X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; MIME_TRACE(0.00)[0:+]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; RCVD_TLS_ALL(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,intel.com:email,suse.de:email,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Server: rspamd2.dmz-prg2.suse.org X-Rspamd-Queue-Id: F01797780B X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/13/26 11:42 AM, Tom de Vries wrote: > On 6/30/26 10:20 AM, Stephan Rohr wrote: >> From: "Rohr, Stephan" >> >> The codespell pre-commit hook imports the 'tomllib' module to parse >> 'pyproject.toml'.  'tomllib' is not available for Python versions 3.10 >> and older.  Add a dependency on 'tomli' so the hook also works on these >> Python versions. >> > > Hi, > > this LGTM. > > Approved-By: Tom de Vries > Also, consider removing duplication using an anchor: ... diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index f96959d79fc..70c3033a9fe 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -80,12 +80,12 @@ repos: files: '^(gdb|gdbserver|gdbsupport)/' args: [--toml, gdb/pyproject.toml] # 'tomllib' library is not available on Python < 3.11. - additional_dependencies: ['tomli'] + additional_dependencies: &codespell_deps ['tomli'] - id: codespell name: codespell-log entry: gdb/contrib/codespell-log.sh args: [--toml, gdb/pyproject.toml] - additional_dependencies: ['tomli'] + additional_dependencies: *codespell_deps verbose: true stages: [commit-msg] ... Thanks, - Tom > FWIW, I had some trouble reproducing this.  I tried to reproduce this in > a python virtual environment (3.10) on a system with system python 3.14. >  As it turns out, pre-commit creates a python 3.14 environment, so > tomli is found. > > After setting language_version to 3.10 in the yaml file, I managed to > reproduce it, and indeed your patch fixes it. > > Thanks, > - Tom > >> --- >>   .pre-commit-config.yaml | 3 +++ >>   1 file changed, 3 insertions(+) >> >> diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml >> index 9910bbb82f2..1c6b018d7ac 100644 >> --- a/.pre-commit-config.yaml >> +++ b/.pre-commit-config.yaml >> @@ -79,10 +79,13 @@ repos: >>       - id: codespell >>         files: '^(gdb|gdbserver|gdbsupport)/' >>         args: [--toml, gdb/pyproject.toml] >> +      # 'tomllib' library is not available on Python < 3.11. >> +      additional_dependencies: ['tomli'] >>       - id: codespell >>         name: codespell-log >>         entry: gdb/contrib/codespell-log.sh >>         args: [--toml, gdb/pyproject.toml] >> +      additional_dependencies: ['tomli'] >>         verbose: true >>         stages: [commit-msg] >