From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-71253-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 12422 invoked by alias); 18 Mar 2010 20:59:48 -0000
Received: (qmail 12413 invoked by uid 22791); 18 Mar 2010 20:59:47 -0000
X-SWARE-Spam-Status: No, hits=-2.0 required=5.0 	tests=BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 18 Mar 2010 20:59:44 +0000
Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) 	by smtp-out.google.com with ESMTP id o2IKxg30032000 	for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 13:59:42 -0700
Received: from wyb38 (wyb38.prod.google.com [10.241.225.102]) 	by wpaz21.hot.corp.google.com with ESMTP id o2IKxejH006504 	for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 13:59:41 -0700
Received: by wyb38 with SMTP id 38so1246870wyb.19         for <gdb-patches@sourceware.org>; Thu, 18 Mar 2010 13:59:40 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.85.132 with SMTP id u4mr742789wee.191.1268945980364; Thu,  	18 Mar 2010 13:59:40 -0700 (PDT)
In-Reply-To: <20100318195050.GA11586@caradoc.them.org>
References: <20100318173015.6765784413@ruffy.mtv.corp.google.com> 	 <201003181747.29518.pedro@codesourcery.com> 	 <e394668d1003181123m5347420am335bb97775a1a782@mail.gmail.com> 	 <201003181855.o2IIthRb027235@glazunov.sibelius.xs4all.nl> 	 <e394668d1003181219p5f7a8489oca6bde6b3343e9ed@mail.gmail.com> 	 <20100318192535.GA25322@host0.dyn.jankratochvil.net> 	 <e394668d1003181238p1ccf89b0s682db8cbe1c7fd10@mail.gmail.com> 	 <20100318195050.GA11586@caradoc.them.org>
Date: Thu, 18 Mar 2010 20:59:00 -0000
Message-ID: <e394668d1003181359pa8e6f33jd1f37f8f38860efa@mail.gmail.com>
Subject: Re: [RFC] Why does ui_out_field_core_addr pad with leading zeroes?
From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>,         Mark Kettenis <mark.kettenis@xs4all.nl>, pedro@codesourcery.com,         gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2010-03/txt/msg00698.txt.bz2

On Thu, Mar 18, 2010 at 12:51 PM, Daniel Jacobowitz
<dan@codesourcery.com> wrote:
> On Thu, Mar 18, 2010 at 12:38:09PM -0700, Doug Evans wrote:
>> 2010-03-18 =A0Doug Evans =A0<dje@google.com>
>>
>> =A0 =A0 =A0 =A0 * ui-out.c (ui_out_field_core_addr): Don't pad address w=
ith leading
>> =A0 =A0 =A0 =A0 zeroes.
>> =A0 =A0 =A0 =A0 * breakpoint.c (breakpoint_1): Right align breakpoint ad=
dresses.
>
> Does this right align the header, or just the contents?
>
> I may be alone, and at risk of bikeshedding, but I think this looks
> weird:
>
> Num =A0 =A0 =A0 =A0 Address
> 1 =A0 =A0 =A0 =A0 =A0 =A00x4414
> 2 =A0 =A0 =A00x1231230000
>
> I'm more a fan of:
>
> Num =A0Address
> 1 =A0 =A0 =A0 =A0 =A0 =A0 =A0 0x4414
> 2 =A0 =A0 =A0 =A0 0x1231230000

Would you left justify all headers with right-justified data?
Or should ui-out support differentiating header justification with the data=
's?
Feels like a stretch to me.

> [They both look a bit weird to me though. =A0My ideal UI for this stuff
> resizes based on contents...]

Yeah.