From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1915 invoked by alias); 4 Mar 2010 02:56:49 -0000 Received: (qmail 1906 invoked by uid 22791); 4 Mar 2010 02:56:49 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 04 Mar 2010 02:56:45 +0000 Received: from spaceape9.eur.corp.google.com (spaceape9.eur.corp.google.com [172.28.16.143]) by smtp-out.google.com with ESMTP id o242uhra003566 for ; Wed, 3 Mar 2010 18:56:43 -0800 Received: from wwa36 (wwa36.prod.google.com [10.241.241.36]) by spaceape9.eur.corp.google.com with ESMTP id o242udi6029034 for ; Wed, 3 Mar 2010 18:56:41 -0800 Received: by wwa36 with SMTP id 36so1177131wwa.19 for ; Wed, 03 Mar 2010 18:56:39 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.90.17 with SMTP id d17mr5413123wef.175.1267671399573; Wed, 03 Mar 2010 18:56:39 -0800 (PST) In-Reply-To: <201003040243.36094.pedro@codesourcery.com> References: <201003040047.17716.pedro@codesourcery.com> <201003040243.36094.pedro@codesourcery.com> Date: Thu, 04 Mar 2010 02:56:00 -0000 Message-ID: Subject: Re: FYI: fix PR 11345 From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org, tromey@redhat.com Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00151.txt.bz2 On Wed, Mar 3, 2010 at 6:43 PM, Pedro Alves wrote: > On Thursday 04 March 2010 02:35:44, Doug Evans wrote: >> I'd be ok with just adding a dummy format arg (and a comment >> explaining why it's there of course). > > something like printf("%s", string) instead of printf(string)? > That doesn't work in this case, because printf("%s", "%%") > isn't the same as printf("%%"), so you're back to the > original bug. printf (string, 0) is what I had in mind. obviously printf ("%s", "%%") won't fix anything. ... but having tried it I'm seeing "... argument types not checked". Blech.