From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21375 invoked by alias); 2 Mar 2010 17:32:23 -0000 Received: (qmail 21354 invoked by uid 22791); 2 Mar 2010 17:32:22 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 02 Mar 2010 17:32:18 +0000 Received: from kpbe14.cbf.corp.google.com (kpbe14.cbf.corp.google.com [172.25.105.78]) by smtp-out.google.com with ESMTP id o22HWF0W015384 for ; Tue, 2 Mar 2010 17:32:15 GMT Received: from wwb29 (wwb29.prod.google.com [10.241.241.93]) by kpbe14.cbf.corp.google.com with ESMTP id o22HWDOD018582 for ; Tue, 2 Mar 2010 09:32:14 -0800 Received: by wwb29 with SMTP id 29so249146wwb.6 for ; Tue, 02 Mar 2010 09:32:13 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.87.146 with SMTP id y18mr239841wee.127.1267551133137; Tue, 02 Mar 2010 09:32:13 -0800 (PST) In-Reply-To: <20100302150601.GC20342@caradoc.them.org> References: <20100302065440.4831784843@ruffy.mtv.corp.google.com> <20100302150601.GC20342@caradoc.them.org> Date: Tue, 02 Mar 2010 17:32:00 -0000 Message-ID: Subject: Re: [RFA] Add missing baseaddr in dwarf2read.c From: Doug Evans To: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-03/txt/msg00057.txt.bz2 On Tue, Mar 2, 2010 at 7:06 AM, Daniel Jacobowitz wr= ote: > On Mon, Mar 01, 2010 at 10:54:40PM -0800, Doug Evans wrote: >> Ok to check in? >> >> 2010-03-01 =A0Doug Evans =A0 >> >> =A0 =A0 =A0 * dwarf2read.c (add_partial_subprogram): Add missing baseadd= r to >> =A0 =A0 =A0 lowpc,highpc args to addrmap_set_empty. > > Whoops. =A0Pity we don't turn on the relevant compiler warning, > baseaddr is never read. =A0This is OK. Thanks. I'll add it to the 7.1 branch too.