From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17071 invoked by alias); 9 Feb 2010 00:38:39 -0000 Received: (qmail 17050 invoked by uid 22791); 9 Feb 2010 00:38:37 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 09 Feb 2010 00:38:30 +0000 Received: from kpbe15.cbf.corp.google.com (kpbe15.cbf.corp.google.com [172.25.105.79]) by smtp-out.google.com with ESMTP id o190cS62018207 for ; Mon, 8 Feb 2010 16:38:28 -0800 Received: from ewy23 (ewy23.prod.google.com [10.241.103.23]) by kpbe15.cbf.corp.google.com with ESMTP id o190bdra002557 for ; Mon, 8 Feb 2010 16:38:27 -0800 Received: by ewy23 with SMTP id 23so23720ewy.24 for ; Mon, 08 Feb 2010 16:38:27 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.186.12 with SMTP id v12mr1088892wem.75.1265675906827; Mon, 08 Feb 2010 16:38:26 -0800 (PST) In-Reply-To: References: <4B630D3F.8010507@redhat.com> <4B673929.9040900@redhat.com> Date: Tue, 09 Feb 2010 00:38:00 -0000 Message-ID: Subject: Re: [patch] Add namespace aliasing support. From: Doug Evans To: tromey@redhat.com, Sami Wagiaalla Cc: gdb-patches Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-02/txt/msg00242.txt.bz2 On Tue, Feb 2, 2010 at 11:23 AM, Tom Tromey wrote: >>>>>> "Sami" =3D=3D Sami Wagiaalla writes: > > Sami> 2010-02-01 =A0Sami Wagiaalla =A0 > Sami> =A0 =A0* cp-support.h: Added char* alias element to using_direct da= ta > Sami> =A0 =A0struct. > > I noticed that an earlier ChangeLog entry of yours (in testsuite) had 4 > leading spaces rather than a tab. =A0This one seems to have the same > problem, at least if you cut-and-pasted it; please fix before > committing. > > Also, put the PR number into the ChangeLog entry and the commit. =A0You > can see the existing ChangeLog for some examples of the formatting. > Putting it in the ChangeLog just makes the entry a little more useful; > putting it into the commit message will make some info about the commit > be automatically appended to the PR. > > Sami> + =A0 scope. =A0If ALIAS is an empty string then the namespace is k= nown by its > Sami> + =A0 original name. > > This should say something like: =A0If ALIAS is not null, then ... > > Sami> + =A0 of the list. =A0ALIAS is set to a non empty string if the imp= orted namespace > Sami> + =A0 has been aliased. > > Likewise. > > This patch is ok with those things fixed. =A0Thanks. > > Tom > Sorry for coming into this late. NEWS entry? [I mention it because I find the NEWS file really useful.]