From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24225 invoked by alias); 12 Jan 2010 23:08:16 -0000 Received: (qmail 24212 invoked by uid 22791); 12 Jan 2010 23:08:16 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 12 Jan 2010 23:08:11 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id o0CN88Hw021397 for ; Tue, 12 Jan 2010 23:08:08 GMT Received: from ey-out-2122.google.com (eye22.prod.google.com [10.208.5.22]) by wpaz1.hot.corp.google.com with ESMTP id o0CN8651002895 for ; Tue, 12 Jan 2010 15:08:07 -0800 Received: by ey-out-2122.google.com with SMTP id 22so4389971eye.11 for ; Tue, 12 Jan 2010 15:08:06 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.88.15 with SMTP id z15mr1099284wee.113.1263337686228; Tue, 12 Jan 2010 15:08:06 -0800 (PST) In-Reply-To: References: <200912171533.21699.pedro@codesourcery.com> <201001120001.08384.vladimir@codesourcery.com> <201001112122.08451.pedro@codesourcery.com> <201001130043.45256.vladimir@codesourcery.com> Date: Tue, 12 Jan 2010 23:08:00 -0000 Message-ID: Subject: Re: [MI] core awareness From: Doug Evans To: Vladimir Prus Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-01/txt/msg00320.txt.bz2 On Tue, Jan 12, 2010 at 2:56 PM, Doug Evans wrote: > On Tue, Jan 12, 2010 at 1:43 PM, Vladimir Prus > wrote: >> Thanks. Here's the version I've just checked in. Differs from above in: >> >> =A0 =A0 =A0 =A0- mi-support.exp fix to make it not crash on the 'core' f= ield >> =A0 =A0 =A0 =A0- demand_private_info now initialized 'extra' to 0, and d= oes not rely >> =A0 =A0 =A0 =A0 =A0on luck. > > Hi. > > Nit: features/threads.dtd didn't get checked in. > Sorry, one more nit. I'm getting a build failure: cc1: warnings being treated as errors ../../../src/gdb/mi/mi-main.c: In function 'mi_cmd_list_thread_groups': ../../../src/gdb/mi/mi-main.c:518: warning: 'tree' may be used uninitialized in this function ../../../src/gdb/mi/mi-main.c:518: note: 'tree' was declared here make: *** [mi-main.o] Error 1 Checked in as obvious. 2010-01-12 Doug Evans * mi/mi-main.c (list_available_thread_groups): Avoid "may be used uninitialized" warning from gcc on local `tree'. Index: mi/mi-main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /cvs/src/src/gdb/mi/mi-main.c,v retrieving revision 1.162 diff -u -p -r1.162 mi-main.c --- mi/mi-main.c 12 Jan 2010 21:40:24 -0000 1.162 +++ mi/mi-main.c 12 Jan 2010 23:00:51 -0000 @@ -513,9 +513,10 @@ list_available_thread_groups (VEC (int) struct osdata_item *item; int ix_items; /* This keeps a map from integer (pid) to VEC (struct osdata_item *)* - The vector contains information about all threads for the given - pid. */ - splay_tree tree; + The vector contains information about all threads for the given pid. + This is assigned an initial value to avoid "may be used uninitialized" + warning from gcc. */ + splay_tree tree =3D NULL; /* get_osdata will throw if it cannot return data. */ data =3D get_osdata ("processes");