From: Doug Evans <dje@google.com>
To: Paul Pluzhnikov <ppluzhnikov@google.com>
Cc: tromey@redhat.com, gdb-patches@sourceware.org
Subject: Re: [RFA] Handle older iconv programs
Date: Fri, 11 Dec 2009 21:06:00 -0000 [thread overview]
Message-ID: <e394668d0912111306t2d3c0f18s36e7953fbe3de0a0@mail.gmail.com> (raw)
In-Reply-To: <8ac60eac0912111303h5ae32fbbk3ad1851e584deddf@mail.gmail.com>
On Fri, Dec 11, 2009 at 1:03 PM, Paul Pluzhnikov <ppluzhnikov@google.com> wrote:
> On Mon, Dec 7, 2009 at 12:36 PM, Tom Tromey <tromey@redhat.com> wrote:
>>>>>>> "Doug" == Doug Evans <dje@google.com> writes:
>>
>> Doug> + set_in_environ (iconv_env, "LANGUAGE", "en");
>>
>> I think "C" would be preferable here.
>> Or, just remove LANGUAGE from the environment.
>
> I am seeing a crash which I think directly relates to this patch:
>
> (top) r
> [Thread debugging using libthread_db enabled]
> Using host libthread_db library "/usr/grte/v1/lib64/libthread_db.so.1".
>
> Program received signal SIGSEGV, Segmentation fault.
> *__GI_getenv (name=0x7ffff6cb8f85 "NGUAGE") at ../sysdeps/generic/getenv.c:93
> 93 if (name_start == ep_start && !strncmp (*ep + 2, name, len)
For reference sake, have you applied the accompanying patch to libiberty?
2009-12-07 Doug Evans <dje@google.com>
* pex-unix.c (pex_unix_exec_child): Save/restore environ.
next prev parent reply other threads:[~2009-12-11 21:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-07 17:57 Doug Evans
2009-12-07 20:36 ` Tom Tromey
2009-12-11 21:03 ` Paul Pluzhnikov
2009-12-11 21:06 ` Doug Evans [this message]
2009-12-11 21:35 ` Paul Pluzhnikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0912111306t2d3c0f18s36e7953fbe3de0a0@mail.gmail.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=ppluzhnikov@google.com \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox