From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16636 invoked by alias); 7 Dec 2009 21:37:22 -0000 Received: (qmail 16628 invoked by uid 22791); 7 Dec 2009 21:37:21 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 07 Dec 2009 21:37:13 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id nB7Lb8GR013948 for ; Mon, 7 Dec 2009 21:37:08 GMT Received: from ewy25 (ewy25.prod.google.com [10.241.103.25]) by zps77.corp.google.com with ESMTP id nB7Lb4Ci001546 for ; Mon, 7 Dec 2009 13:37:05 -0800 Received: by ewy25 with SMTP id 25so3798109ewy.5 for ; Mon, 07 Dec 2009 13:37:04 -0800 (PST) MIME-Version: 1.0 Received: by 10.216.86.7 with SMTP id v7mr2607106wee.203.1260221824195; Mon, 07 Dec 2009 13:37:04 -0800 (PST) In-Reply-To: <200912072055.nB7KtJvv001760@greed.delorie.com> References: <20091207172641.398198456F@ruffy.mtv.corp.google.com> <200912072009.nB7K9moj000406@greed.delorie.com> <200912072055.nB7KtJvv001760@greed.delorie.com> Date: Mon, 07 Dec 2009 21:37:00 -0000 Message-ID: Subject: Re: [RFA] save/restore environ in libiberty pex_unix_exec_child From: Doug Evans To: DJ Delorie Cc: gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-12/txt/msg00105.txt.bz2 On Mon, Dec 7, 2009 at 12:55 PM, DJ Delorie wrote: > > Hmm... my Linux doesn't even include execvpe(). > > Ok to check it in then, but *please* include a comment documenting the > assumption that the parent won't run until the child is done. > Thanks. I'm always for more comments explaining why things are the way they are.