From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7454 invoked by alias); 30 Nov 2009 17:44:57 -0000 Received: (qmail 7444 invoked by uid 22791); 30 Nov 2009 17:44:56 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 30 Nov 2009 17:44:50 +0000 Received: from zps19.corp.google.com (zps19.corp.google.com [172.25.146.19]) by smtp-out.google.com with ESMTP id nAUHim8Y013515 for ; Mon, 30 Nov 2009 09:44:48 -0800 Received: from qyk2 (qyk2.prod.google.com [10.241.83.130]) by zps19.corp.google.com with ESMTP id nAUHijo7005863 for ; Mon, 30 Nov 2009 09:44:45 -0800 Received: by qyk2 with SMTP id 2so1675861qyk.21 for ; Mon, 30 Nov 2009 09:44:45 -0800 (PST) MIME-Version: 1.0 Received: by 10.224.13.66 with SMTP id b2mr2267668qaa.370.1259603084506; Mon, 30 Nov 2009 09:44:44 -0800 (PST) In-Reply-To: <20091129205707.GA9408@host0.dyn.jankratochvil.net> References: <20091129205707.GA9408@host0.dyn.jankratochvil.net> Date: Mon, 30 Nov 2009 17:44:00 -0000 Message-ID: Subject: Re: [patch] Fix build if using --with-system-readline From: Doug Evans To: Jan Kratochvil Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-11/txt/msg00600.txt.bz2 On Sun, Nov 29, 2009 at 12:57 PM, Jan Kratochvil wrote: > Hi, > > ./configure --enable-targets=3Dall --with-system-readline; make > -> > gcc -g -O2 =A0 -I. -I. -I./common -I./config -DLOCALEDIR=3D"\"/usr/local/= share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode =A0-I../bfd -I./../bf= d -I./../include -I../libdecnumber -I./../libdecnumber =A0-I./gnulib -Ignul= ib =A0-DMI_OUT=3D1 -DTUI=3D1 =A0 -Wall -Wdeclaration-after-statement -Wpoin= ter-arith -Wformat-nonliteral -Wno-pointer-sign -Wno-unused -Wunused-value = -Wno-switch -Wno-char-subscripts -Werror -c -o frv-tdep.o -MT frv-tdep.o -M= MD -MP -MF .deps/frv-tdep.Tpo frv-tdep.c > frv-tdep.c:35:60: error: opcodes/frv-desc.h: No such file or directory > > (it is not `make -j' race) > > because with --with-system-readline there is no: > =A0 =A0 =A0 =A0-I./../readline/.. > > OK to check-in? > > > Thanks, > Jan > > > gdb/ > 2009-11-29 =A0Jan Kratochvil =A0 > > =A0 =A0 =A0 =A0Fix build if using --with-system-readline. > =A0 =A0 =A0 =A0* Makefile.in (OPCODES_CFLAGS): Add `-I$(OPCODES_DIR)/..'. > > --- a/gdb/Makefile.in > +++ b/gdb/Makefile.in > @@ -301,7 +301,7 @@ OPCODES =3D $(OPCODES_DIR)/libopcodes.a > =A0# Where are the other opcode tables which only have header file > =A0# versions? > =A0OP_INCLUDE =3D $(INCLUDE_DIR)/opcode > -OPCODES_CFLAGS =3D -I$(OP_INCLUDE) > +OPCODES_CFLAGS =3D -I$(OP_INCLUDE) -I$(OPCODES_DIR)/.. > > =A0# The simulator is usually nonexistent; targets that include one > =A0# should set this to list all the .o or .a files to be linked in. > That is the easiest patch, and it doesn't actually change anything since we're already building with (effectively) -I$(srcdir). So it's ok with me. I'd wait a bit to see if anyone else wants to speak up. Having said that, -I$(srcdir) "feels" less clean than -I$(OPCODES_DIR). We have -$(BFD_SRC) already, it seems like opcodes should be treated no different. I realize going this route involves more work, fixing all the files that do #include "opcodes/mumble.h", there's only a handful of them though. I'd skip putting in the effort to go this route until someone else agrees.