Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Doug Evans <dje@google.com>
To: Pedro Alves <pedro@codesourcery.com>
Cc: Paul Pluzhnikov <ppluzhnikov@google.com>, gdb-patches@sourceware.org
Subject: Re: [patch] Fix for internal-error: linux_nat_post_attach_wait:  	Assertion `pid == new_pid && WIFSTOPPED (status)' failed.
Date: Thu, 15 Oct 2009 02:17:00 -0000	[thread overview]
Message-ID: <e394668d0910141916i696cd8bm15a285da34c67344@mail.gmail.com> (raw)
In-Reply-To: <200910142329.06920.pedro@codesourcery.com>

On Wed, Oct 14, 2009 at 3:29 PM, Pedro Alves <pedro@codesourcery.com> wrote:
> Something else I noticed:
>
>> +         int signo = WTERMSIG (status);
>
> Should be:
>
>        enum target_signal signo = target_signal_from_host (WTERMSIG (status));
>
>> +
>> +         target_terminal_ours ();
>> +         target_mourn_inferior ();
>> +         error (_("During startup program terminated with signal %s, %s."),
>> +                target_signal_to_name (signo),
>> +                target_signal_to_string (signo));
>
>                   ^^^^^^^^^^^^^^^^^^^^^^^
>
> because these functions take a target independent gdb
> signal (TARGET_SIGNAL_...).  Yes, it's confusing.

These kinds of errors should be caught by the compilation system or language.
Then it wouldn't be confusing at all.


  reply	other threads:[~2009-10-15  2:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-13 18:41 Paul Pluzhnikov
2009-10-13 20:53 ` Pedro Alves
2009-10-14 18:21   ` Paul Pluzhnikov
2009-10-14 19:08     ` Pedro Alves
2009-10-14 21:01       ` Paul Pluzhnikov
2009-10-14 21:16         ` Pedro Alves
2009-10-14 21:28           ` Paul Pluzhnikov
2009-10-14 22:29             ` Pedro Alves
2009-10-15  2:17               ` Doug Evans [this message]
2009-10-15 18:10               ` Paul Pluzhnikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e394668d0910141916i696cd8bm15a285da34c67344@mail.gmail.com \
    --to=dje@google.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@codesourcery.com \
    --cc=ppluzhnikov@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox