From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-66148-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 16188 invoked by alias); 21 Aug 2009 19:15:01 -0000
Received: (qmail 16180 invoked by uid 22791); 21 Aug 2009 19:15:00 -0000
X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 	tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 21 Aug 2009 19:14:54 +0000
Received: from spaceape8.eur.corp.google.com (spaceape8.eur.corp.google.com [172.28.16.142]) 	by smtp-out.google.com with ESMTP id n7LJEpek020682 	for <gdb-patches@sourceware.org>; Fri, 21 Aug 2009 20:14:51 +0100
Received: from ywh13 (ywh13.prod.google.com [10.192.8.13]) 	by spaceape8.eur.corp.google.com with ESMTP id n7LJEmGC031269 	for <gdb-patches@sourceware.org>; Fri, 21 Aug 2009 12:14:49 -0700
Received: by ywh13 with SMTP id 13so1180848ywh.15         for <gdb-patches@sourceware.org>; Fri, 21 Aug 2009 12:14:48 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.150.45.12 with SMTP id s12mr2844371ybs.104.1250882088108; Fri,  	21 Aug 2009 12:14:48 -0700 (PDT)
In-Reply-To: <200908211859.04340.ken@linux.vnet.ibm.com>
References: <9a9942200907221615o570e749fh5cb186c1600f159c@mail.gmail.com> 	 <200908211236.n7LCZuxn016229@d06av01.portsmouth.uk.ibm.com> 	 <e394668d0908210817u43d43bck359ee679c5f79570@mail.gmail.com> 	 <200908211859.04340.ken@linux.vnet.ibm.com>
Date: Fri, 21 Aug 2009 19:53:00 -0000
Message-ID: <e394668d0908211214u414dbd76te7c0688a476ce6bb@mail.gmail.com>
Subject: Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed  	code
From: Doug Evans <dje@google.com>
To: Ken Werner <ken@linux.vnet.ibm.com>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
X-System-Of-Record: true
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-08/txt/msg00347.txt.bz2

On Fri, Aug 21, 2009 at 9:59 AM, Ken Werner<ken@linux.vnet.ibm.com> wrote:
>> > Hi,
>> > I noticed the gdb build fails on ppc64 if -Werror is used:
>> > =A0gdb/jit.c: In function 'jit_event_handler':
>> > =A0gdb/jit.c:417: warning: cast to pointer from integer of different s=
ize
>> > The attached patch uses paddress for printing the address.
>> >
>> > -ken
>>
>> Heh. =A0Thanks.
>> Can you check it in? =A0If not I can for you.
>
> Please go ahead since I do not have commit privileges.
> Thanks.
> -ken
>

I committed this change.

2009-08-21  Ken Werner <ken@linux.vnet.ibm.com>
            Doug Evans  <dje@google.com>

        * jit.c (jit_event_handler): Use paddress to print target addresses.
        Wrap printf string in _().

Index: jit.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
RCS file: /cvs/src/src/gdb/jit.c,v
retrieving revision 1.2
diff -u -p -r1.2 jit.c
--- jit.c       21 Aug 2009 18:54:44 -0000      1.2
+++ jit.c       21 Aug 2009 19:03:58 -0000
@@ -436,8 +436,8 @@ jit_event_handler (struct gdbarch *gdbar
     case JIT_UNREGISTER:
       objf =3D jit_find_objf_with_entry_addr (entry_addr);
       if (objf =3D=3D NULL)
-        printf_unfiltered ("Unable to find JITed code entry at address: %p=
\n",
-                           (void *) entry_addr);
+       printf_unfiltered (_("Unable to find JITed code entry at
address: %s\n"),
+                          paddress (gdbarch, entry_addr));
       else
         jit_unregister_code (objf);