Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code

Thiago Jung Bauermann
2009-08-01T14:43:53Z

Em Sexta-feira 31 Julho 2009 15:17:24 Reid Kleckner escreveu:
> On Fri, Jul 31, 2009 at 8:01 AM, Thiago Jung
> > I still think that the patch needs to be tested with a core file scenario
> > before it is checked in. Since said scenario is similar to attaching to a
> > running process, it will likely magically work, though.
>
> Well, it didn't magically work because the jit_inferior_create_hook
> was getting called twice for core files instead of once. What would
> happen is that the binary would get loaded, the hook called, there
> would be no debug info, the memory would get loaded, it would get
> called again, and it would think that it already read the descriptor.
> So I made it look for new code every time just in case, and now it
> works.

That's great. Thanks for fixing this issue.

> Here's an updated patch. What else needs to be dealt with?

Looks like it just needs the blessing from the GDB powers that be, now.
--
[]'s
Thiago Jung Bauermann