Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code

Doug Evans
2009-08-21T19:15:01Z

On Fri, Aug 21, 2009 at 9:59 AM, Ken Werner<ken@linux.vnet.ibm.com> wrote:
>> > Hi,
>> > I noticed the gdb build fails on ppc64 if -Werror is used:
>> >  gdb/jit.c: In function 'jit_event_handler':
>> >  gdb/jit.c:417: warning: cast to pointer from integer of different size
>> > The attached patch uses paddress for printing the address.
>> >
>> > -ken
>>
>> Heh.  Thanks.
>> Can you check it in?  If not I can for you.
>
> Please go ahead since I do not have commit privileges.
> Thanks.
> -ken
>

I committed this change.

2009-08-21 Ken Werner <ken@linux.vnet.ibm.com>
Doug Evans <dje@google.com>

* jit.c (jit_event_handler): Use paddress to print target addresses.
Wrap printf string in _().

Index: jit.c
===================================================================
RCS file: /cvs/src/src/gdb/jit.c,v
retrieving revision 1.2
diff -u -p -r1.2 jit.c
--- jit.c 21 Aug 2009 18:54:44 -0000 1.2
+++ jit.c 21 Aug 2009 19:03:58 -0000
@@ -436,8 +436,8 @@ jit_event_handler (struct gdbarch *gdbar
case JIT_UNREGISTER:
objf = jit_find_objf_with_entry_addr (entry_addr);
if (objf == NULL)
- printf_unfiltered ("Unable to find JITed code entry at address: %p\n",
- (void *) entry_addr);
+ printf_unfiltered (_("Unable to find JITed code entry at
address: %s\n"),
+ paddress (gdbarch, entry_addr));
else
jit_unregister_code (objf);