Re: [unladen-swallow] Re: [RFA] Add interface for registering JITed code

Ken Werner
2009-08-21T12:36:17Z

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

Doug Evans wrote:

> On Mon, Aug 17, 2009 at 8:29 AM, Tom Tromey<tromey@redhat.com> wrote:
>>>>>>> "Reid" == Reid Kleckner <rnk@google.com> writes:
>>
>> Tom> I read it a few more times and nothing popped out at me.
>>
>> Reid> Is it OK if Doug commits it then?
>>
>> Yes.
>>
>> Tom
>>
>
> Committed. Thanks.

Hi,
I noticed the gdb build fails on ppc64 if -Werror is used:
gdb/jit.c: In function 'jit_event_handler':
gdb/jit.c:417: warning: cast to pointer from integer of different size
The attached patch uses paddress for printing the address.

-ken

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: gdb-jit.patch --]
[-- Type: text/x-patch; name="gdb-jit.patch", Size: 709 bytes --]

Index: gdb/jit.c
===================================================================
RCS file: /cvs/src/src/gdb/jit.c,v
retrieving revision 1.1
diff -u -r1.1 jit.c
--- gdb/jit.c 20 Aug 2009 18:02:47 -0000 1.1
+++ gdb/jit.c 21 Aug 2009 12:27:13 -0000
@@ -413,8 +413,8 @@
case JIT_UNREGISTER:
objf = jit_find_objf_with_entry_addr (entry_addr);
if (objf == NULL)
- printf_unfiltered ("Unable to find JITed code entry at address: %p\n",
- (void *) entry_addr);
+ printf_unfiltered ("Unable to find JITed code entry at address: %s\n",
+ paddress (target_gdbarch, entry_addr));
else
jit_unregister_code (objf);