From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21445 invoked by alias); 21 Jul 2009 01:33:56 -0000 Received: (qmail 21436 invoked by uid 22791); 21 Jul 2009 01:33:56 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 21 Jul 2009 01:33:46 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id n6L1XiwG011515 for ; Mon, 20 Jul 2009 18:33:44 -0700 Received: from fxm19 (fxm19.prod.google.com [10.184.13.19]) by wpaz5.hot.corp.google.com with ESMTP id n6L1XfT0009288 for ; Mon, 20 Jul 2009 18:33:42 -0700 Received: by fxm19 with SMTP id 19so2348463fxm.2 for ; Mon, 20 Jul 2009 18:33:41 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.1.17 with SMTP id d17mr2520263mui.60.1248140021211; Mon, 20 Jul 2009 18:33:41 -0700 (PDT) In-Reply-To: <4A6167BD.7080804@redhat.com> References: <4A610157.10201@redhat.com> <4A6167BD.7080804@redhat.com> Date: Tue, 21 Jul 2009 03:19:00 -0000 Message-ID: Subject: Re: [RFA] Fix double free From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00502.txt.bz2 On Fri, Jul 17, 2009 at 11:12 PM, Keith Seitz wrote: > On 07/17/2009 08:08 PM, Doug Evans wrote: >> >> The problem occurs twice in reverse_search_command as well. > > Indeed it does! I did not even look! > > Updated patch attached. > > Keith > > ChangeLog > 2009-07-17 =A0Keith Seitz =A0 > > =A0 =A0 =A0 =A0* source.c (forward_search_command): Don't fclose the stre= am, > =A0 =A0 =A0 =A0just run the cleanups. > =A0 =A0 =A0 =A0(reverse_search_command): Likewise. > "works for me". Thanks, please check in. [Heh, after this many years it's weird saying that.]