From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7638 invoked by alias); 20 Jul 2009 21:06:20 -0000 Received: (qmail 7603 invoked by uid 22791); 20 Jul 2009 21:06:17 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 20 Jul 2009 21:06:08 +0000 Received: from spaceape9.eur.corp.google.com (spaceape9.eur.corp.google.com [172.28.16.143]) by smtp-out.google.com with ESMTP id n6KL647i007507; Mon, 20 Jul 2009 22:06:04 +0100 Received: from fxm24 (fxm24.prod.google.com [10.184.13.24]) by spaceape9.eur.corp.google.com with ESMTP id n6KL5rYv023837; Mon, 20 Jul 2009 14:06:02 -0700 Received: by fxm24 with SMTP id 24so2238638fxm.39 for ; Mon, 20 Jul 2009 14:06:02 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.214.4 with SMTP id r4mr2476976muq.35.1248123962076; Mon, 20 Jul 2009 14:06:02 -0700 (PDT) In-Reply-To: <20090716205428.8CCBB846E6@localhost> References: <20090716205428.8CCBB846E6@localhost> Date: Mon, 20 Jul 2009 23:57:00 -0000 Message-ID: Subject: Re: [RFA] Add dwarf4 values to include/dwarf2.h From: Doug Evans To: binutils@sourceware.org, gcc-patches@gcc.gnu.org Cc: gdb-patches@sourceware.org, ccoutant@google.com, Tom Tromey Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00498.txt.bz2 On Thu, Jul 16, 2009 at 1:54 PM, Doug Evans wrote: > Hi. > > This patch adds various dwarf4 elements, plus DW_AT_GNU_odr_signature, > to include/dwarf2.h. > > Ok to check in? > > [I have a gdb patch that's ready to go in to support "comdat types". > And this will also be needed for the gcc side, which is currently > on the dwarf4 branch.] > > 2009-07-15 =A0Doug Evans =A0 > =A0 =A0 =A0 =A0 =A0 =A0Cary Coutant =A0 > > =A0 =A0 =A0 =A0* dwarf2.h (enum dwarf_tag): Add DW_TAG_type_unit. > =A0 =A0 =A0 =A0(enum dwarf_form): Add DW_FORM_sec_offset, DW_FORM_exprloc, > =A0 =A0 =A0 =A0DW_FORM_flag_present, DW_FORM_sig8. > =A0 =A0 =A0 =A0(enum dwarf_attribute): Add DW_AT_signature, DW_AT_GNU_odr= _signature. > > diff -u -p -r1.2 dwarf2.h > --- dwarf2.h =A0 =A09 Jul 2009 21:01:15 -0000 =A0 =A0 =A0 1.2 > +++ dwarf2.h =A0 =A014 Jul 2009 23:22:35 -0000 > @@ -194,6 +194,8 @@ enum dwarf_tag > =A0 =A0 DW_TAG_imported_unit =3D 0x3d, > =A0 =A0 DW_TAG_condition =3D 0x3f, > =A0 =A0 DW_TAG_shared_type =3D 0x40, > + =A0 =A0/* DWARF 4. =A0*/ > + =A0 =A0DW_TAG_type_unit =3D 0x41, > > =A0 =A0 DW_TAG_lo_user =3D 0x4080, > =A0 =A0 DW_TAG_hi_user =3D 0xffff, > @@ -244,7 +246,12 @@ enum dwarf_form > =A0 =A0 DW_FORM_ref4 =3D 0x13, > =A0 =A0 DW_FORM_ref8 =3D 0x14, > =A0 =A0 DW_FORM_ref_udata =3D 0x15, > - =A0 =A0DW_FORM_indirect =3D 0x16 > + =A0 =A0DW_FORM_indirect =3D 0x16, > + =A0 =A0/* DWARF 4. =A0*/ > + =A0 =A0DW_FORM_sec_offset =3D 0x17, > + =A0 =A0DW_FORM_exprloc =3D 0x18, > + =A0 =A0DW_FORM_flag_present =3D 0x19, > + =A0 =A0DW_FORM_sig8 =3D 0x20 > =A0 }; > > =A0/* Attribute names and codes. =A0*/ > @@ -342,6 +349,8 @@ enum dwarf_attribute > =A0 =A0 DW_AT_elemental =A0 =A0 =3D 0x66, > =A0 =A0 DW_AT_pure =A0 =A0 =A0 =A0 =A0=3D 0x67, > =A0 =A0 DW_AT_recursive =A0 =A0 =3D 0x68, > + =A0 =A0/* DWARF 4 values. =A0*/ > + =A0 =A0DW_AT_signature =A0 =A0 =3D 0x69, > > =A0 =A0 DW_AT_lo_user =3D 0x2000, =A0 =A0/* Implementation-defined range = start. =A0*/ > =A0 =A0 DW_AT_hi_user =3D 0x3ff0, =A0 =A0/* Implementation-defined range = end. =A0*/ > @@ -381,6 +390,7 @@ enum dwarf_attribute > =A0 =A0 DW_AT_body_begin =3D 0x2105, > =A0 =A0 DW_AT_body_end =A0 =3D 0x2106, > =A0 =A0 DW_AT_GNU_vector =3D 0x2107, > + =A0 =A0DW_AT_GNU_odr_signature =3D 0x210f, > =A0 =A0 /* VMS extensions. =A0*/ > =A0 =A0 DW_AT_VMS_rtnbeg_pd_address =3D 0x2201, > =A0 =A0 /* UPC extension. =A0*/ > > Hi. I checked this into both gcc/binutils trees, without DW_AT_GNU_odr_signatur= e. [approved by Ian off-list]