From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5609 invoked by alias); 18 Jul 2009 03:08:34 -0000 Received: (qmail 5601 invoked by uid 22791); 18 Jul 2009 03:08:34 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 18 Jul 2009 03:08:26 +0000 Received: from spaceape12.eur.corp.google.com (spaceape12.eur.corp.google.com [172.28.16.146]) by smtp-out.google.com with ESMTP id n6I38NBf024058 for ; Sat, 18 Jul 2009 04:08:23 +0100 Received: from fxm2 (fxm2.prod.google.com [10.184.13.2]) by spaceape12.eur.corp.google.com with ESMTP id n6I38Kb4017901 for ; Fri, 17 Jul 2009 20:08:21 -0700 Received: by fxm2 with SMTP id 2so1141298fxm.13 for ; Fri, 17 Jul 2009 20:08:20 -0700 (PDT) MIME-Version: 1.0 Received: by 10.103.1.17 with SMTP id d17mr896661mui.60.1247886500626; Fri, 17 Jul 2009 20:08:20 -0700 (PDT) In-Reply-To: <4A610157.10201@redhat.com> References: <4A610157.10201@redhat.com> Date: Sat, 18 Jul 2009 06:12:00 -0000 Message-ID: Subject: Re: [RFA] Fix double free From: Doug Evans To: Keith Seitz Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-07/txt/msg00445.txt.bz2 On Fri, Jul 17, 2009 at 3:55 PM, Keith Seitz wrote: > Hi, > > An insight user (yes, there are still a few of us ;-) noticed that insight > would crash when using gdb's "search" command. Turns out this is a simple > cleanup buglet. I think it is easier to read the patch than explain, so I= 'll > leave it at that. > > Ok? > Keith > > ChangeLog > 2009-07-17 =A0Keith Seitz =A0 > > =A0 =A0 =A0 =A0* source.c (forward_search_command): Don't fclose the stre= am, > =A0 =A0 =A0 =A0just run the cleanups. Hi. Looks right to me. The problem occurs twice in reverse_search_command as well.