From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 20933 invoked by alias); 24 Jun 2009 19:01:28 -0000 Received: (qmail 20527 invoked by uid 22791); 24 Jun 2009 19:01:24 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 24 Jun 2009 19:01:17 +0000 Received: from wpaz21.hot.corp.google.com (wpaz21.hot.corp.google.com [172.24.198.85]) by smtp-out.google.com with ESMTP id n5OJ1Fdm011780 for ; Wed, 24 Jun 2009 12:01:15 -0700 Received: from yxe36 (yxe36.prod.google.com [10.190.2.36]) by wpaz21.hot.corp.google.com with ESMTP id n5OJ0nov027397 for ; Wed, 24 Jun 2009 12:01:13 -0700 Received: by yxe36 with SMTP id 36so1523500yxe.13 for ; Wed, 24 Jun 2009 12:01:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.35.9 with SMTP id i9mr1289281agi.121.1245870072749; Wed, 24 Jun 2009 12:01:12 -0700 (PDT) In-Reply-To: <4A427584.2090908@qnx.com> References: <200906222346.54263.pedro@codesourcery.com> <4A40F226.4080909@qnx.com> <200906231700.12402.pedro@codesourcery.com> <4A427584.2090908@qnx.com> Date: Wed, 24 Jun 2009 19:01:00 -0000 Message-ID: Subject: Re: [patch] gdbserver: Add support for Z0/Z1 packets From: Doug Evans To: Aleksandar Ristovski Cc: gdb-patches@sourceware.org, Pedro Alves Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00653.txt.bz2 On Wed, Jun 24, 2009 at 11:50 AM, Aleksandar Ristovski wrote: > I did not do any renaming - I think it is not terribly confusing since both > in target.h comment and server.c 'Z' case it is made very clear that it > handles both breakpoints and watchpoints (i.e. I don't find it any clearer > if it was called "insert_point"... it would still require reading the > comment in target.h) fwiw, I think the naming is important. People come at the source from various angles, starting points, and contexts. I can imagine someone getting tripped up (i.e. spending time doing something that they otherwise wouldn't have) by reading "insert_watchpoint" and not knowing it also applied to breakpoints. Good names are important. (or at least not obviously problematic names; picking good names is sometimes hard, for me anyway). My $0.02.