From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22908 invoked by alias); 13 Jun 2009 14:52:23 -0000 Received: (qmail 22897 invoked by uid 22791); 13 Jun 2009 14:52:23 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sat, 13 Jun 2009 14:52:16 +0000 Received: from spaceape7.eur.corp.google.com (spaceape7.eur.corp.google.com [172.28.16.141]) by smtp-out.google.com with ESMTP id n5DEqCh0006051 for ; Sat, 13 Jun 2009 15:52:13 +0100 Received: from yw-out-1718.google.com (ywa6.prod.google.com [10.192.1.6]) by spaceape7.eur.corp.google.com with ESMTP id n5DEq9pC012302 for ; Sat, 13 Jun 2009 07:52:10 -0700 Received: by yw-out-1718.google.com with SMTP id 6so1488052ywa.38 for ; Sat, 13 Jun 2009 07:52:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.91.9 with SMTP id o9mr1910463agb.82.1244904729683; Sat, 13 Jun 2009 07:52:09 -0700 (PDT) In-Reply-To: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr> References: <001201c9ebb1$96414b10$c2c3e130$@u-strasbg.fr> Date: Sat, 13 Jun 2009 14:52:00 -0000 Message-ID: Subject: Re: [RFC] Improve testsuite for poor expect behavior From: Doug Evans To: Pierre Muller Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-06/txt/msg00358.txt.bz2 On Fri, Jun 12, 2009 at 5:00 PM, Pierre Muller wro= te: > =A0I am trying to run the testsuite in a cygwin environment, > but for mingw32 or djgpp targets, using native builds of GDB. > > [...] > > 2009-06-12 =A0Pierre Muller =A0 > > =A0 =A0 =A0 =A0* lib/gdb.exp (fuzzy_newline): New global. > =A0 =A0 =A0 =A0(input_not_from_terminal): New global. > =A0 =A0 =A0 =A0(gdb_input_not_from_terminal): New procedure. > =A0 =A0 =A0 =A0(gdb_proc_unload): Add pattern corresponding to automated = answer > =A0 =A0 =A0 =A0if not from terminal. > =A0 =A0 =A0 =A0(delete_breakpoints): Likewise. > =A0 =A0 =A0 =A0(gdb_run_mcd): Likewise. > =A0 =A0 =A0 =A0(gdb_start_cmd): Likewise. > =A0 =A0 =A0 =A0(gdb_internal_error_resync): Likewise. > =A0 =A0 =A0 =A0(gdb_reinitialize_dir): Likewise. > =A0 =A0 =A0 =A0(default_gdb_exit): Likewise. > =A0 =A0 =A0 =A0(gdb_file_cmd): Likewise. > =A0 =A0 =A0 =A0(rerun_to_main): =A0Likewise. > =A0 =A0 =A0 =A0(gdb_compile): Also compile set_unbuffered_output > =A0 =A0 =A0 =A0for djgpp target. > =A0 =A0 =A0 =A0(gdb_expect): If fuzzy_newline is set, replace all "\r\n" > =A0 =A0 =A0 =A0by "\r+\n" in expcode. Hi. I went through the patch. It's fine with me, fwiw of course. [I didn't spend _too_ much time vetting the regsub's, but in principle it seems fine.]