From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27342 invoked by alias); 24 May 2009 17:35:58 -0000 Received: (qmail 27332 invoked by uid 22791); 24 May 2009 17:35:57 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Sun, 24 May 2009 17:35:50 +0000 Received: from wpaz29.hot.corp.google.com (wpaz29.hot.corp.google.com [172.24.198.93]) by smtp-out.google.com with ESMTP id n4OHZkkA009209 for ; Sun, 24 May 2009 18:35:47 +0100 Received: from gxk2 (gxk2.prod.google.com [10.202.11.2]) by wpaz29.hot.corp.google.com with ESMTP id n4OHZirS002956 for ; Sun, 24 May 2009 10:35:45 -0700 Received: by gxk2 with SMTP id 2so5062739gxk.3 for ; Sun, 24 May 2009 10:35:44 -0700 (PDT) MIME-Version: 1.0 Received: by 10.90.113.11 with SMTP id l11mr5437362agc.117.1243186544738; Sun, 24 May 2009 10:35:44 -0700 (PDT) In-Reply-To: <200905241747.58832.pedro@codesourcery.com> References: <20090507031109.0CBFB84890@localhost> <200905241747.58832.pedro@codesourcery.com> Date: Sun, 24 May 2009 17:35:00 -0000 Message-ID: Subject: Re: [RFA]: Clean up debug printing of pc in gdbserver From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=0016361e86c0638313046aabeca1 X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-05/txt/msg00533.txt.bz2 --0016361e86c0638313046aabeca1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-length: 2038 On Sun, May 24, 2009 at 9:47 AM, Pedro Alves wrote: > >> The debug printing of pc in linux-i386-low.c/linux-x86-64-low.c can >> use some clean up. >> >> - why restrict the printing to just x86? >> - the text that is printed for linux_resume_one_lwp is confusing >> >> Ok to check in? >> >> 2009-05-06 =A0Doug Evans =A0 >> >> =A0=A0=A0=A0=A0=A0=A0=A0* linux-x86-64-low.c (debug_threads): Remove dec= laration. >> =A0=A0=A0=A0=A0=A0=A0=A0(x86_64_get_pc,x86_64_set_pc): Remove debug prin= ting of pc. >> =A0=A0=A0=A0=A0=A0=A0=A0* linux-i386-low.c (debug_threads): Remove decla= ration. >> =A0=A0=A0=A0=A0=A0=A0=A0(i386_get_pc,i386_set_pc): Remove debug printing= of pc. >> =A0=A0=A0=A0=A0=A0=A0=A0* linux-low.c (get_stop_pc): Print pc if debug_t= hreads. >> =A0=A0=A0=A0=A0=A0=A0=A0(check_removed_breakpoint, linux_wait_for_lwp): = Ditto. >> =A0=A0=A0=A0=A0=A0=A0=A0(linux_resume_one_lwp): Ditto. > > Looks OK to me. =A0Small nit below. > > On Thursday 07 May 2009 04:11:08, Doug Evans wrote: >> =A0 =A0if (debug_threads >> - =A0 =A0 =A0&& WIFSTOPPED (*wstatp)) >> + =A0 =A0 =A0&& WIFSTOPPED (*wstatp) >> + =A0 =A0 =A0&& the_low_target.get_pc !=3D NULL) >> =A0 =A0 =A0{ >> =A0 =A0 =A0 =A0struct thread_info *saved_inferior =3D current_inferior; >> + =A0 =A0 =A0CORE_ADDR stop_pc =3D (*the_low_target.get_pc) (); >> =A0 =A0 =A0 =A0current_inferior =3D (struct thread_info *) >> =A0 =A0 =A0 =A0 find_inferior_id (&all_threads, child->head.id); >> - =A0 =A0 =A0/* For testing only; i386_stop_pc prints out a diagnostic. = =A0*/ >> - =A0 =A0 =A0if (the_low_target.get_pc !=3D NULL) >> - =A0 =A0 =A0 get_stop_pc (); >> + =A0 =A0 =A0fprintf (stderr, "linux_wait_for_lwp: pc is %08lx\n", (long= ) stop_pc); >> =A0 =A0 =A0 =A0current_inferior =3D saved_inferior; >> =A0 =A0 =A0} > > Can we rename that `stop_pc' variable to, say, `pc', so we're > consistent throughout? =A0We can think of the `stop_pc' as having > always the decr_pc_after_break adjustment applied. Thanks. Attached is what I checked in. --0016361e86c0638313046aabeca1 Content-Type: text/plain; charset=US-ASCII; name="gdb-090524-gdbserver-get-pc-3.patch.txt" Content-Disposition: attachment; filename="gdb-090524-gdbserver-get-pc-3.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fv414z8n0 Content-length: 3372 MjAwOS0wNS0wNiAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog bGludXgtbG93LmMgKGdldF9zdG9wX3BjKTogUHJpbnQgcGMgaWYgZGVidWdf dGhyZWFkcy4KCShjaGVja19yZW1vdmVkX2JyZWFrcG9pbnQsIGxpbnV4X3dh aXRfZm9yX2x3cCk6IERpdHRvLgoJKGxpbnV4X3Jlc3VtZV9vbmVfbHdwKTog RGl0dG8uCgpJbmRleDogbGludXgtbG93LmMKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3JjL2dkYi9nZGJzZXJ2ZXIvbGlu dXgtbG93LmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEuMTAzCmRpZmYgLXUg LXAgLXIxLjEwMyBsaW51eC1sb3cuYwotLS0gbGludXgtbG93LmMJMjQgTWF5 IDIwMDkgMDE6MDk6MjIgLTAwMDAJMS4xMDMKKysrIGxpbnV4LWxvdy5jCTI0 IE1heSAyMDA5IDE3OjI3OjEwIC0wMDAwCkBAIC0zNTQsMTAgKzM1NCwxMyBA QCBnZXRfc3RvcF9wYyAodm9pZCkKIHsKICAgQ09SRV9BRERSIHN0b3BfcGMg PSAoKnRoZV9sb3dfdGFyZ2V0LmdldF9wYykgKCk7CiAKLSAgaWYgKGdldF90 aHJlYWRfbHdwIChjdXJyZW50X2luZmVyaW9yKS0+c3RlcHBpbmcpCi0gICAg cmV0dXJuIHN0b3BfcGM7Ci0gIGVsc2UKLSAgICByZXR1cm4gc3RvcF9wYyAt IHRoZV9sb3dfdGFyZ2V0LmRlY3JfcGNfYWZ0ZXJfYnJlYWs7CisgIGlmICgh IGdldF90aHJlYWRfbHdwIChjdXJyZW50X2luZmVyaW9yKS0+c3RlcHBpbmcp CisgICAgc3RvcF9wYyAtPSB0aGVfbG93X3RhcmdldC5kZWNyX3BjX2FmdGVy X2JyZWFrOworCisgIGlmIChkZWJ1Z190aHJlYWRzKQorICAgIGZwcmludGYg KHN0ZGVyciwgInN0b3AgcGMgaXMgMHglbHhcbiIsIChsb25nKSBzdG9wX3Bj KTsKKworICByZXR1cm4gc3RvcF9wYzsKIH0KIAogc3RhdGljIHZvaWQgKgpA QCAtODE0LDcgKzgxNywxMSBAQCBjaGVja19yZW1vdmVkX2JyZWFrcG9pbnQg KHN0cnVjdCBsd3BfaW5mCiAgICAgIGRlY3JlbWVudC4gIFdlIGdvIGltbWVk aWF0ZWx5IGZyb20gdGhpcyBmdW5jdGlvbiB0byByZXN1bWluZywKICAgICAg YW5kIGNhbiBub3Qgc2FmZWx5IGNhbGwgZ2V0X3N0b3BfcGMgKCkgYWdhaW4u ICAqLwogICBpZiAodGhlX2xvd190YXJnZXQuc2V0X3BjICE9IE5VTEwpCi0g ICAgKCp0aGVfbG93X3RhcmdldC5zZXRfcGMpIChzdG9wX3BjKTsKKyAgICB7 CisgICAgICBpZiAoZGVidWdfdGhyZWFkcykKKwlmcHJpbnRmIChzdGRlcnIs ICJTZXQgcGMgdG8gMHglbHhcbiIsIChsb25nKSBzdG9wX3BjKTsKKyAgICAg ICgqdGhlX2xvd190YXJnZXQuc2V0X3BjKSAoc3RvcF9wYyk7CisgICAgfQog CiAgIC8qIFdlIGNvbnN1bWVkIHRoZSBwZW5kaW5nIFNJR1RSQVAuICAqLwog ICBldmVudF9jaGlsZC0+cGVuZGluZ19pc19icmVha3BvaW50ID0gMDsKQEAg LTk0MiwxNCArOTQ5LDE2IEBAIHJldHJ5OgogICAgIH0KIAogICBpZiAoZGVi dWdfdGhyZWFkcwotICAgICAgJiYgV0lGU1RPUFBFRCAoKndzdGF0cCkpCisg ICAgICAmJiBXSUZTVE9QUEVEICgqd3N0YXRwKQorICAgICAgJiYgdGhlX2xv d190YXJnZXQuZ2V0X3BjICE9IE5VTEwpCiAgICAgewogICAgICAgc3RydWN0 IHRocmVhZF9pbmZvICpzYXZlZF9pbmZlcmlvciA9IGN1cnJlbnRfaW5mZXJp b3I7CisgICAgICBDT1JFX0FERFIgcGM7CisKICAgICAgIGN1cnJlbnRfaW5m ZXJpb3IgPSAoc3RydWN0IHRocmVhZF9pbmZvICopCiAJZmluZF9pbmZlcmlv cl9pZCAoJmFsbF90aHJlYWRzLCBjaGlsZC0+aGVhZC5pZCk7Ci0gICAgICAv KiBGb3IgdGVzdGluZyBvbmx5OyBpMzg2X3N0b3BfcGMgcHJpbnRzIG91dCBh IGRpYWdub3N0aWMuICAqLwotICAgICAgaWYgKHRoZV9sb3dfdGFyZ2V0Lmdl dF9wYyAhPSBOVUxMKQotCWdldF9zdG9wX3BjICgpOworICAgICAgcGMgPSAo KnRoZV9sb3dfdGFyZ2V0LmdldF9wYykgKCk7CisgICAgICBmcHJpbnRmIChz dGRlcnIsICJsaW51eF93YWl0X2Zvcl9sd3A6IHBjIGlzIDB4JWx4XG4iLCAo bG9uZykgcGMpOwogICAgICAgY3VycmVudF9pbmZlcmlvciA9IHNhdmVkX2lu ZmVyaW9yOwogICAgIH0KIApAQCAtMTcwNiw4ICsxNzE1LDggQEAgbGludXhf cmVzdW1lX29uZV9sd3AgKHN0cnVjdCBsd3BfaW5mbyAqbAogCiAgIGlmIChk ZWJ1Z190aHJlYWRzICYmIHRoZV9sb3dfdGFyZ2V0LmdldF9wYyAhPSBOVUxM KQogICAgIHsKLSAgICAgIGZwcmludGYgKHN0ZGVyciwgIiAgIik7Ci0gICAg ICAoKnRoZV9sb3dfdGFyZ2V0LmdldF9wYykgKCk7CisgICAgICBDT1JFX0FE RFIgcGMgPSAoKnRoZV9sb3dfdGFyZ2V0LmdldF9wYykgKCk7CisgICAgICBm cHJpbnRmIChzdGRlcnIsICIgIHJlc3VtaW5nIGZyb20gcGMgMHglbHhcbiIs IChsb25nKSBwYyk7CiAgICAgfQogCiAgIC8qIElmIHdlIGhhdmUgcGVuZGlu ZyBzaWduYWxzLCBjb25zdW1lIG9uZSB1bmxlc3Mgd2UgYXJlIHRyeWluZyB0 byByZWluc2VydAo= --0016361e86c0638313046aabeca1--