From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29371 invoked by alias); 27 Feb 2009 19:56:23 -0000 Received: (qmail 29362 invoked by uid 22791); 27 Feb 2009 19:56:21 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 27 Feb 2009 19:56:15 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id n1RJuDd1006875 for ; Fri, 27 Feb 2009 11:56:13 -0800 Received: from rv-out-0506.google.com (rvfb25.prod.google.com [10.140.179.25]) by wpaz5.hot.corp.google.com with ESMTP id n1RJuBXu000668 for ; Fri, 27 Feb 2009 11:56:12 -0800 Received: by rv-out-0506.google.com with SMTP id b25so1140926rvf.23 for ; Fri, 27 Feb 2009 11:56:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.114.15 with SMTP id r15mr1369369rvm.42.1235764571161; Fri, 27 Feb 2009 11:56:11 -0800 (PST) In-Reply-To: <200902271941.02441.pedro@codesourcery.com> References: <20090226184107.B00611C78A7@localhost> <200902271941.02441.pedro@codesourcery.com> Date: Fri, 27 Feb 2009 21:13:00 -0000 Message-ID: Subject: Re: [RFA] Include thread ID in target_wait debugging output. From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00498.txt.bz2 On Fri, Feb 27, 2009 at 11:41 AM, Pedro Alves wrote: > Hi Doug, > > On Thursday 26 February 2009 18:41:07, Doug Evans wrote: >> Hi. >> >> Printing the result of target_wait when "set debug infrun 1" is great, >> but I've found I've needed the thread ID. >> >> The output line was getting a bit long, so I split it up. >> There are other ways to split it up, but this works for me. >> > > The downside of that, is that "set debug timespamp" will print > a timestamp for each piece of the log, and any signal debug > output in async mode will mingle up. Maybe do the printing to > a mem_fileopen buffer, and then print that to stderr in one go? Ok, I'll print to mem_fileopen first, and then print in one go. > An issue I though would be desirable to avoid here, is calling > target_pid_to_str, which isn't garanteed to not have side > effects. That's unfortunate. Is that documented somewhere? > Introducing side effects when you enable debug > output is undesirable. Yep. > Maybe print the ptid in raw form, say, > like: (pid, lwp, tid)? OTOH, infrun debugging output has been > doing that for years, so it's probably fine... Ya, there's LOTS of calls to target_pid_to_str for debugging output. > >> Ok to check in? >> >> 2009-02-26 Doug Evans >> >> Include thread ID in target_wait debugging output. >> * infrun.c (print_target_wait_results): New function. >> (wait_for_inferior,fetch_inferior_event): Call it. >> >> Index: infrun.c >> =================================================================== >> RCS file: /cvs/src/src/gdb/infrun.c,v >> retrieving revision 1.360 >> diff -u -p -r1.360 infrun.c >> --- infrun.c 25 Feb 2009 02:14:22 -0000 1.360 >> +++ infrun.c 26 Feb 2009 18:34:57 -0000 >> @@ -1737,6 +1737,30 @@ delete_step_thread_step_resume_breakpoin >> delete_step_thread_step_resume_breakpoint (); >> } >> >> +/* Pretty print the results of target_wait, for debugging purposes. */ >> + >> +static void >> +print_target_wait_results (ptid_t waiton_ptid, ptid_t result_ptid, >> + const struct target_waitstatus *ws) >> +{ >> + char *status_string = target_waitstatus_to_string (ws); >> + >> + fprintf_unfiltered (gdb_stdlog, >> + "infrun: target_wait (%d", PIDGET (waiton_ptid)); >> + if (PIDGET (waiton_ptid) != -1) >> + fprintf_unfiltered (gdb_stdlog, >> + " [%s]", target_pid_to_str (waiton_ptid)); >> + fprintf_unfiltered (gdb_stdlog, ", status) =\n"); >> + fprintf_unfiltered (gdb_stdlog, >> + "infrun: %d [%s],\n", >> + PIDGET (result_ptid), target_pid_to_str (result_ptid)); >> + fprintf_unfiltered (gdb_stdlog, >> + "infrun: %s\n", >> + status_string); >> + >> + xfree (status_string); >> +} >> + >> /* Wait for control to return from inferior to debugger. >> >> If TREAT_EXEC_AS_SIGTRAP is non-zero, then handle EXEC signals >> @@ -1790,14 +1814,7 @@ wait_for_inferior (int treat_exec_as_sig >> ecs->ptid = target_wait (waiton_ptid, &ecs->ws); >> >> if (debug_infrun) >> - { >> - char *status_string = target_waitstatus_to_string (&ecs->ws); >> - fprintf_unfiltered (gdb_stdlog, >> - "infrun: target_wait (%d, status) = %d, %s\n", >> - PIDGET (waiton_ptid), PIDGET (ecs->ptid), >> - status_string); >> - xfree (status_string); >> - } >> + print_target_wait_results (waiton_ptid, ecs->ptid, &ecs->ws); >> >> if (treat_exec_as_sigtrap && ecs->ws.kind == TARGET_WAITKIND_EXECD) >> { >> @@ -1875,14 +1892,7 @@ fetch_inferior_event (void *client_data) >> ecs->ptid = target_wait (waiton_ptid, &ecs->ws); >> >> if (debug_infrun) >> - { >> - char *status_string = target_waitstatus_to_string (&ecs->ws); >> - fprintf_unfiltered (gdb_stdlog, >> - "infrun: target_wait (%d, status) = %d, %s\n", >> - PIDGET (waiton_ptid), PIDGET (ecs->ptid), >> - status_string); >> - xfree (status_string); >> - } >> + print_target_wait_results (waiton_ptid, ecs->ptid, &ecs->ws); >> >> if (non_stop >> && ecs->ws.kind != TARGET_WAITKIND_IGNORE >> > > > > -- > Pedro Alves >