From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24866 invoked by alias); 4 Feb 2009 22:07:26 -0000 Received: (qmail 24857 invoked by uid 22791); 4 Feb 2009 22:07:26 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 04 Feb 2009 22:07:16 +0000 Received: from spaceape7.eur.corp.google.com (spaceape7.eur.corp.google.com [172.28.16.141]) by smtp-out.google.com with ESMTP id n14M7DRn005981 for ; Wed, 4 Feb 2009 14:07:14 -0800 Received: from rv-out-0506.google.com (rvbk40.prod.google.com [10.140.87.40]) by spaceape7.eur.corp.google.com with ESMTP id n14M78pF023938 for ; Wed, 4 Feb 2009 14:07:09 -0800 Received: by rv-out-0506.google.com with SMTP id k40so6095092rvb.57 for ; Wed, 04 Feb 2009 14:07:07 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.36.10 with SMTP id o10mr2745573rvj.59.1233785227872; Wed, 04 Feb 2009 14:07:07 -0800 (PST) In-Reply-To: <200902042102.10900.pedro@codesourcery.com> References: <200902031501.49657.pedro@codesourcery.com> <20090204002438.GA29944@caradoc.them.org> <200902040049.10820.pedro@codesourcery.com> <200902042102.10900.pedro@codesourcery.com> Date: Wed, 04 Feb 2009 22:07:00 -0000 Message-ID: Subject: Re: [3/2] Inspect extra signal information, handle amd64 bi-arch gdb From: Doug Evans To: Pedro Alves Cc: gdb-patches@sourceware.org, Daniel Jacobowitz , Ulrich Weigand Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-02/txt/msg00111.txt.bz2 On Wed, Feb 4, 2009 at 1:02 PM, Pedro Alves wrote: > Here's a patch that applies on top of the other two. I think > it's easy to read it split out from the other patches. > > This handles the layout conversion for x86/amd64, near the > PTRACE_[G|S]ETSIGINFO calls, like we discussed yesterday. > > I'm not adjusting gdbserver here yet, since the original series > added $_siginfo support for ARM, and x86/amd64 only, and, gdbserver > on x86/amd64 isn't biarch aware yet. We can handle doing something > like this there when we add $_siginfo gdbarch type support for ppc, or > when we add biarch support for x86/amd64. > > What do you think? I've tried to make it as pretty as I could. :-) > > Please, don't hesitate pointing me at anything bogus I may > be doing. Another way to go, for reference sake, is to write a routine that converts a struct siginfo to a string, and another that converts a string to a struct siginfo, and have both gdb and gdbserver use those routines. Then bi-arch gdbserver support would pretty much come for free. Over time it seems like a growing amount of code would be useful to share between gdb and gdbserver. Do we have a plan for that?