From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-61340-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 10240 invoked by alias); 26 Jan 2009 19:28:17 -0000
Received: (qmail 10230 invoked by uid 22791); 26 Jan 2009 19:28:16 -0000
X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 	tests=AWL,BAYES_00,J_CHICKENPOX_43,SARE_MSGID_LONG40,SPF_PASS
X-Spam-Check-By: sourceware.org
Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13)     by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 26 Jan 2009 19:28:12 +0000
Received: from spaceape23.eur.corp.google.com (spaceape23.eur.corp.google.com [172.28.16.75]) 	by smtp-out.google.com with ESMTP id n0QJS9cZ006386 	for <gdb-patches@sourceware.org>; Mon, 26 Jan 2009 11:28:10 -0800
Received: from rv-out-0506.google.com (rvbg37.prod.google.com [10.140.83.37]) 	by spaceape23.eur.corp.google.com with ESMTP id n0QJReib003840 	for <gdb-patches@sourceware.org>; Mon, 26 Jan 2009 11:28:06 -0800
Received: by rv-out-0506.google.com with SMTP id g37so6289353rvb.33         for <gdb-patches@sourceware.org>; Mon, 26 Jan 2009 11:28:05 -0800 (PST)
MIME-Version: 1.0
Received: by 10.141.172.7 with SMTP id z7mr2160252rvo.128.1232998085462; Mon,  	26 Jan 2009 11:28:05 -0800 (PST)
In-Reply-To: <004e01c97fa1$5c878fa0$1596aee0$@u-strasbg.fr>
References: <004e01c97fa1$5c878fa0$1596aee0$@u-strasbg.fr>
Date: Mon, 26 Jan 2009 19:30:00 -0000
Message-ID: <e394668d0901261128wf34080ak1b5a5d4f02dfe0d5@mail.gmail.com>
Subject: Re: [RFA] fix cygwin gdb.base/find.exp failures
From: Doug Evans <dje@google.com>
To: Pierre Muller <muller@ics.u-strasbg.fr>
Cc: gdb-patches@sourceware.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
X-IsSubscribed: yes
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
X-SW-Source: 2009-01/txt/msg00510.txt.bz2

On Mon, Jan 26, 2009 at 2:32 AM, Pierre Muller <muller@ics.u-strasbg.fr> wrote:
>  I am still running the testsuite using
> expect version 5.26 from 2003,
> because I never managed to get expect 5.43
> to run on cygwin... (no more pty available error :( )
>
>  This version has some specific troubles, limitations
> or features that make some tests fail using that version
> while they should not (or does it have to do with the
> tcl version... not really sure, I remember having read once
> something about the multiple evaluation differences
> for quoted versus braced expressions...).
>
>  gdb.base/find.exp is such an example.
>
>  By a one line patch, I fixed the 17 failures I get otherwise
> for this test.
>
> gdb/testsuite/ChangeLog entry:
>
> 2009-01-26  Pierre Muller  <muller@ics.u-strasbg.fr>
>
>        * gdb.base/find.exp: Set newline variable
>        using quotes instead of braces to fix cygwin failures.
>
>
>
> cvs diff -up gdb/testsuite/gdb.base/*
> Index: gdb/testsuite/gdb.base/find.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/find.exp,v
> retrieving revision 1.4
> diff -u -p -r1.4 find.exp
> --- gdb/testsuite/gdb.base/find.exp     3 Jan 2009 05:58:03 -0000       1.4
> +++ gdb/testsuite/gdb.base/find.exp     26 Jan 2009 10:24:04 -0000
> @@ -54,7 +54,7 @@ gdb_expect {
>
>  set hex_number {0x[0-9a-fA-F][0-9a-fA-F]*}
>  set history_prefix {[$][0-9]* = }
> -set newline {[\r\n]*}
> +set newline "\[\r\n\]*"
>  set pattern_not_found "${newline}Pattern not found\[.\]"
>  set one_pattern_found "${newline}1 pattern found\[.\]"
>  set two_patterns_found "${newline}2 patterns found\[.\]"

Someone else will have to formally approve the patch, but I tested it
on i386-linux, and it works there so the patch is fine with me.