From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9063 invoked by alias); 6 Jan 2009 00:00:59 -0000 Received: (qmail 9055 invoked by uid 22791); 6 Jan 2009 00:00:56 -0000 X-SWARE-Spam-Status: No, hits=-1.6 required=5.0 tests=AWL,BAYES_00,J_CHICKENPOX_33,SARE_MSGID_LONG40,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 06 Jan 2009 00:00:51 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id n0600nS8006138 for ; Mon, 5 Jan 2009 16:00:49 -0800 Received: from rv-out-0506.google.com (rvbk40.prod.google.com [10.140.87.40]) by zps77.corp.google.com with ESMTP id n0600DBd014491 for ; Mon, 5 Jan 2009 16:00:47 -0800 Received: by rv-out-0506.google.com with SMTP id k40so7460987rvb.15 for ; Mon, 05 Jan 2009 16:00:47 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.128.19 with SMTP id f19mr10665306rvn.9.1231200047002; Mon, 05 Jan 2009 16:00:47 -0800 (PST) In-Reply-To: References: <20081219053421.2D802412300@localhost> Date: Tue, 06 Jan 2009 00:00:00 -0000 Message-ID: Subject: Re: [RFA] linux-nat.c minor cleanup From: Doug Evans To: gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0cd1a25e72f597045fc5197b X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2009-01/txt/msg00034.txt.bz2 --000e0cd1a25e72f597045fc5197b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 2043 On Mon, Jan 5, 2009 at 3:04 PM, Doug Evans wrote: > Ping. > > On Thu, Dec 18, 2008 at 9:34 PM, Doug Evans wrote: >> Hi. >> >> linux-nat.c:linux_nat_info_proc_cmd uses a long long to record a pid. >> There's not much point in that, so this patch changes it to a long. >> [either that or it shouldn't use strtoul to parse it :-)] >> >> The handling of info proc cmd,cwd,exe is odd too. >> They're always printed and yet argument parsing looks for them anyway, >> and ignores invalid commands instead of flagging an error. >> This patch adds a blurb about printing cmd,cwd,exe in the help text. >> The manual already touches on this, though it doesn't precisely >> say that cmd,cwd,exe are always printed. >> I wouldn't mind also submitting a patch to flag unknown commands >> as errors, but I'm not sure what's intended as far as the parsing >> of cmd,cwd,exe. Going over the file I found a case I missed. atoi has undefined behaviour for invalid input so I stuck with strtoul in linux_nat_info_proc_cmd. Granted, it is awkward that some fns use long and some fns use int, but ptid_get_pid returns an int and strotul returns a long. strtopid anyone? [I realize this is just minor cleanup, but for completeness' sake, there are several uses of pid_t in linux-nat.c - maybe pid_t should be used everywhere instead of int - if one wants to be pedantic. But then one is left with either assuming it's an int or adding int casts to sprintf arguments (which the code already does). I don't have a preference, I'll make the patch look like whatever y'all want. It's just annoying to see long long used here.] This version removes the change to the doc string for "info proc". I could still use some input on what preferred: remove the argument processing to watch for cmd, cwd, exe? 2008-12-18 Doug Evans * linux-nat.c (linux_nat_find_memory_regions): Result of PIDGET is an int, not a long long. (linux_nat_info_proc_cmd): Store pid in long instead of long long. --000e0cd1a25e72f597045fc5197b Content-Type: text/plain; charset=US-ASCII; name="gdb-090105-linux-nat-1.patch.txt" Content-Disposition: attachment; filename="gdb-090105-linux-nat-1.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fplso69d0 Content-length: 5242 MjAwOC0xMi0xOCAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog bGludXgtbmF0LmMgKGxpbnV4X25hdF9maW5kX21lbW9yeV9yZWdpb25zKTog UmVzdWx0IG9mIFBJREdFVCBpcyBhbgoJaW50LCBub3QgYSBsb25nIGxvbmcu CgkobGludXhfbmF0X2luZm9fcHJvY19jbWQpOiBTdG9yZSBwaWQgaW4gbG9u ZyBpbnN0ZWFkIG9mIGxvbmcgbG9uZy4KCkluZGV4OiBsaW51eC1uYXQuYwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL3NyYy9zcmMv Z2RiL2xpbnV4LW5hdC5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjExNQpk aWZmIC11IC1wIC11IC1wIC1yMS4xMTUgbGludXgtbmF0LmMKLS0tIGxpbnV4 LW5hdC5jCTMgSmFuIDIwMDkgMDU6NTc6NTIgLTAwMDAJMS4xMTUKKysrIGxp bnV4LW5hdC5jCTUgSmFuIDIwMDkgMjM6NDE6MjIgLTAwMDAKQEAgLTMzNDYs NyArMzM0Niw3IEBAIGxpbnV4X25hdF9maW5kX21lbW9yeV9yZWdpb25zIChp bnQgKCpmdW4KIAkJCQkJICAgIHVuc2lnbmVkIGxvbmcsCiAJCQkJCSAgICBp bnQsIGludCwgaW50LCB2b2lkICopLCB2b2lkICpvYmZkKQogewotICBsb25n IGxvbmcgcGlkID0gUElER0VUIChpbmZlcmlvcl9wdGlkKTsKKyAgaW50IHBp ZCA9IFBJREdFVCAoaW5mZXJpb3JfcHRpZCk7CiAgIGNoYXIgbWFwc2ZpbGVu YW1lW01BWFBBVEhMRU5dOwogICBGSUxFICptYXBzZmlsZTsKICAgbG9uZyBs b25nIGFkZHIsIGVuZGFkZHIsIHNpemUsIG9mZnNldCwgaW5vZGU7CkBAIC0z MzU2LDcgKzMzNTYsNyBAQCBsaW51eF9uYXRfZmluZF9tZW1vcnlfcmVnaW9u cyAoaW50ICgqZnVuCiAgIHN0cnVjdCBjbGVhbnVwICpjbGVhbnVwOwogCiAg IC8qIENvbXBvc2UgdGhlIGZpbGVuYW1lIGZvciB0aGUgL3Byb2MgbWVtb3J5 IG1hcCwgYW5kIG9wZW4gaXQuICAqLwotICBzcHJpbnRmIChtYXBzZmlsZW5h bWUsICIvcHJvYy8lbGxkL21hcHMiLCBwaWQpOworICBzcHJpbnRmIChtYXBz ZmlsZW5hbWUsICIvcHJvYy8lZC9tYXBzIiwgcGlkKTsKICAgaWYgKChtYXBz ZmlsZSA9IGZvcGVuIChtYXBzZmlsZW5hbWUsICJyIikpID09IE5VTEwpCiAg ICAgZXJyb3IgKF8oIkNvdWxkIG5vdCBvcGVuICVzLiIpLCBtYXBzZmlsZW5h bWUpOwogICBjbGVhbnVwID0gbWFrZV9jbGVhbnVwX2ZjbG9zZSAobWFwc2Zp bGUpOwpAQCAtMzYwOSw3ICszNjA5LDkgQEAgbGludXhfbmF0X21ha2VfY29y ZWZpbGVfbm90ZXMgKGJmZCAqb2JmZAogc3RhdGljIHZvaWQKIGxpbnV4X25h dF9pbmZvX3Byb2NfY21kIChjaGFyICphcmdzLCBpbnQgZnJvbV90dHkpCiB7 Ci0gIGxvbmcgbG9uZyBwaWQgPSBQSURHRVQgKGluZmVyaW9yX3B0aWQpOwor ICAvKiBBIGxvbmcgaXMgdXNlZCBmb3IgcGlkIGluc3RlYWQgb2YgYW4gaW50 IHRvIGF2b2lkIGEgbG9zcyBvZiBwcmVjaXNpb24KKyAgICAgY29tcGlsZXIg d2FybmluZyBmcm9tIHRoZSBvdXRwdXQgb2Ygc3RydG91bC4gICovCisgIGxv bmcgcGlkID0gUElER0VUIChpbmZlcmlvcl9wdGlkKTsKICAgRklMRSAqcHJv Y2ZpbGU7CiAgIGNoYXIgKiphcmd2ID0gTlVMTDsKICAgY2hhciBidWZmZXJb TUFYUEFUSExFTl07CkBAIC0zNjczLDE0ICszNjc1LDE0IEBAIGxpbnV4X25h dF9pbmZvX3Byb2NfY21kIChjaGFyICphcmdzLCBpbnQKICAgaWYgKHBpZCA9 PSAwKQogICAgIGVycm9yIChfKCJObyBjdXJyZW50IHByb2Nlc3M6IHlvdSBt dXN0IG5hbWUgb25lLiIpKTsKIAotICBzcHJpbnRmIChmbmFtZTEsICIvcHJv Yy8lbGxkIiwgcGlkKTsKKyAgc3ByaW50ZiAoZm5hbWUxLCAiL3Byb2MvJWxk IiwgcGlkKTsKICAgaWYgKHN0YXQgKGZuYW1lMSwgJmR1bW15KSAhPSAwKQog ICAgIGVycm9yIChfKCJObyAvcHJvYyBkaXJlY3Rvcnk6ICclcyciKSwgZm5h bWUxKTsKIAotICBwcmludGZfZmlsdGVyZWQgKF8oInByb2Nlc3MgJWxsZFxu IiksIHBpZCk7CisgIHByaW50Zl9maWx0ZXJlZCAoXygicHJvY2VzcyAlbGRc biIpLCBwaWQpOwogICBpZiAoY21kbGluZV9mIHx8IGFsbCkKICAgICB7Ci0g ICAgICBzcHJpbnRmIChmbmFtZTEsICIvcHJvYy8lbGxkL2NtZGxpbmUiLCBw aWQpOworICAgICAgc3ByaW50ZiAoZm5hbWUxLCAiL3Byb2MvJWxkL2NtZGxp bmUiLCBwaWQpOwogICAgICAgaWYgKChwcm9jZmlsZSA9IGZvcGVuIChmbmFt ZTEsICJyIikpICE9IE5VTEwpCiAJewogCSAgc3RydWN0IGNsZWFudXAgKmNs ZWFudXAgPSBtYWtlX2NsZWFudXBfZmNsb3NlIChwcm9jZmlsZSk7CkBAIC0z NjkzLDcgKzM2OTUsNyBAQCBsaW51eF9uYXRfaW5mb19wcm9jX2NtZCAoY2hh ciAqYXJncywgaW50CiAgICAgfQogICBpZiAoY3dkX2YgfHwgYWxsKQogICAg IHsKLSAgICAgIHNwcmludGYgKGZuYW1lMSwgIi9wcm9jLyVsbGQvY3dkIiwg cGlkKTsKKyAgICAgIHNwcmludGYgKGZuYW1lMSwgIi9wcm9jLyVsZC9jd2Qi LCBwaWQpOwogICAgICAgbWVtc2V0IChmbmFtZTIsIDAsIHNpemVvZiAoZm5h bWUyKSk7CiAgICAgICBpZiAocmVhZGxpbmsgKGZuYW1lMSwgZm5hbWUyLCBz aXplb2YgKGZuYW1lMikpID4gMCkKIAlwcmludGZfZmlsdGVyZWQgKCJjd2Qg PSAnJXMnXG4iLCBmbmFtZTIpOwpAQCAtMzcwMiw3ICszNzA0LDcgQEAgbGlu dXhfbmF0X2luZm9fcHJvY19jbWQgKGNoYXIgKmFyZ3MsIGludAogICAgIH0K ICAgaWYgKGV4ZV9mIHx8IGFsbCkKICAgICB7Ci0gICAgICBzcHJpbnRmIChm bmFtZTEsICIvcHJvYy8lbGxkL2V4ZSIsIHBpZCk7CisgICAgICBzcHJpbnRm IChmbmFtZTEsICIvcHJvYy8lbGQvZXhlIiwgcGlkKTsKICAgICAgIG1lbXNl dCAoZm5hbWUyLCAwLCBzaXplb2YgKGZuYW1lMikpOwogICAgICAgaWYgKHJl YWRsaW5rIChmbmFtZTEsIGZuYW1lMiwgc2l6ZW9mIChmbmFtZTIpKSA+IDAp CiAJcHJpbnRmX2ZpbHRlcmVkICgiZXhlID0gJyVzJ1xuIiwgZm5hbWUyKTsK QEAgLTM3MTEsNyArMzcxMyw3IEBAIGxpbnV4X25hdF9pbmZvX3Byb2NfY21k IChjaGFyICphcmdzLCBpbnQKICAgICB9CiAgIGlmIChtYXBwaW5nc19mIHx8 IGFsbCkKICAgICB7Ci0gICAgICBzcHJpbnRmIChmbmFtZTEsICIvcHJvYy8l bGxkL21hcHMiLCBwaWQpOworICAgICAgc3ByaW50ZiAoZm5hbWUxLCAiL3By b2MvJWxkL21hcHMiLCBwaWQpOwogICAgICAgaWYgKChwcm9jZmlsZSA9IGZv cGVuIChmbmFtZTEsICJyIikpICE9IE5VTEwpCiAJewogCSAgbG9uZyBsb25n IGFkZHIsIGVuZGFkZHIsIHNpemUsIG9mZnNldCwgaW5vZGU7CkBAIC0zNzcz LDcgKzM3NzUsNyBAQCBsaW51eF9uYXRfaW5mb19wcm9jX2NtZCAoY2hhciAq YXJncywgaW50CiAgICAgfQogICBpZiAoc3RhdHVzX2YgfHwgYWxsKQogICAg IHsKLSAgICAgIHNwcmludGYgKGZuYW1lMSwgIi9wcm9jLyVsbGQvc3RhdHVz IiwgcGlkKTsKKyAgICAgIHNwcmludGYgKGZuYW1lMSwgIi9wcm9jLyVsZC9z dGF0dXMiLCBwaWQpOwogICAgICAgaWYgKChwcm9jZmlsZSA9IGZvcGVuIChm bmFtZTEsICJyIikpICE9IE5VTEwpCiAJewogCSAgc3RydWN0IGNsZWFudXAg KmNsZWFudXAgPSBtYWtlX2NsZWFudXBfZmNsb3NlIChwcm9jZmlsZSk7CkBA IC0zNzg2LDcgKzM3ODgsNyBAQCBsaW51eF9uYXRfaW5mb19wcm9jX2NtZCAo Y2hhciAqYXJncywgaW50CiAgICAgfQogICBpZiAoc3RhdF9mIHx8IGFsbCkK ICAgICB7Ci0gICAgICBzcHJpbnRmIChmbmFtZTEsICIvcHJvYy8lbGxkL3N0 YXQiLCBwaWQpOworICAgICAgc3ByaW50ZiAoZm5hbWUxLCAiL3Byb2MvJWxk L3N0YXQiLCBwaWQpOwogICAgICAgaWYgKChwcm9jZmlsZSA9IGZvcGVuIChm bmFtZTEsICJyIikpICE9IE5VTEwpCiAJewogCSAgaW50IGl0bXA7Cg== --000e0cd1a25e72f597045fc5197b--