From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16492 invoked by alias); 3 Dec 2008 00:26:57 -0000 Received: (qmail 16484 invoked by uid 22791); 3 Dec 2008 00:26:57 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Dec 2008 00:25:52 +0000 Received: from spaceape12.eur.corp.google.com (spaceape12.eur.corp.google.com [172.28.16.146]) by smtp-out.google.com with ESMTP id mB30PnCh009525 for ; Tue, 2 Dec 2008 16:25:49 -0800 Received: from rv-out-0708.google.com (rvbk29.prod.google.com [10.140.87.29]) by spaceape12.eur.corp.google.com with ESMTP id mB30PAHl019808 for ; Tue, 2 Dec 2008 16:25:47 -0800 Received: by rv-out-0708.google.com with SMTP id k29so3372282rvb.2 for ; Tue, 02 Dec 2008 16:25:46 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.164.1 with SMTP id m1mr6005576rve.212.1228263946874; Tue, 02 Dec 2008 16:25:46 -0800 (PST) In-Reply-To: <20081202233738.GA15530@caradoc.them.org> References: <7D653316E38B4305941199D722BF20B0@bibi> <4935A5E2.5050503@vmware.com> <20081202233738.GA15530@caradoc.them.org> Date: Wed, 03 Dec 2008 00:26:00 -0000 Message-ID: Subject: Re: Patch to support spaces in filenames & paths From: Doug Evans To: Michael Snyder , Jon Beniston , "gdb-patches@sourceware.org" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-12/txt/msg00043.txt.bz2 On Tue, Dec 2, 2008 at 3:37 PM, Daniel Jacobowitz wrote: > On Tue, Dec 02, 2008 at 01:17:22PM -0800, Michael Snyder wrote: >> Denis, is it possible that Jon's patch will serve in place of >> the filename portion of your patch? And that you could then >> resubmit your patch with just the other portions? >> >> Jon's patch: >> http://sourceware.org/ml/gdb-patches/2008-12/msg00032.html >> >> Denis' patch: >> http://sourceware.org/ml/gdb-patches/2008-12/msg00029.html > > I have not looked at the patches in depth but I encourage Denis's > approach - uniform parsing is a Very Good Thing and buildargv is what > we use elsewhere. While perhaps not applicable in Denis' case (since the command accepts "a b c" instead of "a, b, c" (though I wonder if it could accept both), for completeness' sake there is also parse_to_comma_and_eval. (gdb) printf "%d %d %d\n", 1 + 1, 2 + 2, 3 + 3 2 4 6 With buildargv it'd be (gdb) printf "%d %d %d\n" "1 + 1" "2 + 2" "3 + 3" and that just doesn't sit right. :-)