From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32221 invoked by alias); 21 Nov 2008 01:35:22 -0000 Received: (qmail 32125 invoked by uid 22791); 21 Nov 2008 01:35:21 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Fri, 21 Nov 2008 01:34:45 +0000 Received: from wpaz13.hot.corp.google.com (wpaz13.hot.corp.google.com [172.24.198.77]) by smtp-out.google.com with ESMTP id mAL1YhSc031298 for ; Thu, 20 Nov 2008 17:34:43 -0800 Received: from rv-out-0708.google.com (rvfc5.prod.google.com [10.140.180.5]) by wpaz13.hot.corp.google.com with ESMTP id mAL1YfiT006780 for ; Thu, 20 Nov 2008 17:34:41 -0800 Received: by rv-out-0708.google.com with SMTP id c5so736427rvf.16 for ; Thu, 20 Nov 2008 17:34:41 -0800 (PST) MIME-Version: 1.0 Received: by 10.141.115.6 with SMTP id s6mr43318rvm.58.1227231280983; Thu, 20 Nov 2008 17:34:40 -0800 (PST) In-Reply-To: <20081111041958.GA30329@caradoc.them.org> References: <20081003213402.7739F1C78EB@localhost> <20081030040428.GC13387@adacore.com> <20081110144528.GC12962@caradoc.them.org> <20081110204431.GA3771@caradoc.them.org> <20081111041958.GA30329@caradoc.them.org> Date: Fri, 21 Nov 2008 18:46:00 -0000 Message-ID: Subject: Re: too many "no debugging symbols found" messages from shared libs From: Doug Evans To: Eli Zaretskii , brobecker@adacore.com, gdb-patches@sourceware.org Content-Type: multipart/mixed; boundary=000e0cd2bd288f7051045c290c6b X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00574.txt.bz2 --000e0cd2bd288f7051045c290c6b Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-length: 1136 On Mon, Nov 10, 2008 at 8:19 PM, Daniel Jacobowitz wrote: > On Tue, Nov 11, 2008 at 06:10:46AM +0200, Eli Zaretskii wrote: >> I thought the original patch came with a suggestion to add an option, >> in case user wanted to see these messages. > > OK, I understand now. I'd be fine with the shared library messages > disabled or made consistent under 'set verbose'. I don't think adding > a new option would be great. How about this? I changed the calls to have_{partial,full}_symbols to two new functions objfile_has_{partial,full}_symbols. I think it's TRTTD here. This patch also adds a test for info_verbose so the messages are printed for shared libs if verbosity turned on. 2008-11-20 Doug Evans * objfiles.h (objfile_has_partial_symbols): Declare. (objfile_has_full_symbols): Declare. * objfiles.c (objfile_has_partial_symbols): New function. (objfile_has_full_symbols): New function. * symfile.c (symbol_file_add_with_addrs_or_offsets): Only print "no debugging symbols found" for main program, unless the user turns on verbosity. --000e0cd2bd288f7051045c290c6b Content-Type: text/plain; charset=US-ASCII; name="gdb-081120-symfile-3.patch.txt" Content-Disposition: attachment; filename="gdb-081120-symfile-3.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_fns5ssk20 Content-length: 4697 MjAwOC0xMS0yMCAgRG91ZyBFdmFucyAgPGRqZUBnb29nbGUuY29tPgoKCSog b2JqZmlsZXMuaCAob2JqZmlsZV9oYXNfcGFydGlhbF9zeW1ib2xzKTogRGVj bGFyZS4KCShvYmpmaWxlX2hhc19mdWxsX3N5bWJvbHMpOiBEZWNsYXJlLgoJ KiBvYmpmaWxlcy5jIChvYmpmaWxlX2hhc19wYXJ0aWFsX3N5bWJvbHMpOiBO ZXcgZnVuY3Rpb24uCgkob2JqZmlsZV9oYXNfZnVsbF9zeW1ib2xzKTogTmV3 IGZ1bmN0aW9uLgoJKiBzeW1maWxlLmMgKHN5bWJvbF9maWxlX2FkZF93aXRo X2FkZHJzX29yX29mZnNldHMpOiBPbmx5IHByaW50Cgkibm8gZGVidWdnaW5n IHN5bWJvbHMgZm91bmQiIGZvciBtYWluIHByb2dyYW0sIHVubGVzcyB0aGUg dXNlcgoJdHVybnMgb24gdmVyYm9zaXR5LgoKSW5kZXg6IG9iamZpbGVzLmMK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2cy9zcmMvc3Jj L2dkYi9vYmpmaWxlcy5jLHYKcmV0cmlldmluZyByZXZpc2lvbiAxLjc5CmRp ZmYgLXUgLXAgLXIxLjc5IG9iamZpbGVzLmMKLS0tIG9iamZpbGVzLmMJNSBT ZXAgMjAwOCAxMTozNzoxNyAtMDAwMAkxLjc5CisrKyBvYmpmaWxlcy5jCTIx IE5vdiAyMDA4IDAxOjE4OjEyIC0wMDAwCkBAIC02NzUsNiArNjc1LDIyIEBA IG9iamZpbGVfcmVsb2NhdGUgKHN0cnVjdCBvYmpmaWxlICpvYmpmaWwKICAg YnJlYWtwb2ludF9yZV9zZXQgKCk7CiB9CiAMCisvKiBSZXR1cm4gbm9uemVy byBpZiBPQkpGSUxFIGhhcyBwYXJ0aWFsIHN5bWJvbHMuICAqLworCitpbnQK K29iamZpbGVfaGFzX3BhcnRpYWxfc3ltYm9scyAoc3RydWN0IG9iamZpbGUg Km9iamZpbGUpCit7CisgIHJldHVybiBvYmpmaWxlLT5wc3ltdGFicyAhPSBO VUxMOworfQorCisvKiBSZXR1cm4gbm9uemVybyBpZiBPQkpGSUxFIGhhcyBm dWxsIHN5bWJvbHMuICAqLworCitpbnQKK29iamZpbGVfaGFzX2Z1bGxfc3lt Ym9scyAoc3RydWN0IG9iamZpbGUgKm9iamZpbGUpCit7CisgIHJldHVybiBv YmpmaWxlLT5zeW10YWJzICE9IE5VTEw7Cit9CisKIC8qIE1hbnkgcGxhY2Vz IGluIGdkYiB3YW50IHRvIHRlc3QganVzdCB0byBzZWUgaWYgd2UgaGF2ZSBh bnkgcGFydGlhbAogICAgc3ltYm9scyBhdmFpbGFibGUuICBUaGlzIGZ1bmN0 aW9uIHJldHVybnMgemVybyBpZiBub25lIGFyZSBjdXJyZW50bHkKICAgIGF2 YWlsYWJsZSwgbm9uemVybyBvdGhlcndpc2UuICovCkluZGV4OiBvYmpmaWxl cy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvc3Jj L3NyYy9nZGIvb2JqZmlsZXMuaCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS41 NwpkaWZmIC11IC1wIC1yMS41NyBvYmpmaWxlcy5oCi0tLSBvYmpmaWxlcy5o CTE4IE5vdiAyMDA4IDIxOjMxOjI2IC0wMDAwCTEuNTcKKysrIG9iamZpbGVz LmgJMjEgTm92IDIwMDggMDE6MTg6MTIgLTAwMDAKQEAgLTQ3Miw2ICs0NzIs MTAgQEAgZXh0ZXJuIHZvaWQgZnJlZV9hbGxfb2JqZmlsZXMgKHZvaWQpOwog CiBleHRlcm4gdm9pZCBvYmpmaWxlX3JlbG9jYXRlIChzdHJ1Y3Qgb2JqZmls ZSAqLCBzdHJ1Y3Qgc2VjdGlvbl9vZmZzZXRzICopOwogCitleHRlcm4gaW50 IG9iamZpbGVfaGFzX3BhcnRpYWxfc3ltYm9scyAoc3RydWN0IG9iamZpbGUg Kik7CisKK2V4dGVybiBpbnQgb2JqZmlsZV9oYXNfZnVsbF9zeW1ib2xzIChz dHJ1Y3Qgb2JqZmlsZSAqKTsKKwogZXh0ZXJuIGludCBoYXZlX3BhcnRpYWxf c3ltYm9scyAodm9pZCk7CiAKIGV4dGVybiBpbnQgaGF2ZV9mdWxsX3N5bWJv bHMgKHZvaWQpOwpJbmRleDogc3ltZmlsZS5jCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KUkNTIGZpbGU6IC9jdnMvc3JjL3NyYy9nZGIvc3ltZmlsZS5jLHYK cmV0cmlldmluZyByZXZpc2lvbiAxLjIxOApkaWZmIC11IC1wIC1yMS4yMTgg c3ltZmlsZS5jCi0tLSBzeW1maWxlLmMJMyBPY3QgMjAwOCAxNjozNjoxMCAt MDAwMAkxLjIxOAorKysgc3ltZmlsZS5jCTIxIE5vdiAyMDA4IDAxOjE4OjEy IC0wMDAwCkBAIC0xMDQ4LDEwICsxMDQ4LDE4IEBAIHN5bWJvbF9maWxlX2Fk ZF93aXRoX2FkZHJzX29yX29mZnNldHMgKGIKICAgICAgIHhmcmVlIChkZWJ1 Z2ZpbGUpOwogICAgIH0KIAotICBpZiAoIWhhdmVfcGFydGlhbF9zeW1ib2xz ICgpICYmICFoYXZlX2Z1bGxfc3ltYm9scyAoKQorICAvKiBPbmx5IHByaW50 ICJubyBkZWJ1Z2dpbmcgc3ltYm9scyBmb3VuZCIgZm9yIHRoZSBtYWluIHBy b2dyYW0sCisgICAgIHVubGVzcyB0aGUgdXNlciB0dXJucyBvbiB2ZXJib3Np dHkuICBUaGVyZSBjYW4gYmUgbWFueSBzaGFyZWQgbGlicworICAgICBhbmQg dGhlIG1lc3NhZ2UgaXMgbW9yZSBub2lzZSB0aGFuIHNpZ25hbCB0aGVuLiAg Ki8KKyAgaWYgKChtYWlubGluZSB8fCBpbmZvX3ZlcmJvc2UpCisgICAgICAm JiAhb2JqZmlsZV9oYXNfcGFydGlhbF9zeW1ib2xzIChvYmpmaWxlKQorICAg ICAgJiYgIW9iamZpbGVfaGFzX2Z1bGxfc3ltYm9scyAob2JqZmlsZSkKICAg ICAgICYmIHByaW50X3N5bWJvbF9sb2FkaW5nKQogICAgIHsKICAgICAgIHdy YXBfaGVyZSAoIiIpOworICAgICAgLyogTm8gbmVlZCB0byBwcmludCB0aGUg ZmlsZSBuYW1lIGhlcmUgZm9yIHNoYXJlZCBsaWJzLgorCSBXZSBvbmx5IGdl dCBoZXJlIGZvciBzaGFyZWQgbGlicyBpZiBpbmZvX3ZlcmJvc2UgaXMgc2V0 LCBhbmQgaWYKKwkgaW5mb192ZXJib3NlIGlzIHNldCB3ZSd2ZSBhbHJlYWR5 IHByaW50ZWQgdGhlIGZpbGUgbmFtZSBhYm92ZS4gICovCiAgICAgICBwcmlu dGZfdW5maWx0ZXJlZCAoXygiKG5vIGRlYnVnZ2luZyBzeW1ib2xzIGZvdW5k KSIpKTsKICAgICAgIGlmIChmcm9tX3R0eSB8fCBpbmZvX3ZlcmJvc2UpCiAg ICAgICAgIHByaW50Zl91bmZpbHRlcmVkICgiLi4uIik7CkBAIC0yNDIyLDcg KzI0MzAsOCBAQCByZXJlYWRfc3ltYm9scyAodm9pZCkKIAkgICAgICAgICB6 ZXJvIGlzIE9LIHNpbmNlIGRieHJlYWQuYyBhbHNvIGRvZXMgd2hhdCBpdCBu ZWVkcyB0byBkbyBpZgogCSAgICAgICAgIG9iamZpbGUtPmdsb2JhbF9wc3lt Ym9scy5zaXplIGlzIDAuICAqLwogCSAgICAgICgqb2JqZmlsZS0+c2YtPnN5 bV9yZWFkKSAob2JqZmlsZSwgMCk7Ci0JICAgICAgaWYgKCFoYXZlX3BhcnRp YWxfc3ltYm9scyAoKSAmJiAhaGF2ZV9mdWxsX3N5bWJvbHMgKCkpCisJICAg ICAgaWYgKCFvYmpmaWxlX2hhc19wYXJ0aWFsX3N5bWJvbHMgKG9iamZpbGUp CisJCSAgJiYgIW9iamZpbGVfaGFzX2Z1bGxfc3ltYm9scyAob2JqZmlsZSkp CiAJCXsKIAkJICB3cmFwX2hlcmUgKCIiKTsKIAkJICBwcmludGZfdW5maWx0 ZXJlZCAoXygiKG5vIGRlYnVnZ2luZyBzeW1ib2xzIGZvdW5kKVxuIikpOwo= --000e0cd2bd288f7051045c290c6b--