From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29986 invoked by alias); 19 Nov 2008 23:07:49 -0000 Received: (qmail 29781 invoked by uid 22791); 19 Nov 2008 23:07:48 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.31) with ESMTP; Wed, 19 Nov 2008 23:06:59 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id mAJN6vkD009907 for ; Wed, 19 Nov 2008 15:06:57 -0800 Received: from rv-out-0708.google.com (rvfc5.prod.google.com [10.140.180.5]) by wpaz33.hot.corp.google.com with ESMTP id mAJN6ex1010194 for ; Wed, 19 Nov 2008 15:06:55 -0800 Received: by rv-out-0708.google.com with SMTP id c5so159195rvf.24 for ; Wed, 19 Nov 2008 15:06:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.140.178.17 with SMTP id a17mr856978rvf.186.1227136015097; Wed, 19 Nov 2008 15:06:55 -0800 (PST) In-Reply-To: <8ac60eac0811191502r637cc72en87554285734a5911@mail.gmail.com> References: <20081119225237.1D8751C799D@localhost> <8ac60eac0811191502r637cc72en87554285734a5911@mail.gmail.com> Date: Thu, 20 Nov 2008 02:08:00 -0000 Message-ID: Subject: Re: [RFA] fix thinko in sym info From: Doug Evans To: Paul Pluzhnikov Cc: gdb-patches@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2008-11/txt/msg00516.txt.bz2 On Wed, Nov 19, 2008 at 3:02 PM, Paul Pluzhnikov wrote: > On Wed, Nov 19, 2008 at 2:52 PM, Doug Evans wrote: > >> asm-source.exp is now failing because it doesn't expect the offset >> to be printed if its zero. >> One could update the testcase, but the old behaviour is more user-friendly. > > Hmm, why didn't I notice this failure ... > It's UNTESTED for me both before and after. I'll investigate why. > >> The outstanding question is, of course, whether >> "%s + %u", msym_name, offset >> needs i18n. This patch assumes it doesn't. > > From: http://sourceware.org/ml/gdb-patches/2008-11/msg00378.html > > In addition, translating each part without seeing the whole > sentence is very difficult. Sure, but this part of the sentence seems self-contained enough that the translation could consider it as a unit. I could be wrong of course, but will pedantic translation correctness in this particular case be worth it. > I didn't want to add 8 more clauses to this if statement. No disagreement there.