From: Doug Evans <dje@google.com>
To: Joel Brobecker <brobecker@adacore.com>,
Pedro Alves <pedro@codesourcery.com>,
gdb-patches@sourceware.org
Subject: Re: [RFA] Move -nx from GDBFLAGS to INTERNAL_GDBFLAGS in testsuite
Date: Fri, 07 Nov 2008 22:43:00 -0000 [thread overview]
Message-ID: <e394668d0811071442i41b38f14gd63205b1f2488f04@mail.gmail.com> (raw)
In-Reply-To: <20081030030147.GB3635@adacore.com>
On Wed, Oct 29, 2008 at 7:01 PM, Joel Brobecker <brobecker@adacore.com> wrote:
>> I like the idea of this patch. I tend to use "set GDBFLAGS foo" in
>> my boardfiles myself.
>>
>> What do others think of it?
>
> Seems like a good idea to me as well. That's consistent with what
> we do in the Makefile, I believe.
>
>> > +# INTERNAL_GDBFLAGS contains flags that the testsuite requires.
>> > +# ??? Perhaps -nw should go here too. Dunno.
>>
>> Personally, I'd decide/chose one, and remove this comment. If
>> you leave it in, we're doomed to stare and be annoyed by
>> it forever. :-)
>
> I would put the -nw in INTERNAL_GDBCFLAGS as well. Except maybe for
> the doing some TUI-specific testing, I don't see us testing the
> debugger in graphical mode.
Any other comments? Can I check it in after moving -nw into INTERNAL_GDBCFLAGS?
next prev parent reply other threads:[~2008-11-07 22:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-21 19:06 Doug Evans
2008-10-27 12:52 ` Pedro Alves
2008-10-30 3:08 ` Joel Brobecker
2008-11-07 22:43 ` Doug Evans [this message]
2008-11-09 16:48 ` Joel Brobecker
2008-11-11 4:11 ` Doug Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e394668d0811071442i41b38f14gd63205b1f2488f04@mail.gmail.com \
--to=dje@google.com \
--cc=brobecker@adacore.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@codesourcery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox